Received-SPF: pass (google.com: domain of linux-nfs+bounces-2446-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Toon Claes <toon@iotcl.com>
To: Patrick Steinhardt <ps@pks.im>, git@vger.kernel.org
Cc: Chuck Lever <chuck.lever@oracle.com>, rsbecker@nexbridge.com, Jeff King
 <peff@peff.net>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] reftable: fix tests being broken by NFS'
 delete-after-close semantics
In-Reply-To: <8ac5e94a3930cdd2aee9ea86acda3155674b635c.1711035529.git.ps@pks.im>
References: <ZfBwZTL9zqDsac5m@manet.1015granger.net>
 <8ac5e94a3930cdd2aee9ea86acda3155674b635c.1711035529.git.ps@pks.im>
Date: Fri, 22 Mar 2024 16:15:12 +0100
Message-ID: <87frwiuwlb.fsf@to1.studio>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Patrick Steinhardt <ps@pks.im> writes:

> Fix this bug by skipping over any files that start with a leading dot
> when counting files. While we could explicitly check for a prefix of
> ".nfs", other network file systems like SMB for example do the same
> trickery but with a ".smb" prefix. In any case though, this loosening of
> the assertion should be fine given that the reftable library would never
> write files with leading dots by itself.

I'm fully supportive of this, as this will also fix any issues possibly
caused by .DS_Store files created by Finder on macOS, although it's very
unlikely they will be created in these tests.

--
Toon