Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp1922258lqz; Tue, 2 Apr 2024 01:33:32 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUEhZzjXM6XcgHuFdYAkrcSXXXAJm6FNmkkHJjonRZlDUMHNnFaJahX9WhaCSAClv3VY43tYBPmItCH+Y6mmE0Nuz3sSs4H5uiq/Zd+FQ== X-Google-Smtp-Source: AGHT+IHv7bbLYXZPrgVsIS+8gz5GVFdcH6nfe7sngWrFou+wxXSbA6qM48mDp+Qvbly2hvhwpTTi X-Received: by 2002:a17:906:6ca:b0:a4e:8370:537f with SMTP id v10-20020a17090606ca00b00a4e8370537fmr1542458ejb.4.1712046811761; Tue, 02 Apr 2024 01:33:31 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712046811; cv=pass; d=google.com; s=arc-20160816; b=uFOc6Xl5ORoGMD22J2Z4gJYkqKvVxcOvAGhA68SBv4F0hklxOngiG4GhVRxAFsU9Lp VFSl3wEBe74ZIIhWskh17vU56KQjzPyC6H9qc6Q9f4MFBSMy0i/CwkG7hj6Nc+PBdkQV QHgTPCq5xd9T4OxZsdPYpTQHjBrjOBDkf7iQ2KohyHKLu+ofUpHgkBGNeAl9hDNPY5U2 p+933mJfsGzMk61QVySqi5Ghvl3zmtz7BSKg6kYLVcFCA6BxNWMVkvhoxl76mAm1XcKx qvpbsj6b9OKB3o/EphJ9TfY5Z3D9y8/I7qZyRIqUwfTfUU0J6tv1yT3tufoSq5XfTUej l11Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:content-id:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:subject:cc:to:references :in-reply-to:from:organization:dkim-signature; bh=Y+sMESiDiEk7NQ7Fx8r6KwgieS1M3kfYVE+bjq9Liog=; fh=iSaLwgaHOKvfADkzLOGFrUURay6x1sWG9M5uP1y/TYA=; b=x2INM6J4HU67i46Q1EvaD20flLSUGi0AbXEnItcvto9xxb8/D4uhpcX5BIsvZ1sLYy AkCNQ6bn42asdO65MSaU0CwCVzb/9qLXC6WrqrCtjB2PdckwDwoG89Fl1oE+C8ys8kGc LUjIfMIjVc0ODJ5hbSNj19RbgoZwa0n8iTQfXxZfPCsbeLlhph9fSMjQMuCywATQiKaC /o6u8l5skmYuTW9oGD3NQjiDoiODUCpPObgVho2R+olLM65LSYFhLlWzFqzkYGrqg0xw VITRovxvtTquJtMn1Fp8c/Zc/a9mNvjo2A+Z2yPg/3lpU00Lg5eAk2DltJyk8MZNpjLP VoYA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="FzsIc/2t"; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-nfs+bounces-2595-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-nfs+bounces-2595-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id z9-20020a170906714900b00a4e0c393b48si5462835ejj.107.2024.04.02.01.33.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 01:33:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs+bounces-2595-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="FzsIc/2t"; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-nfs+bounces-2595-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-nfs+bounces-2595-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 78CEF1F211A8 for ; Tue, 2 Apr 2024 08:33:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C56823E47E; Tue, 2 Apr 2024 08:32:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FzsIc/2t" X-Original-To: linux-nfs@vger.kernel.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2410F1E525 for ; Tue, 2 Apr 2024 08:32:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712046773; cv=none; b=J6ovH+GoKNmOgpD3u5+nKPmujqsOSDvhqdF0/GKLswLtpCrefv4O/t+v+iqek6CwqXaiZwjvG9+Zm4gwCEvD4mKz/eRGXC4NP8zLWTcZ+s6bxItZ95N9s/f96TNrcl8H/YaXhY4ncIamZb/HzlDJuALU2Q2BUdN19jzWLn3cMV8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712046773; c=relaxed/simple; bh=SbhTatDUNlFMsocczlgnCcBAF0CiyLb5vhHsAQLt2SU=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=QZ672nOzvPfofvfwNz8G36CKE26OwWru3ksfN0yodbvEAiyT2J69hQauzpSWXQZhAOJxk3GuwrQ497g0GjwJiiHojoQ/45O2zFS0TS6hyFqogrQOCRm6ToLhOdUJPn6aVfgxCtAgBxDHaBH75hrdNbEf59hHikxVGZcLwG+Yruo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=FzsIc/2t; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712046771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Y+sMESiDiEk7NQ7Fx8r6KwgieS1M3kfYVE+bjq9Liog=; b=FzsIc/2tj8j5mb1ls42Lh9l6ewaBsQVJFLtRoA0eQzyI580YRtDInN+sRF+pUIu4ljRPH0 UxQygn8nMcpiFsk57OlDtlPHPTnkwh4nKffxn5uyas7PM37m7Qs6/ruD6tU1ohhPwFYKa7 WD/8iRWjD3KVLKunpXwx4Tto6dDnQvY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-367-5i1cRV1HP_OxdCzQ3Kdzqw-1; Tue, 02 Apr 2024 04:32:47 -0400 X-MC-Unique: 5i1cRV1HP_OxdCzQ3Kdzqw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8F188879844; Tue, 2 Apr 2024 08:32:46 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.146]) by smtp.corp.redhat.com (Postfix) with ESMTP id 66B2CC1576F; Tue, 2 Apr 2024 08:32:42 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20240401135351.GD26556@kernel.org> References: <20240401135351.GD26556@kernel.org> <20240328163424.2781320-1-dhowells@redhat.com> <20240328163424.2781320-27-dhowells@redhat.com> To: Simon Horman Cc: dhowells@redhat.com, Christian Brauner , Jeff Layton , Gao Xiang , Dominique Martinet , Matthew Wilcox , Steve French , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 26/26] netfs, afs: Use writeback retry to deal with alternate keys Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3002685.1712046757.1@warthog.procyon.org.uk> Date: Tue, 02 Apr 2024 09:32:37 +0100 Message-ID: <3002686.1712046757@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 Simon Horman wrote: > > + op->store.size = len, > > nit: this is probably more intuitively written using len; I'm not sure it makes a difference, but switching 'size' to 'len' in kafs is a separate thing that doesn't need to be part of this patchset. David