Received-SPF: pass (google.com: domain of linux-nfs+bounces-2609-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <171208672277.1654.1052289246945629541.stgit@klimt.1015granger.net>
In-Reply-To: <171208672277.1654.1052289246945629541.stgit@klimt.1015granger.net>
From: Cedric Blancher <cedric.blancher@gmail.com>
Date: Wed, 3 Apr 2024 07:29:00 +0200
Message-ID: <CALXu0Uet83m1hX05vt9qYO+xmDoPfNYZ+r09y9FJS4H=ahyjwg@mail.gmail.com>
Subject: Re: [PATCH RFC] SUNRPC: Fix a slow server-side memory leak with RPC-over-TCP
To: linux-nfs@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

On Tue, 2 Apr 2024 at 21:38, Chuck Lever <cel@kernel.org> wrote:
>
> From: Chuck Lever <chuck.lever@oracle.com>
>
> Jan Schunk reports that his small NFS servers suffer from memory
> exhaustion after just a few days. A bisect shows that commit
> e18e157bb5c8 ("SUNRPC: Send RPC message on TCP with a single
> sock_sendmsg() call") is the first bad commit.
>
> That commit assumed that sock_sendmsg() releases all the pages in
> the underlying bio_vec array, but the reality is that it doesn't.
> svc_xprt_release() releases the rqst's response pages, but the
> record marker page fragment isn't one of those, so it was never
> released.
>
> This is a narrow fix that can be applied to stable kernels. A
> more extensive fix is in the works.
>
> Reported-by: Jan Schunk <scpcom@gmx.de>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218671
> Fixes: e18e157bb5c8 ("SUNRPC: Send RPC message on TCP with a single sock_sendmsg() call")

Is this bug present in 6.6 LTS?

Ced
-- 
Cedric Blancher <cedric.blancher@gmail.com>
[https://plus.google.com/u/0/+CedricBlancher/]
Institute Pasteur