Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2604201lqz; Wed, 3 Apr 2024 03:13:02 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWqA78MWZqErMfupxDUXWePZSHrj6cqGP3H7NC/FJFeOu3tZ4Ezp5KyXTkZjxy4q1whyd2+2TtVQ6QE2wB7mBJ5o1cDouim+TrgAQLyEQ== X-Google-Smtp-Source: AGHT+IHUnMExo2r9cQR27FSh0HATDsvqL60H3jSMsW9pkSYSK2lUirapCpYMtTAL/uWuBp+jA32/ X-Received: by 2002:a05:6a00:a0b:b0:6ea:afd2:b1dc with SMTP id p11-20020a056a000a0b00b006eaafd2b1dcmr17726652pfh.29.1712139181748; Wed, 03 Apr 2024 03:13:01 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712139181; cv=pass; d=google.com; s=arc-20160816; b=xUbPuaxWU5E0F/YQyPLGmKavvV5MMGey+Q6ajb2TiJcNnPUvoF9hn/G92qHQsfKQ+P X1vjHmjBUyskLqTLbaflfRZ+mzDKWPkBQWhqSOs4DH6lHhr0z5aZS5c0omz5ede7N27+ t7gPcx6IbgARQUkA2f7eLYGhFBbcgXuZlN/pQsOv2LQPCBa+VxlxN4IOKSTimn5OrFvI 1mCL7b7d/qE9rjSvwM2B8M3OVNBpqfwCdwie4y9ns/GSsJ1BJWEA7jU5fklwJB6b0bRI mq3Rv3YDguEsMq0u9e22p3Q42Q1YgwxJrhE5iHaLTpW1XI9W5hts6nFfpy2ZlWQIq45b gntw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:content-id:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:subject:cc:to:references :in-reply-to:from:organization:dkim-signature; bh=q10XbPWbwPAYz3tVe+780L2sWGchjiaH8ntssWQEh20=; fh=OTg2WMHJtOqcpGTWyrCVDzG+wPN5q7xsQc52pUkpGv8=; b=hrR3YuZq7l+zy6WhLU138JVzFVjAM5xgnNRoJJQ8A0pRl8LPcKSZ+pmRIbWF55Eoh3 fqVSTkOhMhbFfdDBQD6xFsbACZeFJjcyYHnEKzpw//dnBk28GrT0ZrC7SEnbnYnH5gr4 lTouXZ9ylFiP4mrTwiFDbm7ciVBYtOi5dZB8NrB0g0UBoGWUVJ8d3fg9DcvW4iw6Y6jz rg1qC7AEt4oDYx5h3QlUQqU3uwTo3ESQEwVKZtnhY3lg4O23JRwpwCgplxwsO71C+47B WnBBKbcw+sPYcmf+e09e78JR8kWkhe7tDThHvYCgbW9dFr2kW6V0iXg9gACnEoJYkkxW IedQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OLh44G5F; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-nfs+bounces-2620-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-nfs+bounces-2620-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id l4-20020a656804000000b005e84998d26dsi13160938pgt.867.2024.04.03.03.13.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 03:13:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs+bounces-2620-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=OLh44G5F; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-nfs+bounces-2620-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-nfs+bounces-2620-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4E7EE292D63 for ; Wed, 3 Apr 2024 10:13:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 25CA91369B4; Wed, 3 Apr 2024 10:11:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OLh44G5F" X-Original-To: linux-nfs@vger.kernel.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75A87136679 for ; Wed, 3 Apr 2024 10:11:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712139080; cv=none; b=S2bJ5+S4Th+bKRhCRn3XtZAOeF8u1szbIedv/7APRFK4L2m167YwPgZp0XSTF3DU2OrwAsgGj8Z5nLGWL5O+SPZrM88I9ZIsJLSX2lM1udlPag7DEnGTjBchbQvpOEJg20r4vOnoItxrsfN19jdHUoaAyS5Hhs60r7mgpfei26U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712139080; c=relaxed/simple; bh=q5PvWHwoWD/1a3RxU9EydL5cEmke/jqCAXYn/kIe5KA=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=j2cbhptfnTxjwYNdctd1POpqwkXMG+BGqz1hZMgTmAhlyrkVPGl8hXGIU1hUX2ZRK1B2kNk0sDAtt0DIl8wJoTNAJpSFAEsDkWQROELw7kjiaXiyTusyUE4JFYxtZIWDyVn5s/dwdrjxuME1lwlz1rttG2gmI4OW+Z3xipwXMkg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=OLh44G5F; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712139077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=q10XbPWbwPAYz3tVe+780L2sWGchjiaH8ntssWQEh20=; b=OLh44G5FerWj7Uqjqc+NH28vrsv3uheQ10/xIzc+48r+2YxeKSwAvrdY3J0SiKLLTGkoj6 6e2xfHg2pb+K/vWBDWkb2iprz/5HhXMk25FB5j+3C8WT3MwEPRHiyAbver8CM0Og76iaIi 5JNT8W0eb4dBWrmqNAvUulHBfpvfGms= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-377-n6tZ6td_NZGxPdmOiGxErA-1; Wed, 03 Apr 2024 06:11:13 -0400 X-MC-Unique: n6tZ6td_NZGxPdmOiGxErA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AD06C185A784; Wed, 3 Apr 2024 10:11:11 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.146]) by smtp.corp.redhat.com (Postfix) with ESMTP id 51AC140C6CB3; Wed, 3 Apr 2024 10:11:08 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20240403085918.GA1178@lst.de> References: <20240403085918.GA1178@lst.de> <20240328163424.2781320-1-dhowells@redhat.com> <20240328163424.2781320-16-dhowells@redhat.com> To: Christoph Hellwig Cc: dhowells@redhat.com, Christian Brauner , Jeff Layton , Gao Xiang , Dominique Martinet , Matthew Wilcox , Steve French , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 15/26] mm: Export writeback_iter() Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3235933.1712139047.1@warthog.procyon.org.uk> Date: Wed, 03 Apr 2024 11:10:47 +0100 Message-ID: <3235934.1712139047@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 Christoph Hellwig wrote: > On Thu, Mar 28, 2024 at 04:34:07PM +0000, David Howells wrote: > > Export writeback_iter() so that it can be used by netfslib as a module. > > EXPORT_SYMBOL_GPL, please. That depends. You put a comment on write_cache_pages() saying that people should use writeback_iter() instead. w_c_p() is not marked GPL. Is it your intention to get rid of it? David