Received: by 2002:ab2:1149:0:b0:1f3:1f8c:d0c6 with SMTP id z9csp2607441lqz; Wed, 3 Apr 2024 03:20:21 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUdnZlFFwskO+987F6fzP9xWrSTzViW2MOQ/nPdKD/FGhP6Tozfe3HrgZDhf/yZddMOLT/vAual11igGy9TdoK8OhHg2gSJFC100n1qcg== X-Google-Smtp-Source: AGHT+IHOXzVtaZT6zR1GbRkGNQ3X19WmFNvkTPtQimC06/R/LLAJ/FKT2fYMPqSTymVcvl2/kNUe X-Received: by 2002:a05:6a21:114f:b0:1a7:2910:eeb with SMTP id oi15-20020a056a21114f00b001a729100eebmr2512367pzb.35.1712139621022; Wed, 03 Apr 2024 03:20:21 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712139621; cv=pass; d=google.com; s=arc-20160816; b=Fw7lR5vmurtudOh4D+WDYHpw8o7k1kUTDahvAZTHR630t1xiTISbpWnatN+FxvdF0X 4cc7bJxHPW/JXgHMIaTj8VWRSErEmLzqlrR0vENoCFv72vbTrjHp0QMiDZLoMuaoq4VG TdO9FjdhO+4wnvtiG2sUAic/ECq9N5nu/WD0LM/vPu8uWdyFj7iCmuSmpxyRwZzx6y1Q n3aKqkxrIo+IJF+Vu4mmmYA1+w3f7hbGBdRUE9/+u2YFp6y7tq6L6lUMoIVBXaZt5foT I9mFcQR8plrZSGBZ9ZVu8Lzi1C3tLH+z8sLWceTH76IoTZWwnZ4H6zb//gG35RhYYIe3 CBdA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=wRmR6AI2ldUS1rTXsbX4iobO+9G4Si90pWgzfObepuU=; fh=cnYdpNENnE/NrrJJx31EzsBsZsUnT60bzd3it6MOHDE=; b=FfXOVbWJ7b0OPXF/8vWYEkj4TefzPksh6l1jWNsUVj3fOzHwPhRCCyQGxK/QKflYCl lvXrl09ad1OfPNBRrgKB/QGwLlLzybHuUjXW/gYhp7hfdyDTkiSxV+VVdfyKWc4toFlE apn8EcUVx8Eyj3RhIsmS0L6kpqOz8HyIcs1QVmLLqv1YNUzeN0aRRS3KyS1GGdTrYTBO k4Md5n6RLw35iUwVzNHvGhuDyOTRIZ5aSdkoZkau56cgNChXJRF8MxfK7NmCz/sMMVGV NWtVOZM6S4MZO2Ug3gH3QSLcKKSN7UEFUaRll+gEOdlUFdUBAN3g1pQ+XPO+6pG1AprD ousQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-nfs+bounces-2621-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-nfs+bounces-2621-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d13-20020aa7814d000000b006e6b77f6aabsi12804175pfn.263.2024.04.03.03.20.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 03:20:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs+bounces-2621-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=lst.de); spf=pass (google.com: domain of linux-nfs+bounces-2621-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-nfs+bounces-2621-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id A834E28C05A for ; Wed, 3 Apr 2024 10:15:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AEC21139588; Wed, 3 Apr 2024 10:14:30 +0000 (UTC) X-Original-To: linux-nfs@vger.kernel.org Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB91054F8C; Wed, 3 Apr 2024 10:14:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712139270; cv=none; b=uZa8KMoTShY3tXqr7yNNeRCgyBQBZGk0nXwi9zKHjxKOoArOgm52HtToR1q9o+t+AaTBvcHud2fIVO35jQMrM0cWUKYlmAkNFJMP/o6gBUfOJywVuh5RLtSAzDefn+3Rs1SCluOEkx8+uBVSIPBT37FMIbhpV8O+06jj73w2YvQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712139270; c=relaxed/simple; bh=r5zbDD1xPnIx0hjHcD74GYNbkecVM237ZbayTgPGrgY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ONJJdcrrfHK/njyv8lqjFQLjBDbQyuOXi4JOaLtDSkqeu1/byFaZAZ6oYpEiCgpPDYRCZv06xmikDikYgLYZ8o+zKGDvW8KS82EiZ09asqrNq7qO682IHJBiEgC58XKp855P7AhidgFDG5OLdaRKAMxfm1N1ciJSzFTb6ryK9pc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 44E2068BEB; Wed, 3 Apr 2024 12:14:22 +0200 (CEST) Date: Wed, 3 Apr 2024 12:14:22 +0200 From: Christoph Hellwig To: David Howells Cc: Christoph Hellwig , Christian Brauner , Jeff Layton , Gao Xiang , Dominique Martinet , Matthew Wilcox , Steve French , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 15/26] mm: Export writeback_iter() Message-ID: <20240403101422.GA7285@lst.de> References: <20240403085918.GA1178@lst.de> <20240328163424.2781320-1-dhowells@redhat.com> <20240328163424.2781320-16-dhowells@redhat.com> <3235934.1712139047@warthog.procyon.org.uk> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3235934.1712139047@warthog.procyon.org.uk> User-Agent: Mutt/1.5.17 (2007-11-01) On Wed, Apr 03, 2024 at 11:10:47AM +0100, David Howells wrote: > That depends. You put a comment on write_cache_pages() saying that people > should use writeback_iter() instead. w_c_p() is not marked GPL. Is it your > intention to get rid of it? Yes. If you think you're not a derivate work of Linux you have no business using either one.