Received-SPF: pass (google.com: domain of linux-nfs+bounces-2628-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 3 Apr 2024 09:24:30 -0400
From: Chuck Lever <chuck.lever@oracle.com>
To: Cedric Blancher <cedric.blancher@gmail.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH RFC] SUNRPC: Fix a slow server-side memory leak with
 RPC-over-TCP
Message-ID: <Zg1YjvJ3zE+S9B/p@tissot.1015granger.net>
References: <171208672277.1654.1052289246945629541.stgit@klimt.1015granger.net>
 <CALXu0Uet83m1hX05vt9qYO+xmDoPfNYZ+r09y9FJS4H=ahyjwg@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALXu0Uet83m1hX05vt9qYO+xmDoPfNYZ+r09y9FJS4H=ahyjwg@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?3WrDrxyzsBRJ1dtxhgLEqH80VDvRnfiYSgr8Cp/spO2hE4iT3VVqOuqaKyxH?=
 =?us-ascii?Q?5/zwQSr/wQMcEawitba+Az1520SIBWGiUnFDoLmu3Gn3ycLMMufymdto5vrl?=
 =?us-ascii?Q?0LQMHiomgrwsSU3LLWJLsFHJys6XAFChB526N/AY/wR4QBWAKtwisbl4KI6M?=
 =?us-ascii?Q?84/DTVNarA7J/TVzkmgyU9l6pBcGsaq0WHlVxwYSlTx17ie1kki6jfQwKByA?=
 =?us-ascii?Q?i90ELnY1GUIQkz30z2NqcBp0h2YGUxruPAA2+mj2QkXTePB9beO5uG5nhKrb?=
 =?us-ascii?Q?lBAHtwTgl4kjkx1G5DUnjMA5vzS9cPebymZsKTmfBRtg6OPg/UU8EDaA6EXt?=
 =?us-ascii?Q?p05W50BY84o0zq0w2GBfRmUbTbNEDMr531D+7ICz3lkfnF1gFeQFnBQcQ/pI?=
 =?us-ascii?Q?/v47D8sulWJ1zM6lvFDL1/YYidSa29oKrOiPsz0BSCryzNPupBYckbFpayLF?=
 =?us-ascii?Q?FXTmk1yFIC7M05llMh2qJz0YkjhB/GcGw9CqsF6trMjc7XTmcj31MBib+APN?=
 =?us-ascii?Q?GfezB31Q/AaXGdikjeLX/aM7oJ0poS+/f8DHQBQvKrWEEt3mUvg/tM97K5z9?=
 =?us-ascii?Q?NoPDFOZNzo2P8lnzX16jU9J+4E8D0PTWEH0Fh0dxec/Xd9jK+mp+roglzPj6?=
 =?us-ascii?Q?HXy6RqGreENXbBJ/ly9R7lWaVgHWoCJlMP0roQ4s7sq3M7Ied5C/qF6ojAeD?=
 =?us-ascii?Q?PEBsbLc9W25oTkErjpbbd7C6hH6M7oXpxwHwyC1Af7e19buRt8JMcqYx32sH?=
 =?us-ascii?Q?Tt+icMQvDqnRX+/ji7Ozr4rH0mYtA9rvwRdo+6dsHWWH7/4QLZPXwZxwnykr?=
 =?us-ascii?Q?Sfo3jX6xJHTuRbwm+nrMP8caw5P2XkXxhZXPkCtnTQ9FaDGgQrIgdX3pQZoj?=
 =?us-ascii?Q?5fIX5Wm21ec8rN/HpmrDjdS4GP9VIy+nx6atCVgs1tSodeYdhEiCvnfHw0vA?=
 =?us-ascii?Q?1menGcA/umVsGUyI8RbqX5FhBF1tQCokD18cA839teRIXEf9yTw6PJIcdZFP?=
 =?us-ascii?Q?ERX7YlX/cbEGN1VOhoEoKQwzUfCB+atJLHX0q/LVelrvjRbfafF55t9HOmdC?=
 =?us-ascii?Q?TXcmRE3negLVr10hhK+NO19Kx3vpy26NLUCo8JZ3cBecLiayOvjCvN7mOBFA?=
 =?us-ascii?Q?rllCp6ogK+LghZiBx8fvABAa6deJaGBORXUxVHO/svPL3CCJxE5af1WzyQHC?=
 =?us-ascii?Q?RCsQhknPkFS+93P2B81Rtv0L15jkLsl4JmyVhHEPJfXF+NSUZCcjO3M1YEF9?=
 =?us-ascii?Q?xBw1aCVKLSTsyfmnHsDdKPVSEFw4BGo8AW53ATU6wHPs394qRAx0d+c8KsZQ?=
 =?us-ascii?Q?ZuHszCKOhPM1ov+J4nAkhUjWFyPspS8zk4LnvpOg6yQO7jUf9SKM3AJRZuBD?=
 =?us-ascii?Q?ri24/DP/wEaqO6Piyw6Mm5CynSCXExsjCyjSB8pU9lEXXOv6mhboHEAQ0p0N?=
 =?us-ascii?Q?SKnWbxqH5VmjDa8FwQRGjtXIac7E4X6uGq7setgXAOvqAoimuVVNiltYFKrU?=
 =?us-ascii?Q?5+TD3dYAFjYElA5FgyWLEGp+lU3siCD/X8wmQfur1/XGiyxikBKsWU9YJl5R?=
 =?us-ascii?Q?zgq0h+hDgYgptPh58GYNSz5OS/WVH/TWni0K6X+UfiEGpRmafbFcXZEFENPz?=
 =?us-ascii?Q?uw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	KHJowIP+GFE3R5hU8ApYRc1436TXVl19U0s2ZxaT5h5ordPArgRdWYu4A/AGtFniUk1iMNC4Yf+iLru6t2mR8zKzbPnRw5f5ic86qlpMRJuw3Qlqg6BxlCnTJq3z9AQgXS2MEJBudxvOCXBZKKaknr1fgIPNr9s8qoqiqVYokRTFL9AtrlwimCr092x1F4vrpMBU/hGkpbf56g7UybwY8cnGT8XW8TxAT2owQE87PvrT4MoAsY4tmRo7GPTDIc9CF1/CZFd0zT5QmH0LM0ZKAbz+IlhjC0jtu/ifnzdhVVhJ97EfAH7Zmjyb3P0wRacW3mCW9AVWnDwr+CuWbrXDKh6c15xRzCsMUjH4ScLAArOCKcpunCOcuBU+yPOIK99sv9oCuvGsMyH6vb7WCT/CMCawfvPaepDeSt6AOMPS4yGrPm2atsz9Yy9R8nhoqrqhl2jMtOXXvzBoia4zpvzNcSOLnCW7429bj6zrKQRaeGQNRg74ReGErbNa0j/NGSFWjdRR9eRcKcEiYQEmilUoDs+FGGAkYMd8n/xaNW2DxGaiBCoTU7ZNiLFcT+2zxl/XD1PD9hAROpejaQ+B6j8Ezbf4JXq7N10+7+RvRmihTIg=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 101761fc-b775-4515-6549-08dc53e1667d
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2024 13:24:33.4106
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 399Ctka/CVSNi1uo6NcJ50DsQ9oqEkEQm/5wkrg2vansFKOhQnA5PwAxvLtKkeLr6N1cb9A/XOLW1uFCYmeTvg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR10MB5605
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-03_12,2024-04-03_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0
 phishscore=0 bulkscore=0 spamscore=0 adultscore=0 mlxlogscore=966
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2403210000 definitions=main-2404030092
X-Proofpoint-ORIG-GUID: yVq0R4TXgcdiMzkPBonXguOkjg_0E4C6
X-Proofpoint-GUID: yVq0R4TXgcdiMzkPBonXguOkjg_0E4C6

On Wed, Apr 03, 2024 at 07:29:00AM +0200, Cedric Blancher wrote:
> On Tue, 2 Apr 2024 at 21:38, Chuck Lever <cel@kernel.org> wrote:
> >
> > From: Chuck Lever <chuck.lever@oracle.com>
> >
> > Jan Schunk reports that his small NFS servers suffer from memory
> > exhaustion after just a few days. A bisect shows that commit
> > e18e157bb5c8 ("SUNRPC: Send RPC message on TCP with a single
> > sock_sendmsg() call") is the first bad commit.
> >
> > That commit assumed that sock_sendmsg() releases all the pages in
> > the underlying bio_vec array, but the reality is that it doesn't.
> > svc_xprt_release() releases the rqst's response pages, but the
> > record marker page fragment isn't one of those, so it was never
> > released.
> >
> > This is a narrow fix that can be applied to stable kernels. A
> > more extensive fix is in the works.
> >
> > Reported-by: Jan Schunk <scpcom@gmx.de>
> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218671
> > Fixes: e18e157bb5c8 ("SUNRPC: Send RPC message on TCP with a single sock_sendmsg() call")
> 
> Is this bug present in 6.6 LTS?

It was introduced in v6.6, so yes.

~/linux $ git describe --contains e18e157bb5c8
v6.6-rc1~108^2~27
~/linux $

Once this fix is merged upstream, the LTS maintainers will notice
the Fixes: tag and backport it to v6.6 automatically.

-- 
Chuck Lever