Received-SPF: pass (google.com: domain of linux-nfs+bounces-2627-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 3 Apr 2024 09:20:17 -0400
From: Chuck Lever <chuck.lever@oracle.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna@kernel.org>, Jeff Layton <jlayton@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, NeilBrown <neilb@suse.de>,
        "J. Bruce Fields" <bfields@fieldses.org>,
        Arnd Bergmann <arnd@arndb.de>, Olga Kornievskaia <kolga@netapp.com>,
        Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
        "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 19/34] sunrpc: suppress warnings for unused procfs
 functions
Message-ID: <Zg1XkUMOjE0UmLYI@tissot.1015granger.net>
References: <20240403080702.3509288-1-arnd@kernel.org>
 <20240403080702.3509288-20-arnd@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240403080702.3509288-20-arnd@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?Hajgfo9A81p4xnpPdaXkgmN97eSf0xx2HAKhJDXwZB7yCgluwutYSLBTsgOE?=
 =?us-ascii?Q?vVJtSOZceWUzX3+BjlrrLetZhnO1XwtGsEeFqxLgsnEXcBNJ0ZpanArklyTO?=
 =?us-ascii?Q?WXkAbohO2oYO4uWvU4H3E5UeSNDDysb57kVODjKBWqr1SeJ7y9wh4umL2KzS?=
 =?us-ascii?Q?CZqs8Z9ldBw7pxQlJeGfxgHv3khNteAb3jx9ANCfURmjPq24Kgr7RcmD5fsj?=
 =?us-ascii?Q?KrL7pN6o70uwZrIHvNEU13UwZ0LJdEVr9kKp+AStZTGk8SdSjmyubESDV5bo?=
 =?us-ascii?Q?tMfjRkahmCmV4pARvf5bMEZjsarIttTaLT7Kzum6DL3wDBFTmnZicHf5uTw5?=
 =?us-ascii?Q?HRzgY+ag6dNAnyVDMtTOdlygvzkWZvgEB7JxECAkUnp/PpdonCcXCYKyeE2o?=
 =?us-ascii?Q?XkoOEG+0ip8Lzj4GABtYsLijDxLZZqwGnqYXC+ffwDmqJYFrjhFVtFtAHo9K?=
 =?us-ascii?Q?talmE25c+wRB11V/BzS/fUOMrJwm++kcOPb9srIWNgMZzGosWHSq107ikP57?=
 =?us-ascii?Q?asJZsAai4pP2hid0XDJrn1zefpsI0+ZJz2vwvUTJtIYWHSIgVOrsWCnFiGow?=
 =?us-ascii?Q?PDPPcdNpupk084/B9BQheU+u3hAzSb/8/yY5R1AIcQHOsjH4U8pwB708eb8C?=
 =?us-ascii?Q?pPlgqssOtvGooib3XZLlLbduk0K/imJyW+A91CoJnC5e7vdhybWarvn64eY4?=
 =?us-ascii?Q?aLeTX+jBtHZbZKd3xoEqlKVUom8X9M2GwUWtAj4XwMzcXcoPiQ8WetJyPIoh?=
 =?us-ascii?Q?vHaGX3YvT9thtEwqnZPcCn/oDdJMby4u+xB3nf93/iYGGTGFDljkOy0FIgiS?=
 =?us-ascii?Q?vyBLzEv0vdRGyb766zoCrgUXE2IFytiup6F/rM80tj29oelQlLG/x3ZbITiK?=
 =?us-ascii?Q?cBBzPB76tcRCdT7r7LPyiyy4RMVhUjFA2wLNOAOrXUrtOLw7zS4IVxpk33om?=
 =?us-ascii?Q?jzWkChbV3N/Uqu1oVMRwVI3wvp2rMBVKeip/Q7QI1/arhi2Jb3y7YPA+ZEqT?=
 =?us-ascii?Q?sRWpI6Xl17sZSAaTZwWsP77pybyW77XPPAWiByF5pD7YAHxh0NQN8uMmo4xD?=
 =?us-ascii?Q?AzAP8kVM1pH4BDNGniNG1iPmkL511XwL2Lt3srT+cRFNMJP3NtE63nVNPNM6?=
 =?us-ascii?Q?qHwr77UpUSxORyBn+W8CBOLBC8nXvkYSyvCaJtJ4Pi3UkAECZ9bJTqNPgS9Q?=
 =?us-ascii?Q?fhlUMwKLfo8NJu4B+B/Fj2VST+IaFkWTB4HGov49WPqHNeMm3pl4e3yTpgZY?=
 =?us-ascii?Q?EDw/QMMXXpK46g90RzIPv+msTissQdlug1yH/Z8sTXaRS0xndFXKToZAiVax?=
 =?us-ascii?Q?o9v4259A851a0iUxYgheUMEoVHcwQVnTV7mmAFBqzc2CplyamT9nKA+7wTrE?=
 =?us-ascii?Q?lzjRIOxKFa4hHi0/dmWru314O2GGGb+YrVZwt4cu0FTDzTAupEQLUNk1nB/4?=
 =?us-ascii?Q?F6y+2t+0c/T4RvFwJnly0GINOzJPAJO95RFSHMAq05hLpk3G01zuCDizkEko?=
 =?us-ascii?Q?40h3BZx9CZRK/q0dWd7EguhemdKvglPeSFKUMIzYYV5meTqqWesdzmf2m93m?=
 =?us-ascii?Q?5unrf0TwWJAOt+Iej5tnco0PWrIZeUAliOmIUN41eSuH2Ezt/e2Oy4scNIjD?=
 =?us-ascii?Q?1w=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	vTjiDDBfwwxv7tzWbh0t55bRzXjRLLfwfOIwe4zbv5vYRcDPLLsn91ThqIhQtqL3+Ivr3imr4r5PjqlhUbesLcHa5+pWRYzgpiJXR3h0uB2A3KF83AzjGBSYiN2SH9PZzAFxZB1g4ssdsh8RDrHtjkQ5Hv4GHJTzDNGhOM5yfAH6JWfunzatAHlVfM0Qd1bPPGUeXjPGjZO/XQRQoB1CC63jBBb8uVQEi+yFKKS74oB7nFxNNE2BO+BvtotbbpyPF5+4airh/TxzzQQ/+nd5L/ubiYGf0yUXmJukE5x42ZXic9ZW9yB+UY3WPyJfru04PrqgW3/MMDfmOEeyoxE9yc1uH6bRCtW8sQkfHJ2xSiTs3Gb+nmwZCYuyLuHDk/oeaecTG6/evCvR52ejw1yzl6PW27F1kuQzwIzOPpTY2iOFe+NK5oBZ4xDtXhOnxU2l16IYPMTkG+Marcgqm2yoW7g5q9G6x9DZcPdBnNM15sMeNQf4r7N8Nzl1mqfiD95pZLg70LNV9Fegc7JnuVjUXvE39OblsPISqbDDdaY9kd8g6D2aLj21L6I+C/WQSpLDXMLYZ6WjAvilXJuHzhmVTeQHmzlzDvnbOhXqviNM8u8=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ab55349b-8269-4e87-ea16-08dc53e0d061
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2024 13:20:21.5339
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4SCFf8L4XhrdoUmd8WZ64qK5r3Nr+cIj06qkWZVMEogCNYZRFchlKwlSuCs0zpeC0cIh0w84CTILvYci7eu0zw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB6294
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-03_12,2024-04-03_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0
 phishscore=0 bulkscore=0 spamscore=0 adultscore=0 mlxlogscore=999
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2403210000 definitions=main-2404030092
X-Proofpoint-GUID: I36AMHBrd2AJYSmB2RfCsmZkc85zqx0Z
X-Proofpoint-ORIG-GUID: I36AMHBrd2AJYSmB2RfCsmZkc85zqx0Z

On Wed, Apr 03, 2024 at 04:06:37AM -0400, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> There is a warning about unused variables when building with W=1 and no procfs:
> 
> net/sunrpc/cache.c:1660:30: error: 'cache_flush_proc_ops' defined but not used [-Werror=unused-const-variable=]
>  1660 | static const struct proc_ops cache_flush_proc_ops = {
>       |                              ^~~~~~~~~~~~~~~~~~~~
> net/sunrpc/cache.c:1622:30: error: 'content_proc_ops' defined but not used [-Werror=unused-const-variable=]
>  1622 | static const struct proc_ops content_proc_ops = {
>       |                              ^~~~~~~~~~~~~~~~
> net/sunrpc/cache.c:1598:30: error: 'cache_channel_proc_ops' defined but not used [-Werror=unused-const-variable=]
>  1598 | static const struct proc_ops cache_channel_proc_ops = {
>       |                              ^~~~~~~~~~~~~~~~~~~~~~
> 
> These are used inside of an #ifdef, so replacing that with an
> IS_ENABLED() check lets the compiler see how they are used while
> still dropping them during dead code elimination.
> 
> Fixes: dbf847ecb631 ("knfsd: allow cache_register to return error on failure")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Chuck Lever <chuck.lever@oracle.com>


> ---
>  net/sunrpc/cache.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c
> index 95ff74706104..ab3a57965dc0 100644
> --- a/net/sunrpc/cache.c
> +++ b/net/sunrpc/cache.c
> @@ -1673,12 +1673,14 @@ static void remove_cache_proc_entries(struct cache_detail *cd)
>  	}
>  }
>  
> -#ifdef CONFIG_PROC_FS
>  static int create_cache_proc_entries(struct cache_detail *cd, struct net *net)
>  {
>  	struct proc_dir_entry *p;
>  	struct sunrpc_net *sn;
>  
> +	if (!IS_ENABLED(CONFIG_PROC_FS))
> +		return 0;
> +
>  	sn = net_generic(net, sunrpc_net_id);
>  	cd->procfs = proc_mkdir(cd->name, sn->proc_net_rpc);
>  	if (cd->procfs == NULL)
> @@ -1706,12 +1708,6 @@ static int create_cache_proc_entries(struct cache_detail *cd, struct net *net)
>  	remove_cache_proc_entries(cd);
>  	return -ENOMEM;
>  }
> -#else /* CONFIG_PROC_FS */
> -static int create_cache_proc_entries(struct cache_detail *cd, struct net *net)
> -{
> -	return 0;
> -}
> -#endif
>  
>  void __init cache_initialize(void)
>  {
> -- 
> 2.39.2
> 

-- 
Chuck Lever