Received: by 2002:ab2:2441:0:b0:1f3:1f8c:d0c6 with SMTP id k1csp111872lqe; Thu, 4 Apr 2024 00:52:47 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWDAE1sLL7xFiUagDrBVUMQYXZ5MUfXTKcxO2kBdWQGPmgIInKjPqecSoLVuF9YlIv2D3dn5smSdyEZ0FEXAD3QIa0SuqCx46jJKd31+w== X-Google-Smtp-Source: AGHT+IGtOlCc2InV7jIsGiO2eXCpY1XYfv5V2RJvcEQLzLSi1AwqBvvGw7DsJ5UkReYG8Gy3cCSk X-Received: by 2002:a17:907:9693:b0:a4e:6622:8797 with SMTP id hd19-20020a170907969300b00a4e66228797mr1255602ejc.68.1712217166154; Thu, 04 Apr 2024 00:52:46 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1712217166; cv=pass; d=google.com; s=arc-20160816; b=MM92J9cXILZR7M3k7JVN9yYx+AlWTB3RcAVQ2h9sHCteopkgfNEDgH3qkNIh/rz7xN bcShfD3Zc83zCZT/nTcYo9vrDzUwtZYopAF4LO9DL96t59XeVQe1xdod7o0gR80UV9tO 1axh7jtJK1l7sjfkmmxV1carSSdpuCsdcOSAwM1EE+ygk68wfvQBypc7Fj23gDZb0I7A GhF2iSXEpJTciOFlL1DLjYXMFfZOAUoCE0XE/5VZFVsQCS7isz85mKhabLviRkOS8Wuj Bt/bgIsad03ekR6lh4vomVqTPliKquk5YLSG2jjbYjWOPN6EYkl2qvL5EiWyCEscvxVs 4zzA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:content-id:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:subject:cc:references:in-reply-to :from:organization:dkim-signature; bh=C9vFcjZDN/Fxaa0QMjaZwgnMDGjE5U9a9cC8FQf1Wik=; fh=trzqEJKyYBw3n01roX+QIoHQKLad71knxN4HASvT2+Y=; b=KScLWabxFK2EgGJK8LIp+rI1xrXKeiqTSW/u5tQSUHtgjURv5mI4St36GkefM8XVR3 h8apFdQ8mJyeSosIGUjMMHnUWfoQB51dBBAuywt9HGJEpjlG2dm8i8f4gMHsOoZopfQn E430VgwO7VVuRrCHpShm9kJU4TzAiKhD6oKN8hHoXj8DjoofHk4V9n6D+MTmuhx/Y5kM PwNC/2iAinSwTqi3YeGJiAtyYGN+8m1w7g7c2zElUlgNRZ8kpq9tfQgcZv4BanjEszPN WsPJkV6txLug9pdvqg6nQtrG3kRCdBmzlZrYc/QlUzO0lEy3vBimnb4+/gsb+l1A/0x+ Z9sA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=M8zHQR8J; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-nfs+bounces-2634-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-nfs+bounces-2634-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id b19-20020a170906491300b00a518bfad906si242779ejq.874.2024.04.04.00.52.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 00:52:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs+bounces-2634-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=M8zHQR8J; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-nfs+bounces-2634-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-nfs+bounces-2634-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 866A71F229D1 for ; Thu, 4 Apr 2024 07:52:21 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 619145A110; Thu, 4 Apr 2024 07:52:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="M8zHQR8J" X-Original-To: linux-nfs@vger.kernel.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D375E5B208 for ; Thu, 4 Apr 2024 07:52:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712217129; cv=none; b=CWFTE1C0f2LAjOQyFLca46WPrV/ttidIGtTD+BFu5rGEK/H2JOBdFRE39S+AS4Ve010Wvnp63lVYgwREpR+GWthGDUE8AB0adE9DzyKfycWFWD+sWo0LaAa7yX7vCCva44EVKm4rThkXi6iNMUCut9JJosvOJewUSbg5CbJdMkc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712217129; c=relaxed/simple; bh=xuyJ4Vq6zUtNBwqm/4jt8kNEn56EDs4LkP7OBIGqEmE=; h=From:In-Reply-To:References:Cc:Subject:MIME-Version:Content-Type: Date:Message-ID; b=uRinTMYZk3XzGsj64ORei3Xkz7ilfRlc2HtclGa5HKvymZqa5oMw+U4ZHbgGsBMc+T2wVSJ1jLUUtYEV1sfUimvuPkaNcyJcnIy32xu0uinzu0katbUDRRAYno+1VG9hmZouDc5Agmz5N9YUvhn6KL4O5nuTjPqNGdEufiq7JrY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=M8zHQR8J; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712217127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=C9vFcjZDN/Fxaa0QMjaZwgnMDGjE5U9a9cC8FQf1Wik=; b=M8zHQR8JbNA08ddSuEOy1A5jTP2se3bW2RRVTwNd8JpmQBoygLCW6xDPyw+mXHF2T/da/f 8sdS0qH5Uj3t0dsYBd7ViHQJTe5Sx0kYAnVz4DnImDg91dSKfYHPODwKHxE+aPwKVKpvrd 8oOTiv585pziah28yOYOGyvvyh0hKCo= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-668-4vRV2FK2MnqAak7lNxvr5w-1; Thu, 04 Apr 2024 03:52:01 -0400 X-MC-Unique: 4vRV2FK2MnqAak7lNxvr5w-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A8E333806736; Thu, 4 Apr 2024 07:52:00 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.146]) by smtp.corp.redhat.com (Postfix) with ESMTP id 739012166B33; Thu, 4 Apr 2024 07:51:56 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20240328163424.2781320-22-dhowells@redhat.com> References: <20240328163424.2781320-22-dhowells@redhat.com> <20240328163424.2781320-1-dhowells@redhat.com> Cc: dhowells@redhat.com, Christian Brauner , Jeff Layton , Gao Xiang , Dominique Martinet , Matthew Wilcox , Steve French , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Latchesar Ionkov , Christian Schoenebeck Subject: Re: [PATCH 21/26] netfs, 9p: Implement helpers for new write code Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3655510.1712217111.1@warthog.procyon.org.uk> Date: Thu, 04 Apr 2024 08:51:51 +0100 Message-ID: <3655511.1712217111@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 David Howells wrote: > + size_t len = subreq->len - subreq->transferred; This actually needs to be 'int len' because of the varargs packet formatter. David