Received-SPF: pass (google.com: domain of linux-nfs+bounces-2637-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
	Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
	Kingdom.
	Registered in England and Wales under Company Registration No. 3798903
From: David Howells <dhowells@redhat.com>
In-Reply-To: <171215477898.1643.12386933275741788356.stgit@klimt.1015granger.net>
References: <171215477898.1643.12386933275741788356.stgit@klimt.1015granger.net>
To: Chuck Lever <cel@kernel.org>
Cc: dhowells@redhat.com, linux-nfs@vger.kernel.org,
    Jan Schunk <scpcom@gmx.de>,
    Alexander Duyck <alexander.duyck@gmail.com>,
    Jakub Kacinski <kuba@kernel.org>,
    Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [PATCH 2] SUNRPC: Fix a slow server-side memory leak with RPC-over-TCP
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3747894.1712235857.1@warthog.procyon.org.uk>
Date: Thu, 04 Apr 2024 14:04:17 +0100
Message-ID: <3747895.1712235857@warthog.procyon.org.uk>

Chuck Lever <cel@kernel.org> wrote:

> That commit assumed that sock_sendmsg() releases all the pages in
> the underlying bio_vec array, but the reality is that it doesn't.
> svc_xprt_release() releases the rqst's response pages, but the
> record marker page fragment isn't one of those, so it is never
> released.

More like the network layer will take its own refs and drop those when it is
done.  As you say, it doesn't release the caller's refs.

Reviewed-by: David Howells <dhowells@redhat.com>