Received-SPF: pass (google.com: domain of linux-nfs+bounces-2721-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0
From: "NeilBrown" <neilb@suse.de>
To: "Chen Hanxiao" <chenhx.fnst@fujitsu.com>
Cc: "Chuck Lever" <chuck.lever@oracle.com>, "Jeff Layton" <jlayton@kernel.org>,
 "Olga Kornievskaia" <kolga@netapp.com>, "Dai Ngo" <Dai.Ngo@oracle.com>,
 "Tom Talpey" <tom@talpey.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] NFSD: remove redundant dprintk in exp_rootfh
In-reply-to: <20240408150636.417-1-chenhx.fnst@fujitsu.com>
References: <20240408150636.417-1-chenhx.fnst@fujitsu.com>
Date: Tue, 09 Apr 2024 09:21:54 +1000
Message-id: <171261851499.17212.4957589707094499321@noble.neil.brown.name>

On Tue, 09 Apr 2024, Chen Hanxiao wrote:
> trace_nfsd_ctl_filehandle in write_filehandle has
> some similar infos.

Not all that similar.  The dprintk you are removing includes the inode
number and sb->s_id which the trace point don't include.

Why do you think that information isn't needed?

NeilBrown


>=20
> write_filehandle is the only caller of exp_rootfh,
> so just remove the dprintk parts.
>=20
> Signed-off-by: Chen Hanxiao <chenhx.fnst@fujitsu.com>
> ---
>  fs/nfsd/export.c | 3 ---
>  1 file changed, 3 deletions(-)
>=20
> diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c
> index 7b641095a665..e7acd820758d 100644
> --- a/fs/nfsd/export.c
> +++ b/fs/nfsd/export.c
> @@ -1027,9 +1027,6 @@ exp_rootfh(struct net *net, struct auth_domain *clp, =
char *name,
>  	}
>  	inode =3D d_inode(path.dentry);
> =20
> -	dprintk("nfsd: exp_rootfh(%s [%p] %s:%s/%ld)\n",
> -		 name, path.dentry, clp->name,
> -		 inode->i_sb->s_id, inode->i_ino);
>  	exp =3D exp_parent(cd, clp, &path);
>  	if (IS_ERR(exp)) {
>  		err =3D PTR_ERR(exp);
> --=20
> 2.39.1
>=20
>=20
>=20