Received-SPF: pass (google.com: domain of linux-nfs+bounces-2722-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 8 Apr 2024 20:43:49 -0400
From: Chuck Lever <chuck.lever@oracle.com>
To: NeilBrown <neilb@suse.de>
Cc: Chen Hanxiao <chenhx.fnst@fujitsu.com>, Jeff Layton <jlayton@kernel.org>,
        Olga Kornievskaia <kolga@netapp.com>, Dai Ngo <Dai.Ngo@oracle.com>,
        Tom Talpey <tom@talpey.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] NFSD: remove redundant dprintk in exp_rootfh
Message-ID: <ZhSPRTPtGCm4InJ8@tissot.1015granger.net>
References: <20240408150636.417-1-chenhx.fnst@fujitsu.com>
 <171261851499.17212.4957589707094499321@noble.neil.brown.name>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <171261851499.17212.4957589707094499321@noble.neil.brown.name>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?VnrTOYI8jJhNZRlg4qnu8W6CpBksOAmoSCgItJsxDIlgCm4SrKINXKXlo6Dn?=
 =?us-ascii?Q?JNrgy5lpA+AFi87ZCCLqtPA9LyQDB/ShmpfKmL10J2MXcgiQuHYdrrx1HUW+?=
 =?us-ascii?Q?DQjLKlSov1Flzj7DQ9aKHrTyAkKOe4gyFeiNZdBxo1dQPV4u3Q9wvltc/+8s?=
 =?us-ascii?Q?/S+8g4mfMqz4j3E6MaRqeR6Q4F0yJrafDLK+lGG7FAFpzMxOFBCIf5CzHW8W?=
 =?us-ascii?Q?kPFjRgjYYvLc7Oigovh/cYMq4XAzJEddOkx9iVH1dVO1mPceJuwQMNzDJsUw?=
 =?us-ascii?Q?qAMBXKB06JmeaDHQu16qG/vJ8FgDMcStzrj9HOApcvLwCkw3e9PtcLM1WRhj?=
 =?us-ascii?Q?oSfnrwLv2rq61K39+LGVJFVV76vvlFiXO8aZ89kuLr4/1BauHftGaOOlKRWn?=
 =?us-ascii?Q?kav+seQgMx/Z916fu2E6C+Ef1xJQM+MaiO1fEhRS0IEEpiPGspumEX6GarMi?=
 =?us-ascii?Q?0YUu0e4VvKmO1F5SkAjHyr3Zorb8quDDsaOPhviFha4zgN70sWvWnxguV3eu?=
 =?us-ascii?Q?aZsbbQsUdMGbczHy6l77FyX/JaxYw/9Et5UCtRbwgalLmsVTRVkY1LGvyNAV?=
 =?us-ascii?Q?dwZr+E8+3W2PjgaYDBOiKJImY2yC1Qe8/zbWTSz1u/5MMOSwKeAKGDHd86E0?=
 =?us-ascii?Q?mczrl6gLMFWGPTABSnD7/dfJb5n7/OzzCKFisGBvTd3pSqcW6EinccYPXFAN?=
 =?us-ascii?Q?Rgwsm4/m8hZFLchVbx35Fk0jCq5IxkyAcb0XTZu22II35RdcTpEthK05Y5iZ?=
 =?us-ascii?Q?vEF6dGW6XrjVp6MrmXkYexL4DtevNu92dEpYFozI0GR+8XiRuEQOsMT1CwnB?=
 =?us-ascii?Q?xvFc2hubBYMsO18957n+OzkOlDF9OCpz2UkFmNuVCZvT10xdbr3grpZ5EuAd?=
 =?us-ascii?Q?dk1cjMSiFo04ta18rBVrYn0UIPUWqznrBohezBS3BCLkLM6PO/rkZpCfRUm4?=
 =?us-ascii?Q?B5fo1rpBrfYHfNlHuAB9hIm/3tdDtMaztHDgp2eRFfi6g32J3iknaJujwvAw?=
 =?us-ascii?Q?EiAhZEUeGxca2FYLTFa+0xAl5F0Fj8lnGQ1CrQnYasqJ3B0NRFkebMjD6UJg?=
 =?us-ascii?Q?hS2t6POUa4PilvGfPwwkP/O8THWpEZpBWn3uKgLUKu8sHULHalXaL0EDfAxn?=
 =?us-ascii?Q?z5QNzREFodBJv4isz0KTXGUmBUWUmiHdBH9XDsYwedrE8dwYPUkGXi/+LJ/H?=
 =?us-ascii?Q?jeRrb0UgOqKfswRRtjHpf4KW/vzjiXbOZwlLRuNkUGXRc4DxtX9FR5yggcdD?=
 =?us-ascii?Q?6OM1yzIaLhaedeLgClbc7zfOrWmPWBfWjseycPEvcET1DsNpNq71PFJak5A8?=
 =?us-ascii?Q?DeooKzuYjajBnUD8flXbMDiUKe84skh53hhmRfC0G27W+xJ+RW9dVOSl2cfo?=
 =?us-ascii?Q?GLh5DqfSY3IhmhP+Pt42IKK0LhNIWgejJ0NhGV92fjnMT1exW4byEn9tnW1/?=
 =?us-ascii?Q?qJWQ8YQvSztGIK4cSQ3Lm8gaLt2uyFHtLMb2nBqFyY48wTpYDe9jhVVEblyk?=
 =?us-ascii?Q?RB7zcWT0msZaCnBuX3FyWboTM7oX24NTCXE2r9+SEwOlBm6/9nw+9pe+I8S4?=
 =?us-ascii?Q?JnOGfPHYziSDUaV2h5bTk5KINylIlle+Kjk19ViUeW9Bx0piwPQ0vN7r7gUP?=
 =?us-ascii?Q?fA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	9z7zSGTUl9JXniwpm1ZUUjZhJIsIpmlDE8ZIgIqJ5Ol3wN8Ba8B+Q+gME0VFiFmOnhTodfH9B9DBGaWittSQHj/aOcyAMBzzrzzaiptd7xv9pTOvTazAvcPnWm1BrCvLFRCM2lYUnCVNTZfhBCG7yxKfRfTTOs0a4crr7cuwlVeIxMO27jPHbsBRQFHXOQb+sDXfDkfUHkTpIr7riiOfBI/mGKMVRlWvKaKCo43w/VyE0yKW7eWt2puL7rxWhTv9ukunrt+B5RdBHYg0xpr4n09194vFTY4gdAzh+QHRhTv9M+KOvLwCG1qp8+vIc9IJFtUeN4rOvOmP5acZsoo9jC5uUnQuxyHJ5Q50oo0PSDFIkcfd0wOyknPJDurilPST04AUpH3XjfEI2lAU1F5nyyjbJPNqjA4556/yRRxt2c7JoJSyCN4OLjIIWvE/ekrCY/sWxffQ5zpoNDeiR38YyMZjcFP5Bqs9f72boxpAdGv8YI0ClgqQi3H+IAJsaoMtY5rXYYo5m9H/Pb6kJJcCtwzKauAKWBhOptoZ7N9LdNVbChDzfk8P6y4z+a7l9uhrMN8NGy5DkqI315ERqHMFx8FQsZjFfhIqOvx72ubs6Y8=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: df8addfb-a798-4d9a-4fc5-08dc582e20f1
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 00:43:52.6522
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: INpmlNGdJyUjDZbWbOcTPBWi8rRt5XdVjuCDkjwOutepUO0yPJhdJJML+sib1rRY5UVoq8IX+rog9xOWQHS0bw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR10MB7281
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-08_18,2024-04-05_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=928 suspectscore=0
 mlxscore=0 adultscore=0 phishscore=0 bulkscore=0 spamscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2404090000
X-Proofpoint-ORIG-GUID: 9q_ZV9XOiXxdvq_Xv6YVB-eAW-yorZjk
X-Proofpoint-GUID: 9q_ZV9XOiXxdvq_Xv6YVB-eAW-yorZjk

On Tue, Apr 09, 2024 at 09:21:54AM +1000, NeilBrown wrote:
> On Tue, 09 Apr 2024, Chen Hanxiao wrote:
> > trace_nfsd_ctl_filehandle in write_filehandle has
> > some similar infos.
> 
> Not all that similar.  The dprintk you are removing includes the inode
> number and sb->s_id which the trace point don't include.
> 
> Why do you think that information isn't needed?

I asked him to remove that dprintk.

Can you say why you think that information is useful to provide
via a dprintk? It doesn't seem useful to system administrators,
IMO.


> > write_filehandle is the only caller of exp_rootfh,
> > so just remove the dprintk parts.
> > 
> > Signed-off-by: Chen Hanxiao <chenhx.fnst@fujitsu.com>
> > ---
> >  fs/nfsd/export.c | 3 ---
> >  1 file changed, 3 deletions(-)
> > 
> > diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c
> > index 7b641095a665..e7acd820758d 100644
> > --- a/fs/nfsd/export.c
> > +++ b/fs/nfsd/export.c
> > @@ -1027,9 +1027,6 @@ exp_rootfh(struct net *net, struct auth_domain *clp, char *name,
> >  	}
> >  	inode = d_inode(path.dentry);
> >  
> > -	dprintk("nfsd: exp_rootfh(%s [%p] %s:%s/%ld)\n",
> > -		 name, path.dentry, clp->name,
> > -		 inode->i_sb->s_id, inode->i_ino);
> >  	exp = exp_parent(cd, clp, &path);
> >  	if (IS_ERR(exp)) {
> >  		err = PTR_ERR(exp);
> > -- 
> > 2.39.1
> > 
> > 
> > 
> 

-- 
Chuck Lever