Received-SPF: pass (google.com: domain of linux-nfs+bounces-2726-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 8 Apr 2024 22:09:27 -0400
From: Chuck Lever <chuck.lever@oracle.com>
To: NeilBrown <neilb@suse.de>
Cc: Jeff Layton <jlayton@kernel.org>,
        "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
        Olga Kornievskaia <kolga@netapp.com>, Dai Ngo <dai.ngo@oracle.com>,
        Tom Talpey <tom@talpey.com>
Subject: Re: [PATCH 0/4 v4] nfsd: fix deadlock in move_to_close_lru()
Message-ID: <ZhSjVyrdTyqyj1Hy@tissot.1015granger.net>
References: <20240408021156.6104-1-neilb@suse.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240408021156.6104-1-neilb@suse.de>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?W/BaQwM9GBclaeGJ+eEzSw0iv9Whjlne8Bi7VAjfJfqyTOudYHxKBP834j4e?=
 =?us-ascii?Q?ex8zrKE8efZBcLo9myRaJIavl6chBfRIcpVVlikLV5YBKszhUj6AA1kBK14x?=
 =?us-ascii?Q?JTze9J0p2bd7Mmfkqc5J24zLqxb21ybtgItz+9Pu+BGYSaLnEbHtlflWqa0V?=
 =?us-ascii?Q?t8kuHxpzInnTocV66l0D/vetfZpMSSuY0YtkHIOWHeoW86/S7AZSLZ8sXs+6?=
 =?us-ascii?Q?9EYefU9dFwOLd/MRf2o/RuB20jaMj5tYWjP2yyn1ST29hTdjpOEk9Yq9Y8sR?=
 =?us-ascii?Q?cVxxVnPzmkRtmgPDPMW+Q+E80HU65RRR2GuI7DvR4BmrhZNKT9CxdQsdp4qO?=
 =?us-ascii?Q?S8hpFXPaDtKN66Kx5s5oAKU/hhu19J0Z7iBCvS1Zp2PAt4E0AFy7wnWJBQUN?=
 =?us-ascii?Q?42htXq/J2ESGeLE2YYOAkK9E4iapp5F2fhz3rdnRqGn+paSYE8NfuNbgN+Oc?=
 =?us-ascii?Q?8gjfYDb1TfD+o7l1uRUlujF0e+rUudml8rp6QLrZi3CQA3/wDvgaYNJO7+AQ?=
 =?us-ascii?Q?3u9UPAJdjltLolq0UqTjiNOxXNG7jMCVdsOKA78Q0YmFD80M9LY2hX+Fo5PP?=
 =?us-ascii?Q?lxdLigEfMn/U7ARL53SMwDx9FRlCoCxfLexeGhxbqjTgTZm4m5v9MpvgZUuU?=
 =?us-ascii?Q?oKQd5l4nPmxyQJVXPjiwwQYwZwKLGHCuNwg4c2P+ACFPztme+oUwfMgfDhgu?=
 =?us-ascii?Q?1ZUuafx20JeS4thtSjbJvJj8FMcspcXvpabzQwriOSs0E9oTC/HtgCkfa3Fy?=
 =?us-ascii?Q?aCZ0hT8wjok4J4hGy2zF/UIHYnjwRIAkvmHyMIByOuOnKWMEpu5upjW8S4EM?=
 =?us-ascii?Q?+jOXK+131/MCKX6lq43ex28KTMsmvpCAASS8xGwOBO1Nac5wHXy3w9QP65BE?=
 =?us-ascii?Q?ThFb+ZEhqQoqzpN41jxbCqsMAoOCO76idHlLHrdWl0u6pi2gk9/ampn9M/jO?=
 =?us-ascii?Q?nwmks3eMNVP+cYNX6hwsAVUzCeaeKe2kG08wZ1wmMJDk7W5PuwWfGWnmeWIf?=
 =?us-ascii?Q?E7ZW7H78uhW31nbb+01DnD6HwKYuPg2XUQGvz/F5jEO8stJwhGC/DP6BFy1d?=
 =?us-ascii?Q?Pqd/+QwEB6YBKPmvP6iDE7Gvh8yNmL09xP7tJ6OM/NrVSC3TCggukz1mOA1a?=
 =?us-ascii?Q?mF+lYlJai6u80ZIKg+sNP0rTO23u+snHsL2bBOcz+JeWqHPI6DqlxIhmKZhY?=
 =?us-ascii?Q?Yf8EL5cZw6ufpD4yr27ZyIugeN9giR0+E2MeAM+i1CuSBPIWP+pYbta7757C?=
 =?us-ascii?Q?nAVX9HOTfoLSVFZoiYuFA/+G12zaVz0g5FmdRJ7t06bQ0Pwx4w8yTQ8rSyG1?=
 =?us-ascii?Q?3Nm+/FZOmkFQV+qrcRVB9k/DOZJ+BEgqYNWioGG0jZgDQPDW2FMiGh+LQ1ij?=
 =?us-ascii?Q?nOQ/FPEo5NfdD/pg4tCxgoH1ISY9+DENYzD1PjMCIbD1vd8fldN/O1g8eQVR?=
 =?us-ascii?Q?xMcL0AwkMAH1Pe3qog6tAXrRirA9aqZCLKdkL63lHOlX7ON4C2LlHYnn/DTa?=
 =?us-ascii?Q?f/iiqkstEa7Fprefq6aKGdSsjTLEUOvErQNFrGTu8SLFOk4c+uLPW2bHlqE1?=
 =?us-ascii?Q?r3sRqiSGyDh1fNr1Znn5D3YniICs6jI+cd1QyFfyaltUeye9HcbpOwgJ6ZYA?=
 =?us-ascii?Q?zw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	iNy25L4W2roXH4EEsQFxQQ/t425kV3/Bd0q5tep/0MVST1ZFMftha5ez4tPtKUkl+ygh4tg0CcvvF/AGltpKL/EbSdorMP/lanArR41Pv6Y7VF4MVc0q+k5rPxfF8GCPTZMgtfprEeu15OR2SJhxzXM+g2Sn6aD7HYmk2nKBEqRJ1qigWzw5gyNVwkqJTsGrhPiEU316c8YZf5Ud5a1KojEatW40uuvxwlmjIESSARtqlDy2hIr/LJa5qhF7GW/RBW6M1UCWmdU4U7uZEolMPxpHUficG5GPlGxuhsJRMD3ji9SGodWIdzlQaMvU9gKQl8NddEBi8VNjJVhYc64y3OH1DG19poXxdWkAgBD/naAcCnG0aPE5IjRA8DlNieaaomh5kxNm5rUxmgQxm0J3xI8rbToHOOQjtPQkNhnGZD15CZ2Rp/huR9gN8t+Pyhlbh8wyNYZiQvXlOfDznxPYWQ6GC0UjfGslmOzmBsqpOrbDfGKqhHU7ICxFW0kVaNf9bs4us6/OnnatGdz7t9y0ikWXtxV5oEz6erq8ePr+9/Dy8oq6a0sZ9e8qfU9zhOgn3ebLJpvRTtkW50Gou5e9qPbQVfXnIfFnTfk1tgeWBtY=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c9316a41-c01d-4b63-c8a7-08dc583a173c
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 02:09:30.2111
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dI1YIt34p7yv42aMtC+UBl4m5xIJvFzVna8FAcUxJHDAl6u2aktYg2ABqzUT7rBrc6kZ7WR2xJdEOkFC+S0zKw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5107
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-08_19,2024-04-05_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0
 bulkscore=0 mlxlogscore=779 mlxscore=0 adultscore=0 phishscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2404090011
X-Proofpoint-GUID: GqVcVNlCdPSdKEDZBqmUJbMNLnCM62Pz
X-Proofpoint-ORIG-GUID: GqVcVNlCdPSdKEDZBqmUJbMNLnCM62Pz

On Sun, Apr 07, 2024 at 10:09:14PM -0400, NeilBrown wrote:
> This series replaces 
>    nfsd: drop st_mutex and rp_mutex before calling move_to_close_lru()
> which was recently dropped as a problem was found.
> The first two patches rearrange code without important functional change.
> The last two address the two relaced problems of two different mutexes which are 
> held while waiting and can each trigger a deadlock.
> 
> This is against v6.9-rc2.
> 
> Thanks,
> NeilBrown
> 
>  [PATCH 1/4] nfsd: perform all find_openstateowner_str calls in the
>  [PATCH 2/4] nfsd: move nfsd4_cstate_assign_replay() earlier in open
>  [PATCH 3/4] nfsd: replace rp_mutex to avoid deadlock in
>  [PATCH 4/4] nfsd: drop st_mutex before calling move_to_close_lru()

Applied to nfsd-next. Thank you, Neil!

-- 
Chuck Lever