Received-SPF: pass (google.com: domain of linux-nfs+bounces-2737-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 9 Apr 2024 13:32:07 -0400
From: Chuck Lever <chuck.lever@oracle.com>
To: Rik Theys <Rik.Theys@esat.kuleuven.be>
Cc: Jeff Layton <jlayton@kernel.org>, Neil Brown <neilb@suse.de>,
        Olga Kornievskaia <kolga@netapp.com>, Dai Ngo <Dai.Ngo@oracle.com>,
        Tom Talpey <tom@talpey.com>, Vladimir Benes <vbenes@redhat.com>,
        linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] nfsd: hold a lighter-weight client reference over
 CB_RECALL_ANY
Message-ID: <ZhV7l5oPjoJAm8Jx@tissot.1015granger.net>
References: <20240405-rhel-31513-v2-1-b0f6c10be929@kernel.org>
 <ZhA93BQSxkJqmqaw@tissot.1015granger.net>
 <d661b740-a431-4099-ae41-39a69bbc67b7@esat.kuleuven.be>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d661b740-a431-4099-ae41-39a69bbc67b7@esat.kuleuven.be>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?cFOqEEN3UmuCXQSd1TuCNPBNX36awNVw8dUvpKuPipqukpZxM0XjaHjaoC36?=
 =?us-ascii?Q?L8dKNqlPkOg+fR+7U3FCCbSMAOtKk11Ub6gVzhI7XwT5IyMG1CWAPQiLzu4H?=
 =?us-ascii?Q?tS4aD46BzG/xwUhZJW2Bj1CZjKB7mJGbR1tICiPsoHTKKvkcYVpOd7AQ5FqN?=
 =?us-ascii?Q?qLGIV3oe3N6M5avnPlLftjPjM9iMYbhASeihgtj3j/J2FcLTDEL0joGw0VHT?=
 =?us-ascii?Q?lOLPFyWcTNNX8RABFLyura1LkE9MNij1ppwrLLA+gXg5As/L4lTWZSMJiBst?=
 =?us-ascii?Q?sLM6kskANNaAlBIsRkKNe43XMDEGvUtirsqmSDjF+nbP/rCvMvkdRb+wTnvr?=
 =?us-ascii?Q?xgINRngZkr6lwV5NiZ/oK4H+BWzVBix+Q5u3hhppRex8uOMgufcBam76G/Ki?=
 =?us-ascii?Q?57JAXdav68YpcfivNMgnO675oYiiPRJ2ZmYUgljLjxUBR+MJy/2NgscXL5HQ?=
 =?us-ascii?Q?a6h7kteZLeqj7g+ZKBjOunwpKJgDCYNfbbd93q8tlXjccUISzHMq7Kj7EVDy?=
 =?us-ascii?Q?n10Ir/pJ3wVvN8d7RbjSok4tvEjdBItdbSLguy8jJgeAKwYPrb2BF3tggpp0?=
 =?us-ascii?Q?qDeK+og+TlTXIGY8J6trStsrI0ABD0ShGOB3vo/TcytycHcXAFQR+0UE1e3/?=
 =?us-ascii?Q?HCbkGd+NP+2rYiS/h55t+NykfomYUVBzMkVimyMYPo2TrPWaulAaiBQXwxoD?=
 =?us-ascii?Q?7zuvHk5oq+RfpE6d6lPMW6jbJDY3hvO0rm9ilr3mBsE/yfuvePUQoFq/E7SC?=
 =?us-ascii?Q?e7kAqEw1Zy4vxfZu/ycjSwqhLSFXZ9TQbKA8ciaQjKt/ISwiVufjKl2Tu6B7?=
 =?us-ascii?Q?BqX9m/Eil6eTUxatpl/sr3+H20MxnO5l7eTchzEexY9vOx/ti7pNhu+RApZ8?=
 =?us-ascii?Q?UvYhr8I0d4VT3YXQr3mek+vnGm5k8IRqvb/+SF9ap2CErHtzasEgV0vAx7Hl?=
 =?us-ascii?Q?P2lmCwvFnOhpCfzu6QEW5L/WcCD4krJCy6zektp3YkAc6zkjAY5EzXlLviFS?=
 =?us-ascii?Q?kwm5tGQFdO+dvo4xDEW6c/lkTtcrkLBZYkoxK8dNmqPCowH9rF56lNfQ9FY2?=
 =?us-ascii?Q?pmVsohB0ameAM2sbnRQHmHqyXwL2Z0fDsXS9ssj7F1Tlfwf8HMD5WaLikk4C?=
 =?us-ascii?Q?3UYxWPBjD79hjakryBaIy/qcqkVsJjHC745ySuIcDRDLGGfVe7UXEIoGpxE8?=
 =?us-ascii?Q?zfemPA+TwIQwUICIQZFWFrWBpv8NyCHF74kKX4mxqpAKQ96KcSHNK+EiZ0+n?=
 =?us-ascii?Q?aDlm+A3geN4itH7HnfBEyOMbu3MJuVjnw4cmHFL0S+RoAvtNI10WDLaLUwTR?=
 =?us-ascii?Q?ImwGKwBAxT1esQtcAxTWJMVHaw3IRBrhK+IJFOMXJDciTw3Ek/1Cupc03SpY?=
 =?us-ascii?Q?XUCBoH9tvHwEbdXVT/CxlH91Da1pLmoWq3s+8q0n/BOAoIULcsaGK7TE/ZwV?=
 =?us-ascii?Q?qc8TVFauJ9zAeOTMRyk7uy0YzIJEUz6O+jQZacqRnaeVToqgv2UiHLN5QmZ7?=
 =?us-ascii?Q?j2M9zOVgJbVN+clmz3RQJ3W6OClAkq10ivjI0/NRdxQIXtsZMSUp6xVNQLmM?=
 =?us-ascii?Q?P7Wc75F7hjODvxdOFy3ORZg+TLtkSWP+WrJEbTphogDEnzF96DGF+oBFvOa2?=
 =?us-ascii?Q?hQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	59uHpIUDa8qHVWx1g0qTcfHd0zD2/IkbxQ6HZXNgu1XKhJNJrbfanLP4FVGLxwapcjObse8wiEm4KNlD/ye8D/WyT7Sn3d+2rJAjh0Msbpw7PXpzh+aPv6bIj+DbqbhsknxKrZgl5ld1qoAFqfJomrt30GSEYGOyR6PaX4BaPmtkazdg9YZqKeV05c3rH92KJYBudW4nVXSm8m/rz71J9gFrWMVjZtNQ2m4HZIie591AxK/FU3TstKoxb//NzcPoZcwUmcjFNicmw487QmTWls1Zy2NfeMWZOgcQ7WG4w7mPKhowSdlYtjd3ZhwagSsy1rzdPo2QhaYMgmQRR7oZqqKN2vAFN3OyYg6WviP1rKZwE33Gh9U1jG4FjjNb5HFGzsmaBNGuNNdv0nyEvWX1gHClTRE3z0qKtB4Z4/2lgRjMKagglIi6H1rJNrTjoG2DCi56uMWiJOistyYF5sm71bWI6PBXz7n/lYht6rWYOKPg3UAOOUP7KXcJiOjGAGaX4cAn0Ep2FcYbYYJ8LP+vVAmvkHKSeevJAW+RZpDV6dJAT16b45vALdS/4yPFnxy1NLqzBoV7PKd55VI54KF5RNVujmQAsnF+FII4fksKeZs=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ace2a91-20cf-4285-e948-08dc58bafcbb
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2024 17:32:10.8038
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AUCSDOheDlHozo2j0BtscrdxtuADHH3ypT52RT49WcyDMG5LJv6HnVcS8q4HJzPyveCGnuIr3UjHNHMX14voog==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6151
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-09_12,2024-04-09_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0
 mlxscore=0 adultscore=0 phishscore=0 bulkscore=0 spamscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2404090114
X-Proofpoint-GUID: T1Q1Ofla-o2hUbxy3lVLSd6UFn5PLWjf
X-Proofpoint-ORIG-GUID: T1Q1Ofla-o2hUbxy3lVLSd6UFn5PLWjf

On Tue, Apr 09, 2024 at 07:24:17PM +0200, Rik Theys wrote:
> Hi,
> 
> On 4/5/24 20:07, Chuck Lever wrote:
> > On Fri, Apr 05, 2024 at 01:56:18PM -0400, Jeff Layton wrote:
> > > Currently the CB_RECALL_ANY job takes a cl_rpc_users reference to the
> > > client. While a callback job is technically an RPC that counter is
> > > really more for client-driven RPCs, and this has the effect of
> > > preventing the client from being unhashed until the callback completes.
> > > 
> > > If nfsd decides to send a CB_RECALL_ANY just as the client reboots, we
> > > can end up in a situation where the callback can't complete on the (now
> > > dead) callback channel, but the new client can't connect because the old
> > > client can't be unhashed. This usually manifests as a NFS4ERR_DELAY
> > > return on the CREATE_SESSION operation.
> > > 
> > > The job is only holding a reference to the client so it can clear a flag
> > > in the after the RPC completes. Fix this by having CB_RECALL_ANY instead
> > > hold a reference to the cl_nfsdfs.cl_ref. Typically we only take that
> > > sort of reference when dealing with the nfsdfs info files, but it should
> > > work appropriately here to ensure that the nfs4_client doesn't
> > > disappear.
> > > 
> > > Fixes: 44df6f439a17 ("NFSD: add delegation reaper to react to low memory condition")
> > > Reported-by: Vladimir Benes<vbenes@redhat.com>
> > > Signed-off-by: Jeff Layton<jlayton@kernel.org>
> > Applied to nfsd-fixes while waiting for review and testing. Thanks!
> > 
> Can this fix also be included in the 6.1.x LTS kernel? Given that "NFSD: add
> delegation reaper to react to low memory condition" was added to 6.1.81, it
> would be nice to have this fix in the 6.1 series.
> 
> This way it will also be picked up by Debian at some point (it seems they
> are upgrading to 6.1.82 for their next stable point release).

Thanks to the Fixes: tag in the commit's description, it will
probably appear in a later release of linux-6.1.y automatically.

If we don't see it the next few weeks, I will ping the stable
maintainers.


-- 
Chuck Lever