Received-SPF: pass (google.com: domain of linux-nfs+bounces-2799-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 12 Apr 2024 16:50:00 +0200
From: Joel Granados <j.granados@samsung.com>
To: Kuniyuki Iwashima <kuniyu@amazon.com>
CC: <Dai.Ngo@oracle.com>, <alex.aring@gmail.com>,
	<alibuda@linux.alibaba.com>, <allison.henderson@oracle.com>,
	<anna@kernel.org>, <bridge@lists.linux.dev>, <chuck.lever@oracle.com>,
	<coreteam@netfilter.org>, <courmisch@gmail.com>, <davem@davemloft.net>,
	<dccp@vger.kernel.org>, <devnull+j.granados.samsung.com@kernel.org>,
	<dhowells@redhat.com>, <dsahern@kernel.org>, <edumazet@google.com>,
	<fw@strlen.de>, <geliang@kernel.org>, <guwen@linux.alibaba.com>,
	<herbert@gondor.apana.org.au>, <horms@verge.net.au>, <ja@ssi.bg>,
	<jaka@linux.ibm.com>, <jlayton@kernel.org>, <jmaloy@redhat.com>,
	<jreuter@yaina.de>, <kadlec@netfilter.org>, <keescook@chromium.org>,
	<kolga@netapp.com>, <kuba@kernel.org>, <linux-afs@lists.infradead.org>,
	<linux-hams@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-nfs@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
	<linux-s390@vger.kernel.org>, <linux-sctp@vger.kernel.org>,
	<linux-wpan@vger.kernel.org>, <linux-x25@vger.kernel.org>,
	<lucien.xin@gmail.com>, <lvs-devel@vger.kernel.org>,
	<marc.dionne@auristor.com>, <marcelo.leitner@gmail.com>,
	<martineau@kernel.org>, <matttbe@kernel.org>, <mcgrof@kernel.org>,
	<miquel.raynal@bootlin.com>, <mptcp@lists.linux.dev>, <ms@dev.tdt.de>,
	<neilb@suse.de>, <netdev@vger.kernel.org>,
	<netfilter-devel@vger.kernel.org>, <pabeni@redhat.com>,
	<pablo@netfilter.org>, <ralf@linux-mips.org>, <razor@blackwall.org>,
	<rds-devel@oss.oracle.com>, <roopa@nvidia.com>, <stefan@datenfreihafen.org>,
	<steffen.klassert@secunet.com>, <tipc-discussion@lists.sourceforge.net>,
	<tom@talpey.com>, <tonylu@linux.alibaba.com>,
	<trond.myklebust@hammerspace.com>, <wenjia@linux.ibm.com>,
	<ying.xue@windriver.com>
Subject: Re: [PATCH v2 4/4] ax.25: Remove the now superfluous sentinel
 elements from ctl_table array
Message-ID: <20240412145000.4nrf5sufnwjltdl4@joelS2.panther.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="7o7lzmim7rza4zom"
Content-Disposition: inline
In-Reply-To: <20240405222658.3615-1-kuniyu@amazon.com>
CMS-TYPE: 201P
References: <20240405071531.fv6smp55znlfnul2@joelS2.panther.com>
	<CGME20240405222730eucas1p16a0790be308342130a19a5b489ffae1e@eucas1p1.samsung.com>
	<20240405222658.3615-1-kuniyu@amazon.com>

--7o7lzmim7rza4zom
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 05, 2024 at 03:26:58PM -0700, Kuniyuki Iwashima wrote:
> From: Joel Granados <j.granados@samsung.com>
> Date: Fri, 5 Apr 2024 09:15:31 +0200
> > On Thu, Mar 28, 2024 at 12:49:34PM -0700, Kuniyuki Iwashima wrote:
> > > From: Joel Granados via B4 Relay <devnull+j.granados.samsung.com@kern=
el.org>
> > > Date: Thu, 28 Mar 2024 16:40:05 +0100
> > > > This commit comes at the tail end of a greater effort to remove the
> > > > empty elements at the end of the ctl_table arrays (sentinels) which=
 will
> > > > reduce the overall build time size of the kernel and run time memory
> > > > bloat by ~64 bytes per sentinel (further information Link :
> > > > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.o=
rg/)
> > > >=20
> > > > When we remove the sentinel from ax25_param_table a buffer overflow
> > > > shows its ugly head. The sentinel's data element used to be changed=
 when
> > > > CONFIG_AX25_DAMA_SLAVE was not defined.
> > >=20
> > > I think it's better to define the relation explicitly between the
> > > enum and sysctl table by BUILD_BUG_ON() in ax25_register_dev_sysctl()
> > >=20
> > >   BUILD_BUG_ON(AX25_MAX_VALUES !=3D ARRAY_SIZE(ax25_param_table));
> > >=20
> > > and guard AX25_VALUES_DS_TIMEOUT with #ifdef CONFIG_AX25_DAMA_SLAVE
> > > as done for other enum.
> >=20
> > When I remove AX25_VALUES_DS_TIMEOUT from the un-guarded build it
> > complains in net/ax25/ax25_ds_timer.c (ax25_ds_set_timer). Here is the
> > report https://lore.kernel.org/oe-kbuild-all/202404040301.qzKmVQGB-lkp@=
intel.com/.
> >=20
> > How best to address this? Should we just guard the whole function and do
> > nothing when not set? like this:
>=20
> It seems fine to me.
>=20
> ax25_ds_timeout() checks !ax25_dev->dama.slave_timeout, but it's
> initialised by kzalloc() during dev setup, so it will be a noop.

Just sent v3 with this change.


--=20

Joel Granados

--7o7lzmim7rza4zom
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmYZShgACgkQupfNUreW
QU+ckAv/ZCwg3conSwfw9FdBTIyF2Tr/m3ucbFQrfwVIpiZTkJxAeSTbI2tY6LyI
C7kdP6J8fHU7V7HjjCfYKXahRksz5KiH4DQn0RuHOxJD22HRLHz0r6wS2Kh3E4i5
MQGuMNR45oLJRShpLRXA8jGmtPTk8Y6xyUewumuNSArW9h69nfphXIhrbf2oEdXL
xrZhKTUATlK1jQKrfU07h3iXfaaqClzMdyIPJ9T0nkD0L1njo2JtkIqA9YXTQOtb
D9pYMA07IVXpjJfp8/Q49xxEam5P+LgGLN/0+wv9Wu9FZZcpHHF5fFtnAU40//YX
/mfuYehx5eo3iStDmWqpwacOTVxOY2dKTEXmXlsNbaRNi+RmlExJ313YCjS/J1M/
FW5v4W8JGMygK6IFZj1+sWUrryBc5V5KGErp9oldNUHsl6TY47ImmMN8gBU7okO/
vKw2oVt3Zi5Pm9W373Qbrz05AnT/koa/h2w0tbvaHoWjkgqSqpuPXdLHCFxpqViz
0PNrCcrH
=YAL9
-----END PGP SIGNATURE-----

--7o7lzmim7rza4zom--