Received: by 2002:ab2:69cc:0:b0:1f4:be93:e15a with SMTP id n12csp1601897lqp; Mon, 15 Apr 2024 11:03:32 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWDbFhtY1JKbmT4VaYqaIlVlsRVZ1V+nEXMDiwi2lhB3o024BHm/6exOks0549rbavjKMKoMx/yazfNFcJEz59tgr6z4iKp7RUxOdqb4A== X-Google-Smtp-Source: AGHT+IHA8D2ajjGdoFNeFyAaldREVFitMr0GBcy15rkES9H96HhK269AXa2EJ38orai1Mmt9sKXo X-Received: by 2002:a05:6a00:b4a:b0:6ed:de86:be57 with SMTP id p10-20020a056a000b4a00b006edde86be57mr14971695pfo.25.1713204212635; Mon, 15 Apr 2024 11:03:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1713204212; cv=pass; d=google.com; s=arc-20160816; b=X/LYMeyaKzLGR+8qZmrqMVZZzZm+05hPcHHyuxiEiaacV/rVuAEJKQAyOs4vdKSIIs bUbS9MNrVq/PcgKjcfeKb3kq2zftT43s23w8fwvF9sRZKKtpSNf/f8AXKOw7bE4ooJTZ 8OVjNQBH3TnImyGsaJBqApRPW8c63OEzI3ySl56cD3/Zl6cECIdOy25YNguL+4kQTVOV VnG3CjcaV97IW1Xwp/zJu+hyBvSgrmgdeqRbe5JlLvn4sb4GJVudzxFC/dnGQSrnhq5r l10ISDRAAiGps3+TkexWXsqhWYWshmIn4T3Bu+fkAuV1E0R2DoehJA9dkgfPdmiVwCU2 77rw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=SjH9mWDCEXhtnK+53ub6O6KeaytHyiD1Lpk65XPHMXg=; fh=VxY+Wmqg85qc13Ygd+I5uloGCvRHoxlqj05aFtiB4ak=; b=EjDPqbxRvHS2SShBZsSxm8R5RGwsbUjrktS7sR7+04eaGvzYwyMxcZ3DG5KFhwGbj/ pPQZlRAlUBXeQFDl+06AIbO7suXGf+CF8DjVLN8V8MY/U51B2i3/oMw4uk0k9v48kfJJ Hv7CoXdrb9SDDOiqyT6PdpC8CeF7Hooji1ZkK+QR2y3UwFQ4sMfSNYt9pgsleLbpqr9j 1VqNAYABUNLPtTKGL8kbv3U89fs0eNlaz1E2q0LVhYfbXCKjjkvGbro/glbf/nEbEBrQ YxugcUdbxd0r/H2qtlZGynpJQexePIiMUHtzduvzt8nycfJX7GVs+J7vBvIog0XIctJa pv5Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="J/HnPyWk"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-nfs+bounces-2819-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-nfs+bounces-2819-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id lb9-20020a056a004f0900b006e74608ea4esi8296326pfb.344.2024.04.15.11.03.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Apr 2024 11:03:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs+bounces-2819-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="J/HnPyWk"; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-nfs+bounces-2819-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-nfs+bounces-2819-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4F20F2822B6 for ; Mon, 15 Apr 2024 18:03:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1255213A895; Mon, 15 Apr 2024 18:03:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="J/HnPyWk" X-Original-To: linux-nfs@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D31321E877; Mon, 15 Apr 2024 18:03:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713204202; cv=none; b=T+lVWR9cK8vb1xNBej/rGROdLFkWXqax2BlINTs4+FqU3KEk64EKuSamGaGuvRn83aISSa1O7bRbYppttsHlwAxIE9dQDlEBWX2DBXR6e35W8T2+2i2PW+naQrtI/kyUgwc58JE9Hd9cOsaXlrEaVlm8c8OLEnzwzNvPcBpsQ1s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713204202; c=relaxed/simple; bh=3GqZpk7DoO2fxKbi2ufcnw0GZVZyswnxL6e6C+xYNak=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PaCOObMLGqpyyEjFx6qWsxk8k32z2BnNZOzcnb8Q6w+F+yxGOyoHQiZKiQoqd/O70wlxRmNEJ5g5JngVZ7eodDJl98FKjqEHUMcnoUuNJR1DKKv8Jl/HlXekI/LtINYpHLObNfjdDzTIiP/zmIIOgMORJ7pxbQXE6b/OpvExIZk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=J/HnPyWk; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D2AEC113CC; Mon, 15 Apr 2024 18:03:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713204201; bh=3GqZpk7DoO2fxKbi2ufcnw0GZVZyswnxL6e6C+xYNak=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=J/HnPyWkefDzuZn5kJANBCiahieYSINa5oAs81pVYGglRtgqHUvOsL0OskwcFqq3U MF5i8Lbq61xwnxWhd7zlBQm/MhvNeSny+70bUddW5jijxey+R9SS1VqFKDifYvpmXZ LC54gaapvlVt63LIimJ3IgR7XJPRLX3KceXCCQ74MOBgsudfxjvfQt9QpwZYfNBECB zTTo1D5DUJ1qmEBXwkCs0ogxSulROG8FVrqOtPYwvFjhHBND+bA0i75qPy5HLfkdn5 i5bu9u45DQWRCkiGbyRho7LNSKmrU0A0mDIIRnmYrRnF+vC1w8ykO72u1kTIcqmgNm 1eCMrJsH9Du5A== Date: Mon, 15 Apr 2024 11:03:20 -0700 From: Jakub Kicinski To: Lorenzo Bianconi Cc: linux-nfs@vger.kernel.org, lorenzo.bianconi@redhat.com, chuck.lever@oracle.com, jlayton@kernel.org, neilb@suse.de, netdev@vger.kernel.org Subject: Re: [PATCH v7 2/5] NFSD: add write_version to netlink command Message-ID: <20240415110320.0291ac00@kernel.org> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 11 Apr 2024 18:47:25 +0200 Lorenzo Bianconi wrote: > + attr = nla_nest_start_noflag(skb, > + NFSD_A_SERVER_PROTO_VERSION); The _noflag() version is for legacy code, I think you should let the nest be marked appropriately.