Received-SPF: pass (google.com: domain of linux-nfs+bounces-2828-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 15 Apr 2024 17:07:17 -0400
From: Chuck Lever <chuck.lever@oracle.com>
To: Jeff Layton <jlayton@kernel.org>
Cc: Petr Vorel <pvorel@suse.cz>, "ltp@lists.linux.it" <ltp@lists.linux.it>,
        Neil Brown <neilb@suse.de>, Cyril Hrubis <chrubis@suse.cz>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 1/1] proc01: Whitelist /proc/fs/nfsd/nfsv4recoverydir
Message-ID: <Zh2XBV/sW67dx+wp@tissot.1015granger.net>
References: <20240415172133.553441-1-pvorel@suse.cz>
 <7A48C70E-BAAB-4A1C-A41B-ABC30287D8B7@oracle.com>
 <d895ad115632912df228913d4a86e7f597b22599.camel@kernel.org>
 <6820832A-9F38-4DE7-8EE4-7AAC8CF06FD4@oracle.com>
 <5052616ca4c2789ffcc51a27cbff060e2fbdb7b4.camel@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5052616ca4c2789ffcc51a27cbff060e2fbdb7b4.camel@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?bVc1TS9iK3JmT2Z5ajFrcVE5Mmo3RzBXR1A4WnRuQ2p2N0VNSmM0dFZEQ2Vi?=
 =?utf-8?B?Mzl3cGpqb0hSejloc1RFTklSak1XZXJzTGZ4bUk1d0RvL3dWcUpYZjEra1do?=
 =?utf-8?B?cEdDQVViRFB5NWJESHFXbGM5ZmozbUU0QWZUUUdFNjZaVmY1UUxyQnFMLzRR?=
 =?utf-8?B?MmlYQlJFa3hvNGZSZGNLMENOV0dpR0xpQ0s0a2FZbE52QnNIL3M3OERobWo0?=
 =?utf-8?B?Q3VSVGVxcE95aW1qYTlUVlk2M3lWQ08yOFA1NXM3bndzbisxMXBDSDFOMHJW?=
 =?utf-8?B?VTVhbXljNHAwRENGM0tJZEFTcU12d1pHcDRrNGI1QzI0TlpUaXZYWVkzSjlW?=
 =?utf-8?B?dC9vNUNNOGFtVUN3V1BVTHNIeXJ2OFAyakJETGZETmhvMjNER0duaTZoQVVy?=
 =?utf-8?B?cnpBRk1XN3NrTy9QMEhaeWk1cGFrbTRjc2E2RnZSYmlnVGVsUnVzN3lkTXNy?=
 =?utf-8?B?dDJNclhGaFJ4S0dIY0lIV3BjTS9LdU5zQ1JqZVo0UEw0K21WdUo2VDFXdlhX?=
 =?utf-8?B?aXAzSmlKQStUUE5aRkVKNncybXp5MG9tZ3V4K0l5WEdvZjBaWWVyVHl4dHBh?=
 =?utf-8?B?aW44T2JQaElvVHlEcS93ODBlSHhPK0JkdVNQRVdzaU8xb3pobVhRNDQwNmkv?=
 =?utf-8?B?Qy96MDZ4a3FwYXk2aVh3ZktVN1BvV1diVHBHMkptMTJRWm11YTcvNnRhQk92?=
 =?utf-8?B?YkxXU0Vta0UwaEt1UERlT245VWF1c0Fvbjk5SzhZaWVNcDFsZk4xTUo5ckF2?=
 =?utf-8?B?NXBmR0MzdjFrTFkxSjFXUDVMZm85ZkFRdW9oV2FhK2RMdHloRmFUckRiYW9h?=
 =?utf-8?B?amx2STF5YjZFSGxIY2IrTTlaSG1NNXJkLzdvNDVwS1R5ei9BN2FsbDRxands?=
 =?utf-8?B?d000WDROb3JIck9FTk1wZ1ZCR21NRzRBdGpYT1FReDFQZ3BJRW9JY2dFRFZi?=
 =?utf-8?B?VTFIT2g5RjFqRC8zbnpTY2I2QUo5ODArcjduYnFNOW1FcldzZTg5M2hYVG9y?=
 =?utf-8?B?SFdkSEFoRzYxMndJcUhpRkF3aWZtc3daQm8wTFlFdzgxL0VXaVkyWWpmS2pX?=
 =?utf-8?B?Y3I3RkEvVHpqZ3NYUFJJTmwrM0E2bDBGQnoySGpucU83VFpObE1TZ25FQXVp?=
 =?utf-8?B?dm5Fb3VvYXVtL1poWUJsWlF2V3R1S09EcW9Mb0VHVnUwM1hYRk8vcWdJaHhR?=
 =?utf-8?B?QWdrYTJKRjh2UFRjMFdtM1RzRlZ3YjBEYjBPci9TWWtQM1g1aWlwb0FPVmQr?=
 =?utf-8?B?MmdqWGZjeVllZm81aEJyelpLM3h0WCtjc2RMLzArYmRFL090ZkNnUTdBNnRu?=
 =?utf-8?B?NW1HRlhtNWNBbkxmYzF4UEIzM3R3TlBjcEhlTGIzMTlORnRydGMrUS9xWnFr?=
 =?utf-8?B?eitZekpjQkJCTnA0aDJ3SDVJMjBwWmtKejNGNldPZXhQZXNkQ3lwd2UwazJr?=
 =?utf-8?B?NFI1SGlOT3NkanNLZlBmQTlXZnA5ZFBmTWVYdFFVR0xFdzJHL2U5TlRDSVpj?=
 =?utf-8?B?RFB3VUdjN1NENHRWR3BISmhaaENIRkJ2VGp2emxLWWhvMVNDS01yaUNlSkpl?=
 =?utf-8?B?c0tudmFrNW9nZC9NQjcrR09Rc1JrbCttczZkUmtFYjJ0K0JzQ1lGMVZweXpK?=
 =?utf-8?B?ZEVWS1VpckpUU3VJc3lheXV1UDJXSW95VkZLTWZ2ZWdPTGVoWkJrTXlpcDZh?=
 =?utf-8?B?SjBJamcvY0VDMUtjRVpUSk9rSHRhQVVKUytJOXdQVzROaFhhc1lpUVBFQmZX?=
 =?utf-8?B?ZkxHMjJFREFyeFJTcXZKbXNNUnFNeFhmejN2TVY3MVlVU3pWYkhrcHluVTc3?=
 =?utf-8?B?TnBRa2ZlVm5Qbk1QWm4vWFRKMzhUbWQyMklaMDlYRmZQNkJRaEpYZ3VsaVMx?=
 =?utf-8?B?WFc2OC9SdFNTNkUwSWtlT25IWXVXQ3I5SkVmN3JCNm5wSHc3eUE3RmtGUlpY?=
 =?utf-8?B?RGVIM3VMUG8xUVBHbzIyT3U0aUx4djZHbXk5RzFCamhIWDJJTmx2K0tYTW9W?=
 =?utf-8?B?RXNYL0RNRGZ5SWU5WDkyQndRS3JtTGNXTTRzMGRZZi9GNyt6QjlrYUphbXRB?=
 =?utf-8?B?T3lFcElFM2ZYUjdESFdQQTgxZC9IZ1locHkyZ0Y3dXVpTFpNU3dhMHZDUlpF?=
 =?utf-8?B?VWxUZUpQN1prWjJzdzg0cnFYUkhiWVVya1pBMUZUU2xnZlB5b3NJTmQvQ3VZ?=
 =?utf-8?B?c2c9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	XFTPo068ME79LlAOWUg6xft57k9y4xScY6O4Toj4OKkP1TAA0kJwkW+IcXj7+ISJ5A8/8oinUGiYctbBpYqrhGo3gknYn/gS4ZCYA9OcwWVpQLXKFTBhRciyDbnIMDw6faioLQz4HdUhQjvwDunVQxel/NybsUMw3pxY3uBrk2CYiv9lrQGp8ubhto5OiaA2ikdLAfyPiZQTBzWMHYnf+oOt0FlmdZGY7V4sUYA8PlEbpPuxZktKAbXiD0zIPIzHfvfQFzRPlY2V2IFoek5OzXCkKH017fOaOfxHf0iD8rleWNnrjIy867rHFiNS3kFnN0s+3e6GklQpyPjjedbWCkadENV9qzJNO9BMM7iKBaEsNC6JQoFl2rsm4x0/VBUDJOex1HH38MNmiQHdrSSe3ypad/NzdlLVqdyySBrt1Q+0P0WJCUyxyxrdomk0UCvzVqvDnn6wDzJ5V+orQ8qPxWBCKdxIF5cNJ4leGJ5pY5rpJ+gGDvfKH4LELoNlH0wRXd/j8hy6OHGV8sLp6y58HsdFCZt/HeLnN1odicsIjhRrBTbrFpu8RH2VdBbp5+hb7v3w7uq6QDIDQZeDq5t5jsste2EQJyS1XjzomPLWEnA=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b5954170-07b0-4428-85b3-08dc5d90099d
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 21:07:19.9063
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4ZAsKGQQ8xw/+3/Xgf3tcq+Ce/yacQ6qvLCzT/EjQd9P005eRe1pd0kn/OayA6odr+pgeTXq2BNHWmf748jBTg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR10MB7976
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-15_18,2024-04-15_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 mlxlogscore=654
 suspectscore=0 adultscore=0 phishscore=0 bulkscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000
 definitions=main-2404150140
X-Proofpoint-ORIG-GUID: eyMWa24Ig0zbLzlkgIwpzHOP7h0WA2vj
X-Proofpoint-GUID: eyMWa24Ig0zbLzlkgIwpzHOP7h0WA2vj

On Mon, Apr 15, 2024 at 01:43:37PM -0400, Jeff Layton wrote:
> On Mon, 2024-04-15 at 17:37 +0000, Chuck Lever III wrote:
> > 
> > > On Apr 15, 2024, at 1:35 PM, Jeff Layton <jlayton@kernel.org> wrote:
> > > 
> > > On Mon, 2024-04-15 at 17:27 +0000, Chuck Lever III wrote:
> > > > 
> > > > > On Apr 15, 2024, at 1:21 PM, Petr Vorel <pvorel@suse.cz> wrote:
> > > > > 
> > > > > /proc/fs/nfsd/nfsv4recoverydir started from kernel 6.8 report EINVAL.
> > > > > 
> > > > > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > > > > ---
> > > > > Hi,
> > > > > 
> > > > > @ Jeff, Chuck, Neil, NFS devs: The patch itself whitelist reading
> > > > > /proc/fs/nfsd/nfsv4recoverydir in LTP test. I suspect reading failed
> > > > > with EINVAL in 6.8 was a deliberate change and expected behavior when
> > > > > CONFIG_NFSD_LEGACY_CLIENT_TRACKING is not set:
> > > > 
> > > > I'm not sure it was deliberate. This seems like a behavior
> > > > regression. Jeff?
> > > > 
> > > 
> > > I don't think I intended to make it return -EINVAL. I guess that's what
> > > happens when there is no entry for it in the write_op array.
> > > 
> > > With CONFIG_NFSD_LEGACY_CLIENT_TRACKING disabled, that file has no
> > > meaning or value at all anymore. Maybe we should just remove the dentry
> > > altogether when CONFIG_NFSD_LEGACY_CLIENT_TRACKING is disabled?
> > 
> > My understanding of the rules about modifying this part of
> > the kernel-user interface is that the file has to stay, even
> > though it's now a no-op.
> > 
> 
> Does it?  Where are these rules written? 
> 
> What should we have it do now when read and written? Maybe EOPNOTSUPP
> would be better, if we can make it just return an error?
> 
> We could also make it just discard written data, and present a blank
> string when read. What do the rules say we are required to do here?

The best I could find was Documentation/process/stable-api-nonsense.rst.

Tell you what, you and Petr work out what you'd like to do, let's
figure out the right set of folks to review changes in /proc, and
we'll go from there. If no-one has a problem removing the file, I'm
not going to stand in the way.


-- 
Chuck Lever