Received-SPF: pass (google.com: domain of linux-nfs+bounces-2848-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 16 Apr 2024 15:05:39 -0400
From: Chuck Lever <chuck.lever@oracle.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: linux-nfs@vger.kernel.org, lorenzo.bianconi@redhat.com, neilb@suse.de,
        netdev@vger.kernel.org, kuba@kernel.org, jlayton@kernel.org
Subject: Re: [PATCH v8 0/6] convert write_threads, write_version and
 write_ports to netlink commands
Message-ID: <Zh7MA8TFNt4QrKdy@tissot.1015granger.net>
References: <cover.1713209938.git.lorenzo@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1713209938.git.lorenzo@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?J/0ar/QzH1mQqSW6umr9MhHvqgHIuDnnZMp0yDBD3P7SdG71LRjxbbh+DFEA?=
 =?us-ascii?Q?Y3+39Axv0W1zkLtmGhhU+YBvqRIJ8pFJGyPE2tXQhChCtamjkkwPbhNATA9E?=
 =?us-ascii?Q?l28FN7KJGCO8+BL4/qqeCvHE6sW49wu1PxSmFBtNqlxdi75c/mGZCrihjK2Y?=
 =?us-ascii?Q?AlBKq60ZwFAdfI3jTmzRNr8ywO0tDR7urpxinKTk+CuzX21DTPa1pqX/Txa4?=
 =?us-ascii?Q?JIHidEatpGHuLP2bldM918uK4eO5h+GAp/3Ihc8DkRDLIs0pIrgjmAwsz2am?=
 =?us-ascii?Q?JCU0LV4VtSYKJuDH8AZePGfyjcP6yuUGyrOo7UMajNGbh5P6haGPp31GvFzy?=
 =?us-ascii?Q?q0Ou+Ce29xfEM/7cI4MS2mN0N7c4m0ZxiCbwKoVZxLQ0Ktx3422VlC6GgtV7?=
 =?us-ascii?Q?9Xy2P22yt8qhSaYxDPDwiFG9scgJXQiHDHFIzgAu0/UC9Us2dQErmEBjk6dg?=
 =?us-ascii?Q?8Rs3BlTd1/g+E1arabt9Y0qEHgIyr8j9H3BiBJfNyuTa8kqIMA32zzG4DTka?=
 =?us-ascii?Q?iKLdRz4Aexptkq1/DhFo5IivIkOVELqFvXrD3IZrDoteIm1f+MfUfyKrDmCW?=
 =?us-ascii?Q?4h5hJcURPyAhTJePRxGvub5Ax1NAmqbvYNaBIMelHTdVKiza1J3c1TX0fNSt?=
 =?us-ascii?Q?0C9A+irqW4BeU9+UL9Dnx8fvKdkptpXK+CGrvVC1k97EQtdZqIfAEYn3Twpd?=
 =?us-ascii?Q?AZt4m952wt79gBCbyxAOQYSjfmErjdQeO9Ju8bEMfu6bOSoAWA1O9k/z28Vm?=
 =?us-ascii?Q?Seyqcvn1duj7czuNH9ZYKxqAK2+ToC9zxWKOGZqVDJJqybMxHY0ooLmUIQsx?=
 =?us-ascii?Q?MY3T0Kcbru0H3HRSdgAKIj3lMXxJxnwNbEBn6RnI6SNZDZiIE+/ws3W8tpm9?=
 =?us-ascii?Q?wSboOTrlTpm49Mc5R6zICOhFr52X5h2OsWSxkkmlhbvKAZoTHSnknOYaLo2/?=
 =?us-ascii?Q?W7pnjodFsUvmlA4xMboLGb8zJWXgo6bNlYDu9B9SgLirS2w7/KlUygAOFbEO?=
 =?us-ascii?Q?y725z7MlWDRNN+BEmnctb4UwZD9oXNwRl8rUZGhhoUfYH2g/+VZr5NvpFELx?=
 =?us-ascii?Q?1YpFZmZA8aMOMrpH07YHpnE1PLo5dsi/hyqC15T/jAPt23arI1daq5r+ARPs?=
 =?us-ascii?Q?RcA7oRlpDd4vRccm+Kz5D0VSTFCEbJPBFuaNyVNdNfssQl4s/GfIalu8cJiQ?=
 =?us-ascii?Q?2V1FruH7Z1a/moI2TL7FcB59JTvTy9+DQGuM6TcSXTRarTvhAtB8gfPVDQJi?=
 =?us-ascii?Q?RvZWzqHg3qbTj02fMNMpE6yHzPh4pqdOOTyYoPYbwRe14nYxq0tMG3HutiOK?=
 =?us-ascii?Q?ggWrmKIcwnOTXlmsylK0VanFpzm+71JmcIydTLwKUV2OgYFA4cKSpQMY2S1m?=
 =?us-ascii?Q?g2X76NGeF+ugycZYNGQAt2JYs9z2KPol7bm8Fr4g8nxzbNZR7NbtFRB9gWbi?=
 =?us-ascii?Q?cog5YbCPLQ6djcRP10NuCv76qggSZ6UzYElGi+oAo7RxJGLpWiJOY2M+kQsY?=
 =?us-ascii?Q?Jfgdo0PUDgdJw5BVfYk/csqfHv+LGNmHWRUSFuxxm1X4GExS9/DHNYDzRNcl?=
 =?us-ascii?Q?tHnZTVzR8G9xQRWD/PSeI0bPshUvNh702uh2ELk2OTYqI18pi1ekGy84yG5T?=
 =?us-ascii?Q?Fg=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	0bBjO+2MCje+MG5MwR+7X8WcH8wKCXA5RP4TN2n7pYN45bJ2EXZATNpjbseTNTpmACm+MdHw0zjnO5Wzm3qOcnf4i3Cjcq4WBWjmTWXV/gQw69okIWkR2L8IF4lrZT/g/hh0R+GybgdgPV+eIKgmImXdIma8x7p+BEWnZNt0rHZbKXIA4IOJGH36vQTp2cbfHO9zePjArB1+3O3d+BhSLXTUGETOyJZ6UpU2RErPV3NukPk1AVPej4Ku/eU8xHzxODfK3PIoxkKnvsMyA/KRr5Q4Cfa/QozmHrzUmjp2V90CeNmRzO/E5Rpkko8ZlijavHjCIY5WX2BcD+6VhgFJFr5fEQsqSx5xKhzWgN7UpOBJ1oKxPvGuh4m1khe/W/YIBgC3NCAQYRHRnbFPDDh/fsROcFAwswWTS0SbYStmy3apgg3Ilaov7Qcb9KQEye83rzmpdWy1ZX1EAlO4tjRprcdGiOgVm7fpH/LwO9QZqTw95yl16d+n60OxZchFqXv/WcIAOLrcqxqBZ1fbg7bJVHfhZa7ov5leI4ROqvjyrBFdMm7rno6LRhvx64AonpEF6flFskEu9rqU91pOEPFgRq7+KpSKGBdm9x1T8VESudU=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f842351-6055-48b2-71f8-08dc5e4835fc
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Apr 2024 19:05:41.8982
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zsc7O8zTmAwLZTC73pmB1fn80bbX0VPImF1KL1utSdvjU1B+5Yli6qTwmTjpHDcHtVDwTAu8xfssUeEVi6DaNw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR10MB6964
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-16_16,2024-04-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 mlxlogscore=974
 mlxscore=0 adultscore=0 phishscore=0 malwarescore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000
 definitions=main-2404160120
X-Proofpoint-ORIG-GUID: 8GDClqlFWcZ5vYQwzKj2CAp5sK3V6OsJ
X-Proofpoint-GUID: 8GDClqlFWcZ5vYQwzKj2CAp5sK3V6OsJ

On Mon, Apr 15, 2024 at 09:44:33PM +0200, Lorenzo Bianconi wrote:
> Introduce write_threads, write_version and write_ports netlink
> commands similar to the ones available through the procfs.
> 
> Changes since v7:
> - add gracetime and leasetime to threads-{set,get} command
> - rely on nla_nest_start instead of nla_nest_start_noflag
> Changes since v6:
> - add the capability to pass sockaddr from userspace through listener-set
>   command
> - rebase on top of nfsd-next
> Changes since v5:
> - for write_ports and write_version commands, userspace is expected to provide
>   a NFS listeners/supported versions list it want to enable (all the other
>   ports/versions will be disabled).
> - fix comments
> - rebase on top of nfsd-next
> Changes since v4:
> - rebase on top of nfsd-next tree
> Changes since v3:
> - drop write_maxconn and write_maxblksize for the moment
> - add write_version and write_ports commands
> Changes since v2:
> - use u32 to store nthreads in nfsd_nl_threads_set_doit
> - rename server-attr in control-plane in nfsd.yaml specs
> Changes since v1:
> - remove write_v4_end_grace command
> - add write_maxblksize and write_maxconn netlink commands
> 
> This patch can be tested with user-space tool reported below:
> https://patchwork.kernel.org/project/linux-nfs/cover/20240412-nfsdctl-v1-0-efd6dcebcc04@kernel.org/
> 
> Jeff Layton (2):
>   nfsd: move nfsd_mutex handling into nfsd_svc callers
>   SUNRPC: add a new svc_find_listener helper
> 
> Lorenzo Bianconi (4):
>   NFSD: convert write_threads to netlink command
>   NFSD: add write_version to netlink command
>   SUNRPC: introduce svc_xprt_create_from_sa utility routine
>   NFSD: add listener-{set,get} netlink command
> 
>  Documentation/netlink/specs/nfsd.yaml | 104 ++++++
>  fs/nfsd/netlink.c                     |  65 ++++
>  fs/nfsd/netlink.h                     |  10 +
>  fs/nfsd/netns.h                       |   1 +
>  fs/nfsd/nfsctl.c                      | 476 ++++++++++++++++++++++++++
>  fs/nfsd/nfssvc.c                      |   7 +-
>  include/linux/sunrpc/svc_xprt.h       |   5 +
>  include/uapi/linux/nfsd_netlink.h     |  46 +++
>  net/sunrpc/svc_xprt.c                 | 167 +++++----
>  9 files changed, 819 insertions(+), 62 deletions(-)
> 
> -- 
> 2.44.0
> 

I'd like to take these for v6.10, just to get something we can start
working on together in the same body of source code. I've been
waiting for a degree of consensus between you three... Hopefully
this week or early next?


-- 
Chuck Lever