Received-SPF: pass (google.com: domain of linux-nfs+bounces-2883-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 17 Apr 2024 12:28:54 -0400
From: Chuck Lever <chuck.lever@oracle.com>
To: Li kunyu <kunyu@nfschina.com>
Cc: jlayton@kernel.org, neilb@suse.de, kolga@netapp.com, Dai.Ngo@oracle.com,
        tom@talpey.com, trond.myklebust@hammerspace.com, anna@kernel.org,
        linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lockd: host: =?utf-8?Q?Remove_?=
 =?utf-8?Q?unnecessary_statements=EF=BC=87host_=3D_NULL=3B=EF=BC=87?=
Message-ID: <Zh/4xozLPreN7ELW@tissot.1015granger.net>
References: <20240417082807.14178-1-kunyu@nfschina.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240417082807.14178-1-kunyu@nfschina.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?Ih/ftXuc3xHsGrtIKZmvLYglJgTawOBgPaMR7jwgDHRyYOETIm/M1NKBT/mQ?=
 =?us-ascii?Q?C8LCPQmXEZEw4RvZyl8sGrdDI9lVMrPQFHYsUywSUeKo8eiqdxQfbwbcH7yA?=
 =?us-ascii?Q?mk/7Wno7Aq/dEDkKaOO2lM8rkv8jjf1/BybQJY5I8P+ukYad4EPhilVUSreY?=
 =?us-ascii?Q?+fuAFuA4zysecxgHqEWhuUwBJhL0cluNiSjd6hySZOHhFZlgWmC6TasxAWbd?=
 =?us-ascii?Q?/T2YjazapH7PnErpHmhNpAxLdpG3rmeS7pyqlGnzQED5mit0nTA6OMOknQmB?=
 =?us-ascii?Q?6bP9FIgk5qtj2FvvY2sykU5iYPhe55A19vaMABoUCloorucrq2LfV+Vl9Gcb?=
 =?us-ascii?Q?3974URPYrP+jVjEKuzejvp3hD3ZiSXa2PFwjvU1RrZBeBzl6IxtsLbPFuApI?=
 =?us-ascii?Q?bA8DeHK9aopMhNCJaQwe9H1Ljkx31lGkHGYQpewHdHZZjUpFVl1ODisHe8oN?=
 =?us-ascii?Q?tzBHnlf94YtfERVQckyaNP9kL2k8ZBmqNZL00ja206EIJq1DgUeDKdbvbTTu?=
 =?us-ascii?Q?UPFyRF+h8cLRN386aJg1C+hxkOysm6hoHZZbQ0gK9lTmm5PtZN2eDDZyWJls?=
 =?us-ascii?Q?OSSYF9wy7rVkb5XbtFIHHasHKpC68VCOzhqavt5NtfP4MP/5ZMWGWzvDimJF?=
 =?us-ascii?Q?YkrglmpKm+KvtY7P2J013MpQtp0xy+MtqJQIQXGQmwNvP3xjnXrqTO4FOQsj?=
 =?us-ascii?Q?mkeBYHtHbxvpSc6orRo4y/XqG4LEGkeyh+kzepXbF02SpqHNvUGdvqRIWpND?=
 =?us-ascii?Q?aZ/c95y/Tv4te0n+xnfHEAPr1AOYPGEXbjviJEotdkEs6DNmuM66h94LaaA3?=
 =?us-ascii?Q?8s212Czp7slvVI+DWQ84JIHfNO6M+c/3TWHxusS4nsRytkIm++i8J7HgLnKu?=
 =?us-ascii?Q?t4NeLPNbQy3lPtbVpXiv1eeH1iXO+bfQEe3OKXD0aLGHbrbL0qT82TrID5cn?=
 =?us-ascii?Q?d1XJtsV538sO+/J8fP2pSniWfHK4y9nWkymWFS8TWnvwC+AIyfGqkOVdMGWi?=
 =?us-ascii?Q?3HYGzs0aYYFBxaApcLY0Z7u4RU2NJZRUqT4oOMN9tRQjzF5hdFP+YhpZGmr6?=
 =?us-ascii?Q?Bgyvh2aK3gpADQw7S+NXVGNK/i/o/aWAlDQ02l+7uv9JC2eZfn3Zngkw1vhj?=
 =?us-ascii?Q?ANF/oDFSx3htK/Q8Pgo+9lb8S7VOqTdrPkQj877Zt1NVKjgzO94Xciayr4vz?=
 =?us-ascii?Q?sTmzkgkgo4LwD5UVC+n4rkoSA5EPDBlWDaEdDmPDRQ81PBavNSwnGz7X7R4n?=
 =?us-ascii?Q?K1L1Zg6sM2Fgh61J8WgODUS7m+4qnkP17C2SxCa3P4o7GQIoaLmq7QKzK8Pt?=
 =?us-ascii?Q?d6qPByxo6ljDQwGnFtNZqXJA7VTb89GS86Lr07jOO1nEFGLLxwxkTHyxops3?=
 =?us-ascii?Q?kdelfB67Kx+VTvwkEbWnMO+FmXXFalmHNjYy5gbdqYQGz+poQmKUoOCsrAja?=
 =?us-ascii?Q?bLVIjLDeMxrOBiP9L5JXc77g72buSnPvaaauSEOkHY/oGFrYSxMrVvDBZDG9?=
 =?us-ascii?Q?6AKMgZsu2Jd9PYGdKgJG0QPXz9FuymswBEbg8AuGeyT8vwTE1iqCEtnjTUNu?=
 =?us-ascii?Q?dc11Gu6U9sd/shp62wJCyhakl1UFshgYHrEJ1c1J+VjTWv2+hZFguTDCMHQj?=
 =?us-ascii?Q?Lg=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	IFM+1YdhgIj62dHGz9RGl5oFsKGI8diJVfyHlCWXwScfLKMR8nvPShpPkayp/kh5obErzYBYFDfey+egtbcVT8Mjevgp1zgs9cDn72SbXjyNAURig5y0GRnJ3UM19QA1ApE8b5/RugInCc97iqd+y+rvh20kZIXr/207wYKxz4mG/awHIYglWx5gv5I6ScLht7Hmn7TW5s1hJiKpCSYiF5xHXXCslyK8IaLBkSrvDHJmj9IUow8r8WZGZiRWQbvjqLVhu7OXhYT2Hrxe4ABpNX/fjnr6IZ9mAogOCKdBHIErwUHZ65hcJpG4hAa33wx1SfhqgMglrI2HimgNoAhDIPhGkFgMDgdMT1POv9Fv0gfbqJtqtixOBU6lIZZxv/jjiL5KbRmf12JtSUtzQIwFyOcoUKG3oARsFJuKJs/qOBLvEP+6ZnagD1ytdzQNeccL7JO5dlHnrKpehHGa17Y9ONNKGj32rTK1wHqyiffNrEgGBz+uNtb4bvAC+i7k6y1ybj/SrarQbAEOcTsUBxguwcBmX6MqBPqyrMNYl87bFCLXR317lSxgkP9w9atyCYRqrqRwFkdAyfS23KzVbOfvrWlOfTr+KGPLFGLy2vmKPIU=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b3ce4c11-42f2-4c45-5a93-08dc5efb7af0
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2024 16:28:57.3763
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lZEyYzmP7R8/gYtIIzeS9h4QtLfmp0F2DvBT5lGYnSrMsRoCuJ/ma4ZNjQ44jpdwz4EPOQp+eFV4vUz8WxgjcQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6084
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-17_14,2024-04-16_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 adultscore=0
 mlxlogscore=999 suspectscore=0 bulkscore=0 spamscore=0 mlxscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2404170115
X-Proofpoint-GUID: beqoRiv5IGDVoAffT8u-_TBspYEbp6P9
X-Proofpoint-ORIG-GUID: beqoRiv5IGDVoAffT8u-_TBspYEbp6P9

On Wed, Apr 17, 2024 at 04:28:07PM +0800, Li kunyu wrote:
> In 'nlm_alloc_host', the host has already been assigned a value of NULL
> when defined, so 'host=NULL;' Can be deleted.
> 
> Signed-off-by: Li kunyu <kunyu@nfschina.com>
> ---
>  fs/lockd/host.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/lockd/host.c b/fs/lockd/host.c
> index 127a728fcbc81..c115168017845 100644
> --- a/fs/lockd/host.c
> +++ b/fs/lockd/host.c
> @@ -117,7 +117,6 @@ static struct nlm_host *nlm_alloc_host(struct nlm_lookup_host_info *ni,
>  	if (nsm != NULL)
>  		refcount_inc(&nsm->sm_count);
>  	else {
> -		host = NULL;
>  		nsm = nsm_get_handle(ni->net, ni->sap, ni->salen,
>  					ni->hostname, ni->hostname_len);
>  		if (unlikely(nsm == NULL)) {
> -- 
> 2.18.2
> 

Thanks for the clean up! Applied to nfsd-next (for v6.10).

-- 
Chuck Lever