Received-SPF: pass (google.com: domain of linux-nfs+bounces-2956-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 23 Apr 2024 09:41:53 -0400
From: Chuck Lever <chuck.lever@oracle.com>
To: Dai Ngo <dai.ngo@oracle.com>
Cc: jlayton@kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2 1/3] NFSD: mark cl_cb_state as NFSD4_CB_DOWN if
 cl_cb_client is NULL
Message-ID: <Zie6ochDV9VjumK4@tissot.1015granger.net>
References: <1713841953-19594-1-git-send-email-dai.ngo@oracle.com>
 <1713841953-19594-2-git-send-email-dai.ngo@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1713841953-19594-2-git-send-email-dai.ngo@oracle.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?/R3i5omyVA8gRIQvgcZcNHn/AIgKibM/zb0IYRp2gzTBUvOHJfrzfof9BUnA?=
 =?us-ascii?Q?YwYrism13Hj19HsJow7nZhb2erjHdBBfzEZcCzviYHZ62ZMyhN+SrD9SOS0/?=
 =?us-ascii?Q?GEMfaxXWW8Akh7SD/hFxaxX+fg1BINyl7b9VPuLQRBrlOV9Q+YlZmoBCs0tL?=
 =?us-ascii?Q?X2trS5fwg4x6yvU10lvvt3z4YzCq7tvsITwrNCgVS2Nm847P5Z43/gqjSEwl?=
 =?us-ascii?Q?UpkwlU1UTJkGlc0GcmXLorMe+NNehyoq2kG8vVC8OREoWkwVz8H5zNnQuHUU?=
 =?us-ascii?Q?LTzUSj1AAGxgoV/3tlYaeP5A/2CbmaDiSz/Jj/1rhlaF6tOr1wdQYDA0G9RF?=
 =?us-ascii?Q?7b6BZ1JJzt60NgkOzaLp6z3hUuOkGK801yMuKuzY49n6ikJeJeSkjyioTsVv?=
 =?us-ascii?Q?uLaXQUj39M5b+3Q7rkmAR147iLo5IfVcqShs9Yg1Mub+ABUvP8Ug+n7+n9s3?=
 =?us-ascii?Q?zoVNQp+GFId+NcuhHE2QnRfqW6UXZ4yA9ijMm6aJVLH+LjJ3l19ezBIyOv0V?=
 =?us-ascii?Q?+Q0JhmfRoEfhMHH2+wy8pIX71DANJBHrAdqRp6qCCMyc+Ni2Fti5gZvTJUsd?=
 =?us-ascii?Q?5CHC3aoBJPDpAt9FzjdehYSqyefOJ3x+KAkZRrP6Zp5w/9Hr0o6zDfzYCjPo?=
 =?us-ascii?Q?5DmUuLpLTWmRoZJ+DgnLWazmNNPdIH/KMpMddaJt9as9mNLCT7R+fW9ikas9?=
 =?us-ascii?Q?C2lnj1bgv1gk9quJ86BYl67sSgJu91Mqffy18ole8LCWwOk/tSfh1AFQJELg?=
 =?us-ascii?Q?+6PPnB51ggiPWXwMZbGNYg7K0paJHRkZCRKHT1Lj0eS8usSFS2dchhqqkZvt?=
 =?us-ascii?Q?Oys2sVKGRW6h2kg/2xH/oIGAU7Lpx0FjXcBI+5Jyik95J/EP7WqdiChwFqPn?=
 =?us-ascii?Q?HvEx+li5LPeiC229gQ+w7Fau7XJBN//CnQf/zJY/+4aEfs0cRemb2yqdS6jv?=
 =?us-ascii?Q?CWCaTRtENxQgCfPUli9snvh+do1I3+kRvWMooxNb7NH2xLf3Qsp9piaAZEEf?=
 =?us-ascii?Q?TkHk2m7rXD+NzIqW6F/or8sJFHqN+Jvy6Td2iMF4/Bp3mODaB42z4DWpZunG?=
 =?us-ascii?Q?IA0rt54khR9mJ4bOSZOKyep8a76NzTHS1k1F5fU1bB8RB+nWE64Im1ulaCLn?=
 =?us-ascii?Q?uI8gqcyB6ZwBV9y3QBKxgaDdQy0mSqwfrsrYFZNfsRVu7r/w5R1PPfJSQrxN?=
 =?us-ascii?Q?X60yZuO5IVe1jttIAOi9ADhNk0t+J6EFunu70RrWMnFGdTAUo5Yq+Ms7LmX7?=
 =?us-ascii?Q?ta+s3/TCsAwPdf/eU6orndWEax86oKlFuuGPlm3/47n5ievj6sBsjMEPjqK3?=
 =?us-ascii?Q?mAADioKl3DCNN53Q1bHN+BnXPvjqiK7fja8JoRpQo3pYZD5G+PN2iW1zfGYa?=
 =?us-ascii?Q?x/vZyDQmwE5u1lxoApZ2oZP2XCD3RSouEd7/Wu8IKlEEFV6mVYLhU2fTufL5?=
 =?us-ascii?Q?wIdxVsgyJ4ja4xRvYLLU4r1g/L8UQ8+2r123WTJNhjC8CsruJzxX2P+taRI7?=
 =?us-ascii?Q?O+/G8+9n1C5/ztvKIc1ee3w67uiPeHcriosrIyK4T+f4TAmB/syAB+hHd3OO?=
 =?us-ascii?Q?9jvOKMC4ZXAYt5VnfaY6AvdKxZGrofEn2AyguWv7U6hl06BmoieoBaV9y6N0?=
 =?us-ascii?Q?nQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	kHCIOCUf9G5KseLCKfbCy6IHoOVuYDjtsWPCRnpfV8yuzKOstXMqMPkYb3UaiY3mCUl6t22BB9Cg8kaWI1QqPjVayUvUKa/cd6v1PNxJvyucQUfsNpBvrJjWoQb1AZih17s1umM23HdQIqnlN2NpcsGLeqm037N4P55aO5T+FXNeLC2PEXY60DDQHJuM1xhYsGkxLO94pJ+6uyWLsTUppWnTqs3KY8XUAX7wW5r268fxyqdhFhzyg+N57W/d2PMdEXEx6Zx9/7WOP1V7wd13a5vQD1E2jZCBI6DW9vNcLh/hIG9h8DIVG/a7RIF5BcxrkGVqZbfD11ZZ2CuSW+TyPBk36htVxbuT1cLg+aqiEgx9cvaBktTtJ+WbN+Kh3q15IsBhLHI1qy8RM9mKotOphbVjKIj23GmOSJRXLRqsKVf9L6Bs+2tNI91skTycHEOZHBlgV1xhUlSHa6Q+HmfrosuxiBjGlSDTh5DHnrSP+dNYhFyviKpoNQNvuqGHQsgFkYmCTa/xewiKdz2mh0fnE6TjFlVr91pvFmojVGcIoMo7QKK4ci9NcEQkrU3BZL9L+vMmDRZUEbFizSxE3Epk8RBqcZcGcdYavSy0pZvYJWo=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 77e73f3e-0ddc-45d4-2e91-08dc639b246e
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2024 13:41:56.3270
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 91+Cpl/+pFWv/UW3S5kGTKHwyiSiUGBbkZi6PwU8lJf6Rh8+B7PXTtI8YzWF/qKuRO1W0H+6vw896P6eHJinMw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR10MB7688
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-04-23_11,2024-04-23_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999
 bulkscore=0 mlxscore=0 suspectscore=0 adultscore=0 malwarescore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2404230034
X-Proofpoint-ORIG-GUID: UAg9DaYeL-khTCYzDzs7GR7nDSZX9xaU
X-Proofpoint-GUID: UAg9DaYeL-khTCYzDzs7GR7nDSZX9xaU

On Mon, Apr 22, 2024 at 08:12:31PM -0700, Dai Ngo wrote:
> In nfsd4_run_cb_work if the rpc_clnt for the back channel is no longer
> exists, the callback state in nfs4_client should be marked as NFSD4_CB_DOWN
> so the server can notify the client to establish a new back channel
> connection.
> 
> Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
> ---
>  fs/nfsd/nfs4callback.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
> index cf87ace7a1b0..f8bb5ff2e9ac 100644
> --- a/fs/nfsd/nfs4callback.c
> +++ b/fs/nfsd/nfs4callback.c
> @@ -1491,9 +1491,14 @@ nfsd4_run_cb_work(struct work_struct *work)
>  
>  	clnt = clp->cl_cb_client;
>  	if (!clnt) {
> -		if (test_bit(NFSD4_CLIENT_CB_KILL, &clp->cl_flags))
> +		if (test_bit(NFSD4_CLIENT_CB_KILL, &clp->cl_flags)) {
>  			nfsd41_destroy_cb(cb);
> -		else {
> +			clear_bit(NFSD4_CLIENT_CB_KILL, &clp->cl_flags);
> +
> +			/* let client knows BC is down when it reconnects */
> +			clear_bit(NFSD4_CLIENT_CB_UPDATE, &clp->cl_flags);
> +			nfsd4_mark_cb_down(clp);
> +		} else {
>  			/*
>  			 * XXX: Ideally, we could wait for the client to
>  			 *	reconnect, but I haven't figured out how

NFSD4_CLIENT_CB_KILL is for when the lease is getting expunged. It's
not supposed to be used when only the transport is closed. Thus,
shouldn't you mark_cb_down in this arm, instead? Even so, isn't the
backchannel already marked down when we get here?


-- 
Chuck Lever