Received-SPF: pass (google.com: domain of linux-nfs+bounces-3003-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 25 Apr 2024 10:07:14 -0400
From: Chuck Lever <chuck.lever@oracle.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: linux-nfs@vger.kernel.org, neilb@suse.de, lorenzo.bianconi@redhat.com,
        netdev@vger.kernel.org, kuba@kernel.org, jlayton@kernel.org
Subject: Re: [PATCH v9 0/7] convert write_threads, write_version and
 write_ports to netlink commands
Message-ID: <ZipjkqTcbcWcmQJ/@tissot.1015granger.net>
References: <cover.1713878413.git.lorenzo@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1713878413.git.lorenzo@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?ZNGiM7zjU1oV813PdjPdkPDJFAEWzM81f0m1Gs5UdEPhQuxK5H6QE0vXJHhp?=
 =?us-ascii?Q?jSS+QXE9svzRUNP+AWV7RrHXRVJ1kxybdos6CqaLSbH2XCAHY2GnYXv0qHY0?=
 =?us-ascii?Q?k3xT7QfBEykL56vDRANsggodK6Gkwu6No7qsvMBQUW5shRdh3jrxXqHFI20H?=
 =?us-ascii?Q?1/oViz5MufS0gmn6/P/xfWvO/wOc3auH+PGgSQdhPvLVs7Cg96MftMgpHzah?=
 =?us-ascii?Q?jkyM8NOELjclwX/ggSGuhZ3tKYfjKjwHKwbMp0U1qcLDTPov9dA6AdvQPQ7/?=
 =?us-ascii?Q?cYSMo3fj7XLZMacglVhKzuGTqtz/GgPiwQ5CmNrrh21cqpLvCg1B0dVQI2Mu?=
 =?us-ascii?Q?leo56InSpVp39mLuUM/dwWVH5p0xHMm16feUG07rzbZ+cKaxQpmojvoXTC2b?=
 =?us-ascii?Q?y9G8C6oekkTNXELRCUoDx93A3XGn3rRmQC5ibeyPiK20/I5L9Empj8PFDkr+?=
 =?us-ascii?Q?elUKC89qDET67tnpXfL+cItl6BI7cBv+Yj/CZSX9bLHpRAdCR/bPmAOsK7uT?=
 =?us-ascii?Q?HPfxGuhlNlgPl7KWivOm8qadXgZJQVnrRVwwJ71ewpVwfEr/eKQ7eSW7pCnE?=
 =?us-ascii?Q?yDK5PSoGyZG2ou0lW/hTDzI6XgqMM3URh52+i9taTJe6w0sJ//QmeiC8uAhS?=
 =?us-ascii?Q?a5uM5GeLeah4+yzjL5J3G1ULdkHHgRcowmrjkWDkVxKACOE0/tM9j9O5DcKg?=
 =?us-ascii?Q?FgRggRLaMHURhgjtgcBYnpjXd/jkPFWgTM+w/DiTeoVB9la90rqzL2qYCjXR?=
 =?us-ascii?Q?Pwf5ss7SAfppZAiX5pC2YTutCuxIPoDEHOn1sJ3XnHRj+Kg/dwppAAs1XgJw?=
 =?us-ascii?Q?WxTwLiFaiLN+iNdi9MBLBgPYbhinzXvBMrR6MmsQnXFqByRSyM2IU0Cqotie?=
 =?us-ascii?Q?H9WBY2b+umS5B9J0nBQQgcUIxK5u7iZ3KhBZvn/nkf/9iNIgiFJEur0wWA1s?=
 =?us-ascii?Q?+vL5ohfUoipv1laNGeeTZ7s7q7TvncbtMw3k4W/1T+RKrabUD9tReL8pYG+S?=
 =?us-ascii?Q?hn80aEJw+NHfbMKMDiLinLSvuSHF9vmHck5zfqhO8+prgxQBOBMkNelVHuNI?=
 =?us-ascii?Q?1YvehAt+hmgGuKwpWICf9tH1USBG3zuMT3bSDhKImWDQ2jq/yhjQTXC4yov3?=
 =?us-ascii?Q?/gv7M0RivJPICAzx3i1lsT5+0FO2Kof890v2cG1LMDYOcNu2IjvLhqenYwKD?=
 =?us-ascii?Q?AjYGugXBC/eNR7DvRuWlGsOJMht6IFIygYxVVzklr5ElwABe2JkU5uA5rVlp?=
 =?us-ascii?Q?JxGQaWe/x68DyDhvgRDN+JGHP09+xKc8Sg9ZRlkiGdE2rTm8Eur2+rk7UXAh?=
 =?us-ascii?Q?kpDSgiS34CMKSnG1E1fCXeQqTnMcXDOIAzXCr1ilAZrBChgw1axB3fM53//z?=
 =?us-ascii?Q?shmctERE7zWoDNbT1hA/8UBJFX3TliqcUdKk7M9zbnJd8kdQH7Wf/CiCL+GV?=
 =?us-ascii?Q?e3qWxVj7115XMcJ1BFA4uOOnpX5paitT9b2zBZlzyHqP6wJv5GuNLz4TW/uV?=
 =?us-ascii?Q?3uWj9ShCtVc7GPHKCZ117b17Zt+VGqIKvQPR0o5PTRrOMVQ32X2dcDonJS2I?=
 =?us-ascii?Q?VDhb0jtF/KSxSbw8WpRdt1aisYHyiPHBoI0/VbNT0UVB83gQQXig0VQZ4SHz?=
 =?us-ascii?Q?4w=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	h7uvCxV6rL6FLC0CxGqbkh99RWnRZ7SEkdeI2+6bvxTiEFNJEW6Z4qTg2Hs6JQbJ4ikfKlHFbA+vGi3yScCBUVkhiuxJx1AWOligS8Pbu934+8q2wxborMGfEVWAf3m7hN1JBuXhBKNG94Ib7hQ1jn+tiiDK6qItj0W/dSLpAaEbJglzELwzITqP6REX+I2MZhRxeK0L9+jTUvhBKfr7UEH/I8XJAh5iHsWAmnDrKSEX7CTBhna8BfdP9EJ5R++ipfwp7pBpkVPvelOi1sNhZ6KL2xcvMLDLPSZBtmQ6vjxVfxtJqVNmSTtVTE+cOQA29q7NaM3Ua91wDoPs1Y6giktkwDMmwH39lHY8/4pO9HojY2T9Qf7vZ0Sa4wFg/RQbNZuD2qbKyPbD1WyXgrBK0J4U0BId+4GuDjr9g6dwrn/z3a1PfHHaTUT2ml7cBZT44SIDXEsTEJv9vf+0rLmkxYBdo2qz+56UByu+AFSCjuBw4r/WOUgBqG8kn7nvy0SfGfb5jJj+A3hnyhj/Hno1yaavsMVsEdseSODNLT0VxrjfVjXBtO4jiKeL54fnB02t1lq8lezoZGmHXMULC0Mke1NQ94mn8OOBDYzvwyKLIE4=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cb3d9801-af61-4288-b637-08dc653103cc
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2024 14:07:17.3776
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hdI0eXEaju2EbXF7f5yNhBkCmYGv2Sf3ozjaIfKu8l/1QDGiQSsf0hQK7yuk0auYfXUd4derQ+cFKt0dfboVcA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB6400
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-04-25_13,2024-04-25_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 spamscore=0
 bulkscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000
 definitions=main-2404250102
X-Proofpoint-ORIG-GUID: KI7rrxcLhRH2lfgqgstR1oXhw17B0RFt
X-Proofpoint-GUID: KI7rrxcLhRH2lfgqgstR1oXhw17B0RFt

On Tue, Apr 23, 2024 at 03:25:37PM +0200, Lorenzo Bianconi wrote:
> Introduce write_threads, write_version and write_ports netlink
> commands similar to the ones available through the procfs.
> 
> Changes since v8:
> - introduce scope parameter to write_thread command
> - add the capability to specity multiple threads in write_thread for future
>   usage
> - fix comments
> Changes since v7:
> - add gracetime and leasetime to threads-{set,get} command
> - rely on nla_nest_start instead of nla_nest_start_noflag
> Changes since v6:
> - add the capability to pass sockaddr from userspace through listener-set
>   command
> - rebase on top of nfsd-next
> Changes since v5:
> - for write_ports and write_version commands, userspace is expected to provide
>   a NFS listeners/supported versions list it want to enable (all the other
>   ports/versions will be disabled).
> - fix comments
> - rebase on top of nfsd-next
> Changes since v4:
> - rebase on top of nfsd-next tree
> Changes since v3:
> - drop write_maxconn and write_maxblksize for the moment
> - add write_version and write_ports commands
> Changes since v2:
> - use u32 to store nthreads in nfsd_nl_threads_set_doit
> - rename server-attr in control-plane in nfsd.yaml specs
> Changes since v1:
> - remove write_v4_end_grace command
> - add write_maxblksize and write_maxconn netlink commands
> 
> This patch can be tested with user-space tool reported below:
> https://patchwork.kernel.org/project/linux-nfs/cover/20240412-nfsdctl-v1-0-efd6dcebcc04@kernel.org/
> 
> Jeff Layton (3):
>   NFSD: move nfsd_mutex handling into nfsd_svc callers
>   NFSD: allow callers to pass in scope string to nfsd_svc
>   SUNRPC: add a new svc_find_listener helper
> 
> Lorenzo Bianconi (4):
>   NFSD: convert write_threads to netlink command
>   NFSD: add write_version to netlink command
>   SUNRPC: introduce svc_xprt_create_from_sa utility routine
>   NFSD: add listener-{set,get} netlink command
> 
>  Documentation/netlink/specs/nfsd.yaml | 110 ++++++
>  fs/nfsd/netlink.c                     |  66 ++++
>  fs/nfsd/netlink.h                     |  10 +
>  fs/nfsd/netns.h                       |   1 +
>  fs/nfsd/nfsctl.c                      | 517 +++++++++++++++++++++++++-
>  fs/nfsd/nfsd.h                        |   2 +-
>  fs/nfsd/nfssvc.c                      |  11 +-
>  include/linux/sunrpc/svc_xprt.h       |   5 +
>  include/uapi/linux/nfsd_netlink.h     |  47 +++
>  net/sunrpc/svc_xprt.c                 | 167 ++++++---
>  10 files changed, 870 insertions(+), 66 deletions(-)
> 
> -- 
> 2.44.0
> 

Applied to nfsd-next (for v6.10) with many thanks!

-- 
Chuck Lever