Received-SPF: pass (google.com: domain of linux-nfs+bounces-3021-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <30ab2ca2-2eaa-3c11-c5ff-580230b4b84c@linux.dev>
Date: Fri, 26 Apr 2024 14:15:27 +0800
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PATCH] SUNRPC: Remove comment for sp_lock
To: NeilBrown <neilb@suse.de>
Cc: trond.myklebust@hammerspace.com, anna@kernel.org, chuck.lever@oracle.com,
 jlayton@kernel.org, kolga@netapp.com, Dai.Ngo@oracle.com, tom@talpey.com,
 linux-nfs@vger.kernel.org
References: <20240426034750.26945-1-guoqing.jiang@linux.dev>
 <171410437515.7600.14267125361277447684@noble.neil.brown.name>
Content-Language: en-US
From: Guoqing Jiang <guoqing.jiang@linux.dev>
In-Reply-To: <171410437515.7600.14267125361277447684@noble.neil.brown.name>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi Neil,

On 4/26/24 12:06, NeilBrown wrote:
> On Fri, 26 Apr 2024, Guoqing Jiang wrote:
>> It is obsolete since sp_lock was discarded in commit 580a25756a9f
>> ("SUNRPC: discard sp_lock").
>>
>> Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev>
>> ---
>>   net/sunrpc/svc_xprt.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c
>> index b4a85a227bd7..ec78c277a02e 100644
>> --- a/net/sunrpc/svc_xprt.c
>> +++ b/net/sunrpc/svc_xprt.c
>> @@ -46,7 +46,6 @@ static LIST_HEAD(svc_xprt_class_list);
>>   
>>   /* SMP locking strategy:
>>    *
>> - *	svc_pool->sp_lock protects most of the fields of that pool.
>>    *	svc_serv->sv_lock protects sv_tempsocks, sv_permsocks, sv_tmpcnt.
>>    *	when both need to be taken (rare), svc_serv->sv_lock is first.
>>    *	The "service mutex" protects svc_serv->sv_nrthread.
>
> I usually make an effort to find those sorts of things but I obviously
> missed it this time.
> Thanks.

I find it occasionally during investigate one nfs issue ????.

> Reviewed-by: NeilBrown <neilb@suse.de>

Thanks for your review!

Guoqing