Received-SPF: pass (google.com: domain of linux-nfs+bounces-3033-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <7da9588d3381763c388c10567704a3abed93a578.camel@kernel.org>
Subject: Re: [PATCH] NFS: Don't enable NFS v2 by default
From: Jeffrey Layton <jlayton@kernel.org>
To: Anna Schumaker <anna@kernel.org>, linux-nfs@vger.kernel.org, 
	trond.myklebust@hammerspace.com
Date: Fri, 26 Apr 2024 08:05:08 -0400
In-Reply-To: <20240425203440.440780-1-anna@kernel.org>
References: <20240425203440.440780-1-anna@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.0 (3.52.0-1.fc40app1) 
Precedence: bulk
MIME-Version: 1.0

On Thu, 2024-04-25 at 16:34 -0400, Anna Schumaker wrote:
> From: Anna Schumaker <Anna.Schumaker@Netapp.com>
>=20
> This came up during one of the Bake-a-thon discussions. NFS v2 support
> was dropped from nfs-utils/mount.nfs in December 2021. Let's turn it
> off by default in the kernel too, since this means there isn't a way
> to mount and test it.
>=20
> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
> ---
>  fs/nfs/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/fs/nfs/Kconfig b/fs/nfs/Kconfig
> index f7e32d76e34d..57249f040dfc 100644
> --- a/fs/nfs/Kconfig
> +++ b/fs/nfs/Kconfig
> @@ -33,12 +33,12 @@ config NFS_FS
>  config NFS_V2
>  	tristate "NFS client support for NFS version 2"
>  	depends on NFS_FS
> -	default y
> +	default n
>  	help
>  	  This option enables support for version 2 of the NFS protocol
>  	  (RFC 1094) in the kernel's NFS client.
> =20
> -	  If unsure, say Y.
> +	  If unsure, say N.
> =20
>  config NFS_V3
>  	tristate "NFS client support for NFS version 3"

Reviewed-by: Jeffrey Layton <jlayton@kernel.org>