Received-SPF: pass (google.com: domain of linux-nfs+bounces-3036-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 26 Apr 2024 08:58:53 -0400
From: Chuck Lever <chuck.lever@oracle.com>
To: j.granados@samsung.com
Cc: "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Alexander Aring <alex.aring@gmail.com>,
        Stefan Schmidt <stefan@datenfreihafen.org>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        David Ahern <dsahern@kernel.org>,
        Steffen Klassert <steffen.klassert@secunet.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Matthieu Baerts <matttbe@kernel.org>,
        Mat Martineau <martineau@kernel.org>,
        Geliang Tang <geliang@kernel.org>, Ralf Baechle <ralf@linux-mips.org>,
        Remi Denis-Courmont <courmisch@gmail.com>,
        Allison Henderson <allison.henderson@oracle.com>,
        David Howells <dhowells@redhat.com>,
        Marc Dionne <marc.dionne@auristor.com>,
        Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
        Xin Long <lucien.xin@gmail.com>, Wenjia Zhang <wenjia@linux.ibm.com>,
        Jan Karcher <jaka@linux.ibm.com>,
        "D. Wythe" <alibuda@linux.alibaba.com>,
        Tony Lu <tonylu@linux.alibaba.com>, Wen Gu <guwen@linux.alibaba.com>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna@kernel.org>, Jeff Layton <jlayton@kernel.org>,
        Neil Brown <neilb@suse.de>, Olga Kornievskaia <kolga@netapp.com>,
        Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
        Jon Maloy <jmaloy@redhat.com>, Ying Xue <ying.xue@windriver.com>,
        Martin Schiller <ms@dev.tdt.de>,
        Pablo Neira Ayuso <pablo@netfilter.org>,
        Jozsef Kadlecsik <kadlec@netfilter.org>,
        Florian Westphal <fw@strlen.de>, Roopa Prabhu <roopa@nvidia.com>,
        Nikolay Aleksandrov <razor@blackwall.org>,
        Simon Horman <horms@verge.net.au>, Julian Anastasov <ja@ssi.bg>,
        Joerg Reuter <jreuter@yaina.de>, Luis Chamberlain <mcgrof@kernel.org>,
        Kees Cook <keescook@chromium.org>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, dccp@vger.kernel.org,
        linux-wpan@vger.kernel.org, mptcp@lists.linux.dev,
        linux-hams@vger.kernel.org, linux-rdma@vger.kernel.org,
        rds-devel@oss.oracle.com, linux-afs@lists.infradead.org,
        linux-sctp@vger.kernel.org, linux-s390@vger.kernel.org,
        linux-nfs@vger.kernel.org, tipc-discussion@lists.sourceforge.net,
        linux-x25@vger.kernel.org, netfilter-devel@vger.kernel.org,
        coreteam@netfilter.org, bridge@lists.linux.dev,
        lvs-devel@vger.kernel.org
Subject: Re: [PATCH v5 4/8] net: sunrpc: Remove the now superfluous sentinel
 elements from ctl_table array
Message-ID: <ZiulDWkL/9UJl+8K@tissot.1015granger.net>
References: <20240426-jag-sysctl_remset_net-v5-0-e3b12f6111a6@samsung.com>
 <20240426-jag-sysctl_remset_net-v5-4-e3b12f6111a6@samsung.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240426-jag-sysctl_remset_net-v5-4-e3b12f6111a6@samsung.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?zoJ1SGfaiKySG9ku7QBm69Kc5WlSVMUgmgeiBMEhImHDku/AYco+EU6cOjxl?=
 =?us-ascii?Q?bq7W7YF6MtDXjz2Wt/T7QRMa7RBVPA8IOpw+01Vse+xHYNIUfwS7xKq5gAC0?=
 =?us-ascii?Q?RzG+9haN2MXBGvB7SkXCyrEgfmkKmu+8yVzmzg7OpKW+cB4M9tudUzPh3Vci?=
 =?us-ascii?Q?k2rbdN+4EsAa9YydBC9BGSgo6FQLR+XBW1FT7zAWDuXcGt7HHtv4cLIQrSVq?=
 =?us-ascii?Q?rdqkjbfXuBAuE+6sRw1jLWPOxENSThwn8jrNyYKL0jZDlaTWv3DBK9GPrUqx?=
 =?us-ascii?Q?meGchp5UmiL90VVPzS6eu7gesGoLyiYWnS8jpd0UOJlb52O7FlPj/W442m1u?=
 =?us-ascii?Q?hDPZjuJsWLppDsCCde+8eu0ukZojZrSrFJnpvUsxG1bL2v2zrF60Ok1YaCGn?=
 =?us-ascii?Q?CdnSYn37io3hKlz0oriFNQCxNFuGnp313Xixl2BPIj51KAU55Zqy2LTQi6da?=
 =?us-ascii?Q?o6l45xbLrnaq7g7gC+53qCtygH2+tWWy7zZhCnHb/Em2wgT7BoIwXzpY7+RV?=
 =?us-ascii?Q?veYXrWQSAnGY1hkMOoZlvpMbeCJRaP9lW41xEHPCJE2GRsgqKwYUWx5ZdbBY?=
 =?us-ascii?Q?4cFJmsLyoxYxgzLRkLeraBTMQwdIIYGht4Euqf59cBRbj7uAiPGazLy+exoO?=
 =?us-ascii?Q?p1ZsmPRYXDXe1OgDc5neQV5tDxUw2BZUf1uSC+l6bMdcPE41rUjF6eci04d2?=
 =?us-ascii?Q?80p+Tu83J9mydadYapHuugAxmv6NW0MT8HdevHMNvWaanYRn136mIOdf+7Kt?=
 =?us-ascii?Q?dZNYEpeAnjtKzC2w0shvb0lxIEofPcJ1CqqOMwbWWV/Vh05HAyvZXjZHGw1g?=
 =?us-ascii?Q?NzDS838U2Flrq8cfVlKH4ml5oO0MIUb1MGjEE/0V07RRtibB8WIauNXAgD1c?=
 =?us-ascii?Q?/a8Mk0LcdOlE4T0038HQijYYf3IIfx4YrFmbiu/cNd8fXbRBUG4EvoqHr8ls?=
 =?us-ascii?Q?aWwS22Cubp8KxKol5q7gcyHszIbXzFeDmjtNNtdFgQudR8CBkVhKtzqTgAHq?=
 =?us-ascii?Q?cYHzdwhr9sqqBw8LWzGgmFMToMlu5l2L7z20ycQh5rFqsVg+mL98lEc1V2yi?=
 =?us-ascii?Q?55Ut5H67SZNgS++S8ezvgPPGzWmRC71oANtQKk0NOLBP+LUcsCv5dkfxyurn?=
 =?us-ascii?Q?aFG1TSPGOkNcErIj0NC+kH0BbyyYVn0KDBzqWiCALjC18aLSDaR7+IWf4ILv?=
 =?us-ascii?Q?ewjlLyObmsPkKFHSIaWZ7Sy5L0GT4cDLjRCkVtlYsbMFftyboOEryUghiJ7p?=
 =?us-ascii?Q?Z3haL6MlylkteAHxfcEHbWQ68eFu/Xk18DDqwWi+Japvzhd9arEj8bmNgvSr?=
 =?us-ascii?Q?r8eLcyvSaVBjohlViJEWIys7AQK/5+f8NIFAomPrGgmDKOsrNFG1vV+wYSYY?=
 =?us-ascii?Q?2qOuxnnpta0eIMAGVzvg7qnsnARFD9vj3NyOL+328HFFhNn7VtPhRGL1Ow2a?=
 =?us-ascii?Q?h8mSyBhsMwFKbpf6ufjn4Z6IydWJAKLXy28PkGAcRW+VTbg/jxYiS1685zZz?=
 =?us-ascii?Q?oF0WcrWRRBt/IpWVZy72mTsWtWRTd7vMcTGUv02L750u6Lv/kX9IwEwq9++b?=
 =?us-ascii?Q?c1YLpXGbUL4pIDZ9c9bPH5QlpgkSf3XD4ZZrAQVaTfM1lu2es39JNISwfZ0P?=
 =?us-ascii?Q?VQ=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	JXj8JqHN8RpLs5ZhuVvVutVL3qZvKjz+7MQcehGsoFG3N0U9ol3KimfSnr+E2WAPNfwe8+RBJCWzHZFmsYwdFn1FcsWSnR0g6gqkOygggKkSDRvg1qM7Pjrm+rbyA1RFcXU8HMVAgB9Pjb8oYUH5q/s0EVtdDhzaqyuhgzkwOmnMt2GKwkHJ4Zm+T5tDcp55NSoXGORBmkLf7La2JYF3hVEghsFTd46e7QHbFPFzjenWsp3BOvPMR3bGUjuWoAf1FEVatZC2+LIOfudp745Nd4yoDNetCL/rdNVZcWrvolW+edxzVU8jFk3IIuJ0By4lQ1IOLqJ/CDTZbG1f3AELbQ3xQy5d5IU8Pg4TiuOqK0Wy2tBWsApb0wVr+Yesukh4MTcCCXCDu+WFZBEabYcDavi97/9qdUHMZYWQbtDoqbtOwj7dyvT7z7WCFu8/AfyuSp5rFA3fSoVW63Mr+0Ewr0iggu7pmnBKCor+RWCUhM4RKF+orT/TpkvWkQmRwo/Q0wRE68IkcofWpvBJfbLMchWJHP8lIAfcwnZlrXMuwCsyskMIPYG/K/WQT+Pe7b4ubLsx/Dt0SIAzK1vYD7lhBaLkBFkQerltyDIRwiXCOrc=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2e9122e5-c8d2-4457-041b-08dc65f0a364
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2024 12:58:58.8917
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HIZMAJ3mBmIqCo0/sEPZKBmw9kVufrlLoxFRgfOuYF8caBTEC6sUCdjXCCDNmwdstU0vL5SCAxpicJxkk7WNwQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB4953
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-04-26_12,2024-04-26_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 mlxscore=0 phishscore=0 spamscore=0 adultscore=0 bulkscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2404260086
X-Proofpoint-GUID: dP7RSDXkZ3DMn6wkxOpoTwe6fxfLIUgJ
X-Proofpoint-ORIG-GUID: dP7RSDXkZ3DMn6wkxOpoTwe6fxfLIUgJ

On Fri, Apr 26, 2024 at 12:46:56PM +0200, Joel Granados via B4 Relay wrote:
> From: Joel Granados <j.granados@samsung.com>
> 
> This commit comes at the tail end of a greater effort to remove the
> empty elements at the end of the ctl_table arrays (sentinels) which
> will reduce the overall build time size of the kernel and run time
> memory bloat by ~64 bytes per sentinel (further information Link :
> https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/)
> 
> * Remove sentinel element from ctl_table structs.
> 
> Signed-off-by: Joel Granados <j.granados@samsung.com>
> ---
>  net/sunrpc/sysctl.c             | 1 -
>  net/sunrpc/xprtrdma/svc_rdma.c  | 1 -
>  net/sunrpc/xprtrdma/transport.c | 1 -
>  net/sunrpc/xprtsock.c           | 1 -
>  4 files changed, 4 deletions(-)
> 
> diff --git a/net/sunrpc/sysctl.c b/net/sunrpc/sysctl.c
> index 93941ab12549..5f3170a1c9bb 100644
> --- a/net/sunrpc/sysctl.c
> +++ b/net/sunrpc/sysctl.c
> @@ -160,7 +160,6 @@ static struct ctl_table debug_table[] = {
>  		.mode		= 0444,
>  		.proc_handler	= proc_do_xprt,
>  	},
> -	{ }
>  };
>  
>  void
> diff --git a/net/sunrpc/xprtrdma/svc_rdma.c b/net/sunrpc/xprtrdma/svc_rdma.c
> index f86970733eb0..474f7a98fe9e 100644
> --- a/net/sunrpc/xprtrdma/svc_rdma.c
> +++ b/net/sunrpc/xprtrdma/svc_rdma.c
> @@ -209,7 +209,6 @@ static struct ctl_table svcrdma_parm_table[] = {
>  		.extra1		= &zero,
>  		.extra2		= &zero,
>  	},
> -	{ },
>  };
>  
>  static void svc_rdma_proc_cleanup(void)
> diff --git a/net/sunrpc/xprtrdma/transport.c b/net/sunrpc/xprtrdma/transport.c
> index 29b0562d62e7..9a8ce5df83ca 100644
> --- a/net/sunrpc/xprtrdma/transport.c
> +++ b/net/sunrpc/xprtrdma/transport.c
> @@ -137,7 +137,6 @@ static struct ctl_table xr_tunables_table[] = {
>  		.mode		= 0644,
>  		.proc_handler	= proc_dointvec,
>  	},
> -	{ },
>  };
>  
>  #endif
> diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
> index bb9b747d58a1..f62f7b65455b 100644
> --- a/net/sunrpc/xprtsock.c
> +++ b/net/sunrpc/xprtsock.c
> @@ -160,7 +160,6 @@ static struct ctl_table xs_tunables_table[] = {
>  		.mode		= 0644,
>  		.proc_handler	= proc_dointvec_jiffies,
>  	},
> -	{ },
>  };
>  
>  /*
> 
> -- 
> 2.43.0
> 

Acked-by: Chuck Lever <chuck.lever@oracle.com>


-- 
Chuck Lever