Received-SPF: pass (google.com: domain of linux-nfs+bounces-3037-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Fri, 26 Apr 2024 09:02:49 -0400
From: Chuck Lever <chuck.lever@oracle.com>
To: Guoqing Jiang <guoqing.jiang@linux.dev>
Cc: trond.myklebust@hammerspace.com, anna@kernel.org, jlayton@kernel.org,
        neilb@suse.de, kolga@netapp.com, Dai.Ngo@oracle.com, tom@talpey.com,
        linux-nfs@vger.kernel.org
Subject: Re: [PATCH] SUNRPC: Remove comment for sp_lock
Message-ID: <Ziul+ayuzihVx67v@tissot.1015granger.net>
References: <20240426034750.26945-1-guoqing.jiang@linux.dev>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240426034750.26945-1-guoqing.jiang@linux.dev>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?8y6NtDml6vK80TLVt2+yg/Fr9Vsns2s7m93onEUyImQVcYIhSAw9zL4yoX3f?=
 =?us-ascii?Q?Hi6MTZ3uQ2xQtseD41X1k2GAmdQddgpMZpMRpc9wyI2xLZY4022KTtqXaUVX?=
 =?us-ascii?Q?2iU29CqYkYGoDGjnLLuWk7eKkKwT0FloYyGcNtv7OE+Ft7juaLvHyBNw55HA?=
 =?us-ascii?Q?S9REBE22F0WoD8GcpRBD9yN8G+ZAb/kvl0a9WeLTO5myPranzBQLxN4uclUA?=
 =?us-ascii?Q?MMjsHTnW2GkT+ItkUIW+DzTy+kQkQiVk3Dg6sFzsLXOEzsWwHHJgj8CYomtA?=
 =?us-ascii?Q?IOV4izEByQFkdW3ygkZpJHAhwpnucXUXDp7wNSFbwtJAe/p7TyAFRztMHfb4?=
 =?us-ascii?Q?KLH5ypBk1Z0qGDy1WUgHAGkgxzwQMhYHfhYWhhZrZV0CKFM+ma6MtpN+Mqw1?=
 =?us-ascii?Q?exn1K8Txa1lQhf+e+kykXVoCr2AQSw8IrPeUW781igc13EfdUGWZsyoHM/wT?=
 =?us-ascii?Q?S8+LRI1BXVgbXJSuYwCnHwqGRBuD8ZLP9HN7TAElwumrzOOXDxB/LE4fSgqo?=
 =?us-ascii?Q?J2uybQSMcJdYo+CTb74nluCpY0gFc6QoMnEWOFa6dovRw2RgYpJX87gHzR6f?=
 =?us-ascii?Q?DEniCIwrGqeKm+Wb+/YNIeXxIhUnPs1xjZrjO9VQhC1zlYuMDD0EZZyL3xQG?=
 =?us-ascii?Q?mrulmBdeGRp9ty77maB7S66Qob/3XtPu6UcXSQuRD1U4JT6FBDEk4Var2FiH?=
 =?us-ascii?Q?zeFoM4AP0ccGC8Wl7IEdi10V/RBJDfwOW2wXRLqOuw9H5gcr2YEjiLJyjC7f?=
 =?us-ascii?Q?bHckCs/WWhWzxUjvSY4Prra5irGYU2pu1+add5eqgbYP5aYltonXSfnB0RZi?=
 =?us-ascii?Q?LHfIarZ4Qzr67Gy2gEhNEga+JOYdPElV1GpMC4bdsIi6bc5+045++s+tQuUG?=
 =?us-ascii?Q?bqtOgunZZtbEeMLUwiPy2U+TaBd0GUDSwVApcHaTP0TXIx6hVBkS1DQ+OWnw?=
 =?us-ascii?Q?RwLZMFEJKGy3IFDqA0Z08TL38gz/MIsxK35KvEudzdFA9F2YXIjVWo3isBkl?=
 =?us-ascii?Q?9bxir2rqWrfL9Ppszqp0ktr7yN3Mkzmvssmpf/4ru3hml0432BvoZvRxktAH?=
 =?us-ascii?Q?Y0MeQqB31l3VMPE2EYrGU2+u/r5otwxeSrJVXYrEpe/6pdjKfGuzEF+9rFQ+?=
 =?us-ascii?Q?RmIo0SddneslTYakVRrvUFMemvAHaugDlR1c2OnSn2Y0N8jOx/US9r6h59pl?=
 =?us-ascii?Q?yhLYoPcL7MivmioWStIUPc6zEeF4aLpGRDXeraPvU40O1Sf/NpgGgW0Pt3ah?=
 =?us-ascii?Q?x3R6g2zTXEEr+0+hf7Q2Xx8qiVqlciAMKLOn6LMZxhwRvD8+khqCmOnBuVtz?=
 =?us-ascii?Q?AOrZLpkWEeKOsKFndEuhcI9KK94kTinw93ybIWRiLtBqoazQ+0lwwed7++0x?=
 =?us-ascii?Q?JFGy0j12DboZeojxcu7BWguEYVIsF0jGmwLWubNZn/tOqDQ6I4E1FJzKeCiU?=
 =?us-ascii?Q?0rr+Ww3bBboUtyJvzMc6nfNan3ihl2H2Gu8bn2HAqxTxfT3JYJXWggpfNsCq?=
 =?us-ascii?Q?nyqP+ZrCxrAvvacykkhDUyZ/MbuLlKKcUpp46EsHjP6aPlftSE1Izm4Zh8Ng?=
 =?us-ascii?Q?Gwcq00q2v6/uz1PjsilzpXH41yo4/o+2vzER72adEEwG7AhmdpFl7JqwDvRB?=
 =?us-ascii?Q?kg=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	R9Qi3qTmouCnqgpv6R1gOMFMr4/1e7cgXVcDVrcDT9kDva5zWeLcMiusp5+Pu+KJiqH7Cjsp0BlGYZo5KPCVJXQ/AjBMxlMoiW7LqP6hveJObg/5xGgoRENS29Xi6r09S0zQccdR/NmaHXrpuEpe597xPOT9FMJSjGh7AwD5aJLjL2GJT3UcuAQwAeUgeQMZmFxaEFO6QC5pyA6wzdj/BNGv4b+norH9tWo9W71tjo8wK/PzbG3UmLAxWKTwrCNlqS5J0MtPs9p2/ydyxVEEQGfZsXvpfG9/i6aKb9S04d7OCIY6+SVzT7KD/CH1inUJGgNANKiwQwel6N7q1ujEVoQ8QUW0YpkIZ/GsjpApcTxGYWJK6yLhtcDAWRSStOjA9K7t/FvCdQyTQku6+W3o8U3/iKBm9HNltfHP1UUs5y+rw2651meQXzYU+um/ClwUWbWyxRBcE86fpj64xBTrn/RIhYWYnX18ZR4zzVOozG1/rIbIFmTDey7uIeG1KtMZBDh1IQnETmEmMDxEMBu/HaOaq5KeVXsxejOGVRHHCWeSg3bXlB/e6LCeAkn30avOEVymfhh2UbbdymXcAIoKSioTx6zown78DRp2zyAz8+k=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d0e2d1c4-ed7a-4796-af21-08dc65f12e5e
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2024 13:02:52.0863
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: retzKSrRSZCbGSsUhBZ7jCDc/H4kA9QMcCnHQispYPOrHCxzndAHUOOowTIKPWe0Nym4d8PM52E50qPZY9y1xQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4408
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-04-26_12,2024-04-26_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=903
 bulkscore=0 mlxscore=0 suspectscore=0 adultscore=0 malwarescore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2404260086
X-Proofpoint-GUID: NeKsoGiLazaajRWuSZJ8Hha3UHoi-WBF
X-Proofpoint-ORIG-GUID: NeKsoGiLazaajRWuSZJ8Hha3UHoi-WBF

On Fri, Apr 26, 2024 at 11:47:50AM +0800, Guoqing Jiang wrote:
> It is obsolete since sp_lock was discarded in commit 580a25756a9f
> ("SUNRPC: discard sp_lock").
> 
> Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev>
> ---
>  net/sunrpc/svc_xprt.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c
> index b4a85a227bd7..ec78c277a02e 100644
> --- a/net/sunrpc/svc_xprt.c
> +++ b/net/sunrpc/svc_xprt.c
> @@ -46,7 +46,6 @@ static LIST_HEAD(svc_xprt_class_list);
>  
>  /* SMP locking strategy:
>   *
> - *	svc_pool->sp_lock protects most of the fields of that pool.
>   *	svc_serv->sv_lock protects sv_tempsocks, sv_permsocks, sv_tmpcnt.
>   *	when both need to be taken (rare), svc_serv->sv_lock is first.
>   *	The "service mutex" protects svc_serv->sv_nrthread.
> -- 
> 2.35.3
> 

Applied to nfsd-next (for 6.10). Thank you!


-- 
Chuck Lever