Received-SPF: pass (google.com: domain of linux-nfs+bounces-3047-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 29 Apr 2024 11:10:05 +0200
From: Joel Granados <j.granados@samsung.com>
To: Sabrina Dubroca <sd@queasysnail.net>
CC: Joel Granados via B4 Relay <devnull+j.granados.samsung.com@kernel.org>,
	"David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Alexander
	Aring <alex.aring@gmail.com>, Stefan Schmidt <stefan@datenfreihafen.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>, David Ahern <dsahern@kernel.org>,
	Steffen Klassert <steffen.klassert@secunet.com>, Herbert Xu
	<herbert@gondor.apana.org.au>, Matthieu Baerts <matttbe@kernel.org>, Mat
	Martineau <martineau@kernel.org>, Geliang Tang <geliang@kernel.org>, Remi
	Denis-Courmont <courmisch@gmail.com>, Allison Henderson
	<allison.henderson@oracle.com>, David Howells <dhowells@redhat.com>, Marc
	Dionne <marc.dionne@auristor.com>, Marcelo Ricardo Leitner
	<marcelo.leitner@gmail.com>, Xin Long <lucien.xin@gmail.com>, Wenjia Zhang
	<wenjia@linux.ibm.com>, Jan Karcher <jaka@linux.ibm.com>, "D. Wythe"
	<alibuda@linux.alibaba.com>, Tony Lu <tonylu@linux.alibaba.com>, Wen Gu
	<guwen@linux.alibaba.com>, Trond Myklebust
	<trond.myklebust@hammerspace.com>, Anna Schumaker <anna@kernel.org>, Chuck
	Lever <chuck.lever@oracle.com>, Jeff Layton <jlayton@kernel.org>, Neil Brown
	<neilb@suse.de>, Olga Kornievskaia <kolga@netapp.com>, Dai Ngo
	<Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>, Jon Maloy
	<jmaloy@redhat.com>, Ying Xue <ying.xue@windriver.com>, Martin Schiller
	<ms@dev.tdt.de>, Pablo Neira Ayuso <pablo@netfilter.org>, Jozsef Kadlecsik
	<kadlec@netfilter.org>, Florian Westphal <fw@strlen.de>, Roopa Prabhu
	<roopa@nvidia.com>, Nikolay Aleksandrov <razor@blackwall.org>, Simon Horman
	<horms@verge.net.au>, Julian Anastasov <ja@ssi.bg>, Joerg Reuter
	<jreuter@yaina.de>, Luis Chamberlain <mcgrof@kernel.org>, Kees Cook
	<keescook@chromium.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <dccp@vger.kernel.org>,
	<linux-wpan@vger.kernel.org>, <mptcp@lists.linux.dev>,
	<linux-hams@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
	<rds-devel@oss.oracle.com>, <linux-afs@lists.infradead.org>,
	<linux-sctp@vger.kernel.org>, <linux-s390@vger.kernel.org>,
	<linux-nfs@vger.kernel.org>, <tipc-discussion@lists.sourceforge.net>,
	<linux-x25@vger.kernel.org>, <netfilter-devel@vger.kernel.org>,
	<coreteam@netfilter.org>, <bridge@lists.linux.dev>,
	<lvs-devel@vger.kernel.org>
Subject: Re: [PATCH v5 5/8] net: Remove ctl_table sentinel elements from
 several networking subsystems
Message-ID: <20240429091005.rl5fg42dtpiqdha2@joelS2.panther.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="7yt4vfjhttuopq7n"
Content-Disposition: inline
In-Reply-To: <ZivEOtGOWVc0W8Th@hog>
CMS-TYPE: 201P
References: <20240426-jag-sysctl_remset_net-v5-0-e3b12f6111a6@samsung.com>
	<20240426-jag-sysctl_remset_net-v5-5-e3b12f6111a6@samsung.com>
	<CGME20240426151357eucas1p15ffbd34b12f74980e6a75a797a322030@eucas1p1.samsung.com>
	<ZivEOtGOWVc0W8Th@hog>

--7yt4vfjhttuopq7n
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 26, 2024 at 05:13:37PM +0200, Sabrina Dubroca wrote:
> 2024-04-26, 12:46:57 +0200, Joel Granados via B4 Relay wrote:
> > diff --git a/net/smc/smc_sysctl.c b/net/smc/smc_sysctl.c
> > index a5946d1b9d60..bd0b7e2f8824 100644
> > --- a/net/smc/smc_sysctl.c
> > +++ b/net/smc/smc_sysctl.c
> > @@ -90,7 +90,6 @@ static struct ctl_table smc_table[] =3D {
> >  		.extra1		=3D &conns_per_lgr_min,
> >  		.extra2		=3D &conns_per_lgr_max,
> >  	},
> > -	{  }
> >  };
>=20
> There's an ARRAY_SIZE(smc_table) - 1 in smc_sysctl_net_init, shouldn't
> the -1 be removed like you did in other patches?
>=20
>=20
> int __net_init smc_sysctl_net_init(struct net *net)
> {
> 	struct ctl_table *table;
>=20
> 	table =3D smc_table;
> 	if (!net_eq(net, &init_net)) {
> 		int i;
>=20
> 		table =3D kmemdup(table, sizeof(smc_table), GFP_KERNEL);
> 		if (!table)
> 			goto err_alloc;
>=20
> 		for (i =3D 0; i < ARRAY_SIZE(smc_table) - 1; i++)
This is a very good catch !!!! Thx a lot!! I'll put this into my V6.

> 			table[i].data +=3D (void *)net - (void *)&init_net;
> 	}
>=20
> 	net->smc.smc_hdr =3D register_net_sysctl_sz(net, "net/smc", table,
> 						  ARRAY_SIZE(smc_table));
> [...]
>=20
> --=20
> Sabrina
>=20

--=20

Joel Granados

--7yt4vfjhttuopq7n
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmYvY+0ACgkQupfNUreW
QU/otAv9HIGYm6aL0iZA6OnAA8ofA0pI4BIiXrsHkVwfajwHsHry9FPCeEhtmc7j
QuYQNoz9zC1RAQx2Y7C6jNRoMA4YHla4cM3DcI57b5pqdFi8RF0CQw2wb16fHGM7
VZ4dAIAfBWYTpJX/VRAJFw1C03VAzKqw/ovvseztFBdsHvYY0YKvJVK+cUfGpDdq
uMJNHQBf8KM+0IJElRp1Iyj6tG9PQzOt6WcO6DKLI+w7BZEZBF8cHcncciBL/7eQ
6rHfGdpsOfaDQfo0eRkkt29JWE8Qk/bEaxN+XtFIx/IwsMdkiJpeKTlbyN7695Ec
EWHs/7eXApIRuygigPzJL+Jgv5quPu9Q6l6rM6ENt69D9mPSjmk9oU9nNDxvEX8U
BbEcjPUENhNU525lJkOgukqEy0eZBWYwnjORfJgKuIMuZCrn/7FDta6cUJOn6CMc
/uMSewEjnwU1hNcpvGfRmdLx6jMbrq/ypdLfwwuoXS+HIKHjv0z+xyPxy6i8ZFYA
rxq7J46v
=xUgz
-----END PGP SIGNATURE-----

--7yt4vfjhttuopq7n--