Received-SPF: pass (google.com: domain of linux-nfs+bounces-3049-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 29 Apr 2024 11:32:43 +0200
From: Joel Granados <j.granados@samsung.com>
To: Julian Anastasov <ja@ssi.bg>
CC: "David S. Miller" <davem@davemloft.net>, Eric Dumazet
	<edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
	<pabeni@redhat.com>, Alexander Aring <alex.aring@gmail.com>, Stefan Schmidt
	<stefan@datenfreihafen.org>, Miquel Raynal <miquel.raynal@bootlin.com>,
	"David Ahern" <dsahern@kernel.org>, Steffen Klassert
	<steffen.klassert@secunet.com>, Herbert Xu <herbert@gondor.apana.org.au>,
	Matthieu Baerts <matttbe@kernel.org>, Mat Martineau <martineau@kernel.org>,
	Geliang Tang <geliang@kernel.org>, Ralf Baechle <ralf@linux-mips.org>, Remi
	Denis-Courmont <courmisch@gmail.com>, Allison Henderson
	<allison.henderson@oracle.com>, David Howells <dhowells@redhat.com>, Marc
	Dionne <marc.dionne@auristor.com>, Marcelo Ricardo Leitner
	<marcelo.leitner@gmail.com>, Xin Long <lucien.xin@gmail.com>, Wenjia Zhang
	<wenjia@linux.ibm.com>, Jan Karcher <jaka@linux.ibm.com>, "D. Wythe"
	<alibuda@linux.alibaba.com>, Tony Lu <tonylu@linux.alibaba.com>, Wen Gu
	<guwen@linux.alibaba.com>, Trond Myklebust
	<trond.myklebust@hammerspace.com>, Anna Schumaker <anna@kernel.org>, "Chuck
 Lever" <chuck.lever@oracle.com>, Jeff Layton <jlayton@kernel.org>, Neil
	Brown <neilb@suse.de>, Olga Kornievskaia <kolga@netapp.com>, Dai Ngo
	<Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>, Jon Maloy
	<jmaloy@redhat.com>, Ying Xue <ying.xue@windriver.com>, Martin Schiller
	<ms@dev.tdt.de>, Pablo Neira Ayuso <pablo@netfilter.org>, Jozsef Kadlecsik
	<kadlec@netfilter.org>, Florian Westphal <fw@strlen.de>, Roopa Prabhu
	<roopa@nvidia.com>, Nikolay Aleksandrov <razor@blackwall.org>, Simon Horman
	<horms@verge.net.au>, Joerg Reuter <jreuter@yaina.de>, Luis Chamberlain
	<mcgrof@kernel.org>, Kees Cook <keescook@chromium.org>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<dccp@vger.kernel.org>, <linux-wpan@vger.kernel.org>,
	<mptcp@lists.linux.dev>, <linux-hams@vger.kernel.org>,
	<linux-rdma@vger.kernel.org>, <rds-devel@oss.oracle.com>,
	<linux-afs@lists.infradead.org>, <linux-sctp@vger.kernel.org>,
	<linux-s390@vger.kernel.org>, <linux-nfs@vger.kernel.org>,
	<tipc-discussion@lists.sourceforge.net>, <linux-x25@vger.kernel.org>,
	<netfilter-devel@vger.kernel.org>, <coreteam@netfilter.org>,
	<bridge@lists.linux.dev>, <lvs-devel@vger.kernel.org>
Subject: Re: [PATCH v5 6/8] netfilter: Remove the now superfluous sentinel
 elements from ctl_table array
Message-ID: <20240429093243.3luxenn3qffruyif@joelS2.panther.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="ism7n6dg7qigbra6"
Content-Disposition: inline
In-Reply-To: <d78c6353-99b9-41f8-0c54-19eb86e1fce3@ssi.bg>
CMS-TYPE: 201P
References: <20240426-jag-sysctl_remset_net-v5-0-e3b12f6111a6@samsung.com>
	<20240426-jag-sysctl_remset_net-v5-6-e3b12f6111a6@samsung.com>
	<CGME20240426121030eucas1p111f2e449982e47627d8efd9c9782990d@eucas1p1.samsung.com>
	<d78c6353-99b9-41f8-0c54-19eb86e1fce3@ssi.bg>

--ism7n6dg7qigbra6
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 26, 2024 at 03:09:45PM +0300, Julian Anastasov wrote:
>=20
> 	Hello,
>=20
> On Fri, 26 Apr 2024, Joel Granados via B4 Relay wrote:
>=20
> > From: Joel Granados <j.granados@samsung.com>
> >=20
> > This commit comes at the tail end of a greater effort to remove the
> > empty elements at the end of the ctl_table arrays (sentinels) which will
> > reduce the overall build time size of the kernel and run time memory
> > bloat by ~64 bytes per sentinel (further information Link :
> > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/)
> >=20
> > * Remove sentinel elements from ctl_table structs
> > * Remove instances where an array element is zeroed out to make it look
> >   like a sentinel. This is not longer needed and is safe after commit
> >   c899710fe7f9 ("networking: Update to register_net_sysctl_sz") added
> >   the array size to the ctl_table registration
> > * Remove the need for having __NF_SYSCTL_CT_LAST_SYSCTL as the
> >   sysctl array size is now in NF_SYSCTL_CT_LAST_SYSCTL
> > * Remove extra element in ctl_table arrays declarations
> >=20
> > Acked-by: Kees Cook <keescook@chromium.org> # loadpin & yama
> > Signed-off-by: Joel Granados <j.granados@samsung.com>
> > ---
> >  net/bridge/br_netfilter_hooks.c         | 1 -
> >  net/ipv6/netfilter/nf_conntrack_reasm.c | 1 -
> >  net/netfilter/ipvs/ip_vs_ctl.c          | 5 +----
> >  net/netfilter/ipvs/ip_vs_lblc.c         | 5 +----
> >  net/netfilter/ipvs/ip_vs_lblcr.c        | 5 +----
> >  net/netfilter/nf_conntrack_standalone.c | 6 +-----
> >  net/netfilter/nf_log.c                  | 3 +--
> >  7 files changed, 5 insertions(+), 21 deletions(-)
>=20
> ...
>=20
> > diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_=
ctl.c
> > index 143a341bbc0a..50b5dbe40eb8 100644
> > --- a/net/netfilter/ipvs/ip_vs_ctl.c
> > +++ b/net/netfilter/ipvs/ip_vs_ctl.c
>=20
> ...
>=20
> > @@ -4286,10 +4285,8 @@ static int __net_init ip_vs_control_net_init_sys=
ctl(struct netns_ipvs *ipvs)
> >  			return -ENOMEM;
> > =20
> >  		/* Don't export sysctls to unprivileged users */
> > -		if (net->user_ns !=3D &init_user_ns) {
> > -			tbl[0].procname =3D NULL;
> > +		if (net->user_ns !=3D &init_user_ns)
> >  			ctl_table_size =3D 0;
> > -		}
> >  	} else
> >  		tbl =3D vs_vars;
> >  	/* Initialize sysctl defaults */
>=20
> 	We are in process of changing this code (not in trees yet):
>=20
> https://marc.info/?t=3D171345219600002&r=3D1&w=3D2
>=20
> 	As I'm not sure which patch will win, the end result should
> be this single if-block/hunk to be removed.
Thx for the heads up. I have made a note of it in case this set ends up
being after yours.


>=20
> Regards
>=20
> --
> Julian Anastasov <ja@ssi.bg>
>=20

--=20

Joel Granados

--ism7n6dg7qigbra6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmYvaToACgkQupfNUreW
QU+SSwv+L+03hxc8J2P/i5B1B0mUQVpmedwuNIg1F6QSEgnsIAQzagQUlBPPFYhC
9+gNBsEpUMPb2PVXyRXpd3QQm0XPgv43A38qO27lQYg1VPpf+zpzosrvz0lJaoo/
BesbgCri6d6bPmpgGfq4BuYWksB0jvU/Ci63m7Qz5wKcG5hM0G7jEHggHJkz8BWP
8i4SO8Fwb0pbbd7Hwqb1hUJd1uk+coHhyknMfIwmVFPPTN9C1COJFgFE9YiCT9zq
9L1d/uWcu0n9sB7MzW93vrPrMYZ1xeIvWrYwXI05Wr3FnTYXGhSpnZcMUN7rHorj
EQv06C97YKmL3HiTPcIxtxGxjG1v3U+RZZ49wxo56yiNPT/kECnkTFT+7GxJ+/4d
HkB8WMPpqP6PRbPNLJdm94ynbyi8N6+4fgscCSLRuAeiyVqNGXmvLsY3NZWJmpGl
UBeeGwtDSjq9oVM5y9hiKeBbljcUbPpBiHZIuZ0qvm/P02md5XTdbdRJEYjMpxjq
LcjGNoOh
=+2c9
-----END PGP SIGNATURE-----

--ism7n6dg7qigbra6--