Received-SPF: pass (google.com: domain of linux-nfs+bounces-3120-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Chuck Lever III <chuck.lever@oracle.com>
To: Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Linux-XFS
	<linux-xfs@vger.kernel.org>
Subject: possible circular locking dependency detected
Thread-Topic: possible circular locking dependency detected
Thread-Index: AQHam+dPiFSo7JS0g0+BFFeRGi0+eg==
Date: Wed, 1 May 2024 16:47:53 +0000
Message-ID: <A5C74A44-3B8C-4A0D-A86A-90484DE8A6C2@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?OyWaFe+8wxvqM+Ft6Zcf1sLNiMJFpNSR63mi6bXcf15GhI6Y/aRkuX2CmE/p?=
 =?us-ascii?Q?XtVPU+99vRH2FykbNHt/KlHpZw2xkgkG8CYOK95RbEnNp30EwSDbl3H98Bvn?=
 =?us-ascii?Q?lwTf+JWG9LYB5kNhcNFwYmqfVuEI5G5doxIc6+3uo8sIj69TcPxQMSsEdlo/?=
 =?us-ascii?Q?GoK7oVQQ3gcRzeHuDq5WJF0dDV1wYcMJLjcvzjBP+ALZ4+GNeCfMSfuPvgjM?=
 =?us-ascii?Q?8ZuU7HZupxQNdgSF9f5FyPz5RGeiyRUO/nDwvsqepJn2yUCj3GrgN98qdXwX?=
 =?us-ascii?Q?K7PMRML1/lGRfG0n8L956jYf7JvF2+Zw0biJH/9zSuzo1p+CZbLoXNgjYWkK?=
 =?us-ascii?Q?wG5rnl7MvFNuWhAHQyAL4vVQSWSt4xDt0lWbSQ6HOH8cuh5RLLiR7HuH1tPn?=
 =?us-ascii?Q?RsiZwe9z7rHmDtKG+v91mDdS12lbk56V+jRJh2zaaAeZGPSkVoe6/QJqy8Bh?=
 =?us-ascii?Q?Br7IS95f29GgrjSucj+RRqIDq/Ourbj/S/2TfRgHHf+S8fnD9AjMIZLNJEoq?=
 =?us-ascii?Q?K9dHgn46xK5Z6X2FzfqTw0SE+rHNlW8vt99cYnCMpQn1S8QgxUlxTBWYE1Zp?=
 =?us-ascii?Q?Mcits+s7OjFyS1v0w9yT6nNRWLIWZkY/JMJjYNv5dSTGpkQxb57smCteq/2r?=
 =?us-ascii?Q?8+cm/aRuT91xVOsbayx6QJUBcFoNuYSYMAlgSILjPPXkHrDmKPx0kr+gybLK?=
 =?us-ascii?Q?vaiDO9es0xMU7oEeYM05MkUmw2IKjFZN7LiAz3GkFVn2/s6YvMMTdWhju2wU?=
 =?us-ascii?Q?8FGxiVga6llQIg3PPnX6gIAZPSsW2X8x4k2+Jg6r66ZljHKzgnE9wumFDXjy?=
 =?us-ascii?Q?4ofIPikDilG+XT7toDeNJZpr4JoGILXoau5VoVEIh/SlrshXJv86yEzBDFT1?=
 =?us-ascii?Q?yJncJE6QQdt7rZP0zCBXZoZ7r6PVu4KCyOKgtVeNecJ2lXJWJu7aO+6CqodH?=
 =?us-ascii?Q?qGamIP9J4Et53/0781xpQFOU1HUqgormHcCMWGVCZp5z4/RXTYaT2gFOeDBt?=
 =?us-ascii?Q?ldEDZliqwDJW/3ZktfPxEcOJAX0FCB6NYTS1C6Mf/pGDkHhavsY8nPF8GqDV?=
 =?us-ascii?Q?I0EzPwuLj/K46bvGvl0bKAKDa+tK5fZNRHP9i/J6v5FWWFxwTLjLdM87jGUi?=
 =?us-ascii?Q?DSCq0tFDSagxE7Pb4aYz+VcI0Vy0sTHSfYjAugXYSwFk/tTUWeiDsztuu2SQ?=
 =?us-ascii?Q?7KxfKAxjSFm3mLp7Dhwx0Qk32gPlL7Z4/mlnl7jt/ZgFxjwefiCcnA2xIyF5?=
 =?us-ascii?Q?l+DTM3m79PR/QU76KqRBtyeFBpZ3cTtFXRzqRgrTo4wt4Di2vKhyMoQCABeq?=
 =?us-ascii?Q?kZakf8l6qyC9xgWeYJC61g3S7t9JVWW43r04Yj6kMq1TCAw59P4M//gnoTij?=
 =?us-ascii?Q?bAAA4sz/0E5ImoSfhF3gvUc1TC1WqB9a+ncrA9LZk7qDEJbrIoYvrn742iLQ?=
 =?us-ascii?Q?Liy+OXNtE3LkwBF218npPGCC+a7EwUIaGRmu+IqNtvl/GNqB8yse6RCBjUvD?=
 =?us-ascii?Q?Ya4EnrQJauFhs3/nOsElXs0JnOM/RYIDJJi2px58aS8QL1K7GbNMnlkpnlvV?=
 =?us-ascii?Q?LTIFYnecijuhc5d8nNGaPq3bf/S+lLu+6q0DZwwCPvZxTyAWh55uUQega5MQ?=
 =?us-ascii?Q?Xw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <8E891DDCD44A6141B4C796395A752FD1@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-nfs@vger.kernel.org
List-Id: <linux-nfs.vger.kernel.org>
List-Subscribe: <mailto:linux-nfs+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-nfs+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	+O7w0JMUyV4g5b2G3wTed2+qck9CHrckt2FJJXLnIxtPows/Kfglf1Bw2/T7pTNx/74LXAYxDrJu3GbiqKsHN0c8vJupeOjfzh2Fev+oexl1eKN65uZNVcKdKBswDNArbdWU3+AHYOIR2qJp0yO+1lSTxqA2M4sTYgT+iIP4B+tD0eYRBrBSXCy+2ySmbeazjgRzj2nM4YhDOffQ8Fiwthhj2jnQCyCa0gqBbe+jlwQG1QhnwzuvsZHqiWKqw7SALAbAfLCgorZK4v5+C0OmlvLMqemZKuWHc4VCwzZMSEovQ2GYv43s/iKUZJOAyO5qoe5sQcXYxEeVV8RKyvj1tvS/EZndYn/sG6x6VE/yaFZ6D21XtfnK1eMNAdwwZVnIMCSSBv93/H5SlbA6v2x9UXW44+rHZa9beKz9fqHfwDJAWv5JqQSR0v5Y+3B6GzxY0L1xv0xe5MCC2ljGxCWOAJEXBlsbBsmMnjq4bbYuE72vjPKJFZtRfGucfdx2CDlsA0MUqFJs1zV/uYxviz4+3aLUEnb2Sx8gK6tcbJR400BEQLeeknS81A/nfsCP8ZrzU8WKJ3CbcAwFvHd/3OTkjvpIFk82j9tfUR9yaKpGhuA=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c720a869-95f1-4871-a953-08dc69fe71bd
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2024 16:47:53.0460
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: T+GJs3f4iQwb15K5v9k41wCr/Xbxv6WsW8cHTAtgwhZoWRX3qNsSlWRgtpdbo3Ms4Q/FQPPm5Hc8HhsowdLDWA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4303
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-01_16,2024-04-30_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0
 mlxlogscore=762 suspectscore=0 mlxscore=0 spamscore=0 adultscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2405010118
X-Proofpoint-ORIG-GUID: 90kEWJiFAr7HGgQsZsMbWx0I4iY6w3h-
X-Proofpoint-GUID: 90kEWJiFAr7HGgQsZsMbWx0I4iY6w3h-

Hi-

Lockdep splat showed up during xfstest on v6.9-rc6:

[10205.014915] WARNING: possible circular locking dependency detected
[10205.016399] 6.9.0-rc6-00022-g06cd86b25b98 #3 Not tainted
[10205.017724] ------------------------------------------------------
[10205.019194] kswapd0/64 is trying to acquire lock:
[10205.020656] ffff88813f60db18 (&xfs_nondir_ilock_class#3){++++}-{4:4}, at=
: xfs_ilock+0x14d/0x3c0 [xfs]
[10205.023544]  [10205.023544] but task is already holding lock:
[10205.024932] ffffffff8deb5420 (fs_reclaim){+.+.}-{0:0}, at: balance_pgdat=
+0x167/0x1530
[10205.027718]  [10205.027718] which lock already depends on the new lock.
[10205.027718]  [10205.029842]  [10205.029842] the existing dependency chai=
n (in reverse order) is:
[10205.031760]  [10205.031760] -> #1 (fs_reclaim){+.+.}-{0:0}:
[10205.033478]        fs_reclaim_acquire+0x111/0x170
[10205.035002]        __kmalloc+0xa9/0x4b0
[10205.036223]        xfs_attr_list_ilocked+0x6f0/0x1540 [xfs]
[10205.038856]        xfs_attr_list+0x1ce/0x260 [xfs]
[10205.040688]        xfs_vn_listxattr+0x102/0x180 [xfs]
[10205.042753]        vfs_listxattr+0x9e/0xf0
[10205.044100]        nfsd_listxattr+0x134/0x250 [nfsd]
[10205.045890]        nfsd4_listxattrs+0x16/0x20 [nfsd]
[10205.047585]        nfsd4_proc_compound+0xe41/0x24e0 [nfsd]
[10205.049477]        nfsd_dispatch+0x258/0x7d0 [nfsd]
[10205.051196]        svc_process_common+0xa88/0x1db0 [sunrpc]
[10205.052934]        svc_process+0x552/0x800 [sunrpc]
[10205.054315]        svc_recv+0x1958/0x2460 [sunrpc]
[10205.055877]        nfsd+0x23d/0x360 [nfsd]
[10205.057315]        kthread+0x2f3/0x3e0
[10205.058524]        ret_from_fork+0x3d/0x80
[10205.059821]        ret_from_fork_asm+0x1a/0x30
[10205.061222]  [10205.061222] -> #0 (&xfs_nondir_ilock_class#3){++++}-{4:4=
}:
[10205.063319]        __lock_acquire+0x3437/0x6e60
[10205.065023]        lock_acquire+0x1ad/0x520
[10205.066444]        down_write_nested+0x96/0x1f0
[10205.067897]        xfs_ilock+0x14d/0x3c0 [xfs]
[10205.071022]        xfs_icwalk_ag+0x885/0x1580 [xfs]
[10205.073093]        xfs_icwalk+0x50/0xd0 [xfs]
[10205.075391]        xfs_reclaim_inodes_nr+0x158/0x210 [xfs]
[10205.077605]        xfs_fs_free_cached_objects+0x5a/0x90 [xfs]
[10205.079657]        super_cache_scan+0x389/0x4e0
[10205.080918]        do_shrink_slab+0x352/0xd20
[10205.082122]        shrink_slab+0x161/0xe40
[10205.083157]        shrink_one+0x3f2/0x6c0
[10205.084218]        shrink_node+0x1f6e/0x35e0
[10205.085322]        balance_pgdat+0x87f/0x1530
[10205.086433]        kswapd+0x559/0xa00
[10205.087399]        kthread+0x2f3/0x3e0
[10205.088673]        ret_from_fork+0x3d/0x80
[10205.090550]        ret_from_fork_asm+0x1a/0x30

I can leave the test NFS server up for a bit if you'd like me to
collect more information.


--
Chuck Lever