Received-SPF: pass (google.com: domain of linux-nfs+bounces-3126-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 2 May 2024 08:57:15 -0400
From: Chuck Lever <chuck.lever@oracle.com>
To: Salvatore Bonaccorso <carnil@debian.org>
Cc: Steve Dickson <steved@redhat.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: Fails to build on =?utf-8?Q?arm{el=2Ch?=
 =?utf-8?Q?f}_with_64bit_time=5Ft=3A_export-cache=2Ec=3A110=3A51=3A_error?=
 =?utf-8?Q?=3A_format_=E2=80=98%ld=E2=80=99_expects_argument_of_type_?=
 =?utf-8?B?4oCYbG9uZyBpbnTigJksIGJ1dCBhcmd1bWVudCA0IGhhcyB0eXBlIOKAmHRp?=
 =?utf-8?B?bWVfdOKAmSB7YWthIOKAmGxvbmcgbG9uZyBpbnTigJl9?= [-Werror=format=]
Message-ID: <ZjONq6cf2MEmVSBK@tissot.1015granger.net>
References: <ZhGfUpXclZeoZ_az@eldamar.lan>
 <A3AAF9FA-95BE-461C-8E7A-C0ED02526519@oracle.com>
 <ZjMd_DCJrV0tHY1K@eldamar.lan>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ZjMd_DCJrV0tHY1K@eldamar.lan>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?QlB2dnRSRm8wcHhlZUNjVnQ1Q0U2Y0ZJWXRZVU9KWGw4bkJwSG0xMU1OUE9n?=
 =?utf-8?B?b1lhTWIrMVU2ZWxkOUg1dytrMmozWGh5SWd6L1hFT21rVVZIOU0wcHZNMzN4?=
 =?utf-8?B?KzBDNlJHYSs1cU9GUEpPOVNDUWJhazJ6TG11d1NaRDBJSFJvVXg5ZkRqTVhQ?=
 =?utf-8?B?bVdyWnl1Ylk2WThIVVZwQWw3SnBaNUdTcGRONXNFMThHVkdoUXlnYUVOZEJK?=
 =?utf-8?B?M2pZQ3QvT3hKbWloSzR2TkY3RmRoRHIraFk3OWs4V0JnWGNkeXk2cUJlVk1Z?=
 =?utf-8?B?eGNvd2RmZjBqMjMvTUZ3djVFeTBualpvVHVuVEVtTnFwR05OcHpXN1VCZlRh?=
 =?utf-8?B?VkQyS0dIMHlpbk9jcGp0ODNtaTk1dEZiVE9IQWM3ZVYzQnFRa2taZUkrajBL?=
 =?utf-8?B?eWtGWU9yS0gzNk9tOU1KTWwvUUY2MnU4YWVCT3VmQXE5d2JIVDhsbVJwTitj?=
 =?utf-8?B?M3cySyt4aEhkQ1FzL050RlZJRXNkUWVmb3JtVG1uR3ZsTWlDVGJRWHRVbGpw?=
 =?utf-8?B?WCtiSEtTeHpEbFRqazRGTVowd0lOQW1GaU80S2R0UXE5czQ5b1NyV3E3bVVK?=
 =?utf-8?B?eXJHQStkMVpwVGc5ZG1OVlhYZ1phMXI1RExzSU1GTlJVcXpvN2pRb1c1V3I1?=
 =?utf-8?B?cXBCQXluUFF1U3dmVitJbGxleWlLSzF1VW1LZnl0ZjVydVE1L0pXenlwWVQ2?=
 =?utf-8?B?ZUR0TjVnMmpyV3plRlF0SEUzakc2WWRwZ2ZNU25GVUJma0pZMlM0UzI4NTJv?=
 =?utf-8?B?MEdEZmIwcWNCUGVtZEE4NzMyODRSWW96eXhlcDl4Z3NscGd1RUdMQnl5L2dl?=
 =?utf-8?B?S25yRk45NmE5ZTNtSTlwWEIzRVBVWWdnYkRyMHFUbmRwU3VGS0ViYTc3REdr?=
 =?utf-8?B?S3V2WXBLRExuLzkwVSszOGV4azNUUGJDZWpXVVJNdDIxdklHbmFmSGNkMVBh?=
 =?utf-8?B?aWdLYzdST1JNWkNFTk4vbVZkVW13eXdwbjQyWG1rTnlJRkpEbGVFbEoxd2h1?=
 =?utf-8?B?WG5jYUt2NHovcjNCUTZlY1BrVjFFS2dEd0l6Nm1nVEdJaEpHbnZ5SzBPQm5L?=
 =?utf-8?B?M1JVcitoWmZQbGdURTBZRzdzRERuZSt5NVNDSEN5RTRtOThweEJ4OXoydnJ4?=
 =?utf-8?B?RnBVd001ZE5EeTREQjZKa3J1aVJFellKRTNsa0RaM0ppb3NoUjEzanJRNERK?=
 =?utf-8?B?SHJEdDJKMDZRY3lWTXkrOTI3SkVWZnp3elBoTE0wWDZTeEhsaFZIZHQrZ3VR?=
 =?utf-8?B?NXJrSVgrNyt4WEFaNHFEbmQ4eXFjazJSN21LbHFlQ1h1SzU5YTlwb3ZRaWxw?=
 =?utf-8?B?MlhHNjJDelBJMHIvbW1YQS9kTkVicFE4eU83ZWQwekR4QmZmRm52UkNiRVdo?=
 =?utf-8?B?TFU1TWZsRndPazRjdGJienhzZUhsNlNqRG8vRWwxaVdvb2VRMFBiUlQ5Y3o1?=
 =?utf-8?B?dkhBS0FHZThoalBvRWpuQWIwSVlydWt6TG5yRW9iWlY0V01wVFRZQkg5eUVX?=
 =?utf-8?B?MEFmcXAwOVg4YlRwMGVoL1l1MWNPdW5IeTc0SCsvbmU2NnhMdElsZ3UzeFEy?=
 =?utf-8?B?MC9iUUlKOXo5cUtHdWhuZk8zOGhESGVCQ3RNZ0NCZU1LMVA0VXFUNlNLL1VT?=
 =?utf-8?B?UnBneENqNmxScENPejRwWWh1TzdZNTE1VGd0dlBTeTJYNWU3dHJMSUpobUZz?=
 =?utf-8?B?Sm5HWElobjlEbENsYjRlMzhEa2dKZWRFS1lralhqSlB0M1BvSEdncEpXWUZs?=
 =?utf-8?B?aEY2Z1BDcTU0YU9NSHBiZStJVmRlVmRwTXBZSHZlN3R4MGIrcmxsUmN2eis1?=
 =?utf-8?B?NVpUWEMvMjFBOEQwQ1pjb2JpWXNVYWV2RjJTMFdXS0ZnWTYvaDhnY3JobzFw?=
 =?utf-8?B?d3J3NGNEVEpUTGxaZE5KZ3lPb3FDZW0xMVN4bjJ4TW5iVXcwbUxpMjBKaDZT?=
 =?utf-8?B?MEdZS1hmbWNMZTJHUGVJLzN6bFZnU1p5YkFBYzlSQU8yejgxNnFQVnEvMUFt?=
 =?utf-8?B?SWxzNk9TWXIybUFwUmpDUzNTOXMxb0U3RDQ1MlFPNE0vMjFkNFhCbTNZWDFE?=
 =?utf-8?B?cWRSLzZyR09JajE1bURJWmZ0QVo2VExicFVLVURESDFxSXJFNU9kc0tySjVV?=
 =?utf-8?B?Q2FIaGtDbEJxVmpBblovOUZBODBGNDFzaWE2cU00VEc3bms2SXphRkVoOVR4?=
 =?utf-8?B?dGc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	zD/h73aQNES64Nd2vz68HdAHWFdCsoS1I1ukhBcARzzGz9dCNW+dv16g9QbmDpg3hjjLU1kw2eWk2v+qXD4Qt938kMVXGACK3COjT6WPC+E16atG3swptSrVa/4wzSRhBsBAtwIjq68Q5irAWd37kpeyHs8Q2++9JyP4L21qBz38J/t2uL3Ifb9hbLq2jymhJYc1wb1EPpbozEBNx2kUNI0tXCXoNTuhpZV2/t2xT4eVH5Ec3wUC3A+51eUrIdFu/B2xu/G+D5qr4uE2lRZk4dKfl1aaF5ntK0IClKS9Tjw+/QOOLFnxHWza0X7V10NiX3y0q1VPmYMyyN8P3Y7xK8x6BatZD3v6ObvvAkkNTucjZKPqiXBhXeIebnbKOXA+OMAuAPFrBo10q4h9uhLYbih+oRBTzOeicYb55JdTce3lXnwj0L42mJqkub6QWmU9PyhjRDVEeQa1UrSgzmrX2eR1oYNS+sU8kx/MoCall28NSl1xlLrsgSsgjnHWq5te2lhaKyD6vrB1tcp9QJZf5ivOTRzHzE+yHDngCQMTqb19mz+btLvVvKDZ5tcxkS70/tjo8ne9vZdxfw5pAJNIjDOyA+PvkFSC0eSRBVlKbWw=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 936543c1-8bac-4e91-4bad-08dc6aa76620
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2024 12:57:18.8731
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZQwiusbW9Knubu7zse9wWTxmMqwTxUMJkFTau+x2eLDOqXZdy7YknOvhe2Ja91vjTS/9wVkULzmvBbXQJf75Ew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR10MB7910
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-02_02,2024-05-02_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0
 mlxlogscore=999 suspectscore=0 mlxscore=0 spamscore=0 adultscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2405020082
X-Proofpoint-GUID: eVEweH0q0hUREho8kx2VBLOa-EeR_9F3
X-Proofpoint-ORIG-GUID: eVEweH0q0hUREho8kx2VBLOa-EeR_9F3

On Thu, May 02, 2024 at 07:00:44AM +0200, Salvatore Bonaccorso wrote:
> Hi all,
> 
> On Sat, Apr 06, 2024 at 07:28:58PM +0000, Chuck Lever III wrote:
> > 
> > 
> > > On Apr 6, 2024, at 3:15 PM, Salvatore Bonaccorso <carnil@debian.org> wrote:
> > > 
> > > Hi Chuck, hi Steve,
> > > 
> > > In Debian, as you might have heard there is a 64bit time_t
> > > transition[1] ongoing affecting the armel and armhf architectures.
> > > While doing so, nfs-utils was found to fail to build for those
> > > architectures after the switch, reported in Debian as [2]. Vladimir
> > > Petko from Ubuntu has as well filled it in [3].
> > > 
> > > [1]: https://lists.debian.org/debian-devel-announce/2024/02/msg00005.html
> > > [2]: https://bugs.debian.org/1067829
> > > [3]: https://bugzilla.kernel.org/show_bug.cgi?id=218540
> > > 
> > > The report is full-quoted below. 
> > > 
> > > Vladimir Petko has created a patch in the bugzilla which I'm attaching
> > > here as well. If this is not an acceptable format due to missing
> > > Signed-off's I'm attaching a variant with a Suggested-by for Vladimir
> > > to properly credit the patch origin.
> > > 
> > > Let me know if that works. I changed it slightly and only casting to
> > > long long, and made it almost checkpatch clean.
> > 
> > I suppose strftime(3) might be nicer, but this works.
> > 
> > Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
> 
> I noticed this is not yet applied to the repository, do you need
> anything else from me or did it just felt trouch the cracks or
> actually queued?
> 
> Asking since if you want to have it done differently I will then
> follow suit downstream as well in Debian, where we have for now
> applied the submitted patch.

Salvatore, can you resend the patch inline (not as an attachment)
 To: Steve, Cc: linux-nfs@ ?

Steve, see above for my Reviewed-by.

-- 
Chuck Lever