Received-SPF: pass (google.com: domain of linux-nfs+bounces-3143-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 3 May 2024 14:18:11 +0200
From: Joel Granados <j.granados@samsung.com>
To: Sabrina Dubroca <sd@queasysnail.net>
CC: "David S. Miller" <davem@davemloft.net>, Eric Dumazet
	<edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
	<pabeni@redhat.com>, Alexander Aring <alex.aring@gmail.com>, Stefan Schmidt
	<stefan@datenfreihafen.org>, Miquel Raynal <miquel.raynal@bootlin.com>,
	David Ahern <dsahern@kernel.org>, Steffen Klassert
	<steffen.klassert@secunet.com>, Herbert Xu <herbert@gondor.apana.org.au>,
	Matthieu Baerts <matttbe@kernel.org>, Mat Martineau <martineau@kernel.org>,
	Geliang Tang <geliang@kernel.org>, Remi Denis-Courmont
	<courmisch@gmail.com>, Allison Henderson <allison.henderson@oracle.com>,
	David Howells <dhowells@redhat.com>, Marc Dionne <marc.dionne@auristor.com>,
	Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>, Xin Long
	<lucien.xin@gmail.com>, Wenjia Zhang <wenjia@linux.ibm.com>, Jan Karcher
	<jaka@linux.ibm.com>, "D. Wythe" <alibuda@linux.alibaba.com>, Tony Lu
	<tonylu@linux.alibaba.com>, Wen Gu <guwen@linux.alibaba.com>, Trond
	Myklebust <trond.myklebust@hammerspace.com>, Anna Schumaker
	<anna@kernel.org>, Chuck Lever <chuck.lever@oracle.com>, Jeff Layton
	<jlayton@kernel.org>, Neil Brown <neilb@suse.de>, Olga Kornievskaia
	<kolga@netapp.com>, Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey
	<tom@talpey.com>, Jon Maloy <jmaloy@redhat.com>, Ying Xue
	<ying.xue@windriver.com>, Martin Schiller <ms@dev.tdt.de>, Pablo Neira Ayuso
	<pablo@netfilter.org>, Jozsef Kadlecsik <kadlec@netfilter.org>, Florian
	Westphal <fw@strlen.de>, Roopa Prabhu <roopa@nvidia.com>, Nikolay
	Aleksandrov <razor@blackwall.org>, Simon Horman <horms@verge.net.au>, Julian
	Anastasov <ja@ssi.bg>, Joerg Reuter <jreuter@yaina.de>, Luis Chamberlain
	<mcgrof@kernel.org>, Kees Cook <keescook@chromium.org>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<dccp@vger.kernel.org>, <linux-wpan@vger.kernel.org>,
	<mptcp@lists.linux.dev>, <linux-hams@vger.kernel.org>,
	<linux-rdma@vger.kernel.org>, <rds-devel@oss.oracle.com>,
	<linux-afs@lists.infradead.org>, <linux-sctp@vger.kernel.org>,
	<linux-s390@vger.kernel.org>, <linux-nfs@vger.kernel.org>,
	<tipc-discussion@lists.sourceforge.net>, <linux-x25@vger.kernel.org>,
	<netfilter-devel@vger.kernel.org>, <coreteam@netfilter.org>,
	<bridge@lists.linux.dev>, <lvs-devel@vger.kernel.org>
Subject: Re: [PATCH net-next v6 8/8] ax.25: x.25: Remove the now superfluous
 sentinel elements from ctl_table array
Message-ID: <20240503121811.fsmriwsgugzm2o7i@joelS2.panther.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="a6ejzfnlx7y2ity4"
Content-Disposition: inline
In-Reply-To: <ZjJAikcdWzzaIr1s@hog>
CMS-TYPE: 201P
References: <20240501-jag-sysctl_remset_net-v6-0-370b702b6b4a@samsung.com>
	<20240501-jag-sysctl_remset_net-v6-8-370b702b6b4a@samsung.com>
	<CGME20240501131616eucas1p28a33eeb55f6c084a0751e5b7b7d91d78@eucas1p2.samsung.com>
	<ZjJAikcdWzzaIr1s@hog>

--a6ejzfnlx7y2ity4
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 01, 2024 at 03:15:54PM +0200, Sabrina Dubroca wrote:
> 2024-05-01, 11:29:32 +0200, Joel Granados via B4 Relay wrote:
> > From: Joel Granados <j.granados@samsung.com>
> >=20
> > This commit comes at the tail end of a greater effort to remove the
> > empty elements at the end of the ctl_table arrays (sentinels) which will
> > reduce the overall build time size of the kernel and run time memory
> > bloat by ~64 bytes per sentinel (further information Link :
> > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/)
> >=20
> > Avoid a buffer overflow when traversing the ctl_table by ensuring that
> > AX25_MAX_VALUES is the same as the size of ax25_param_table. This is
> > done with a BUILD_BUG_ON where ax25_param_table is defined and a
> > CONFIG_AX25_DAMA_SLAVE guard in the unnamed enum definition as well as
> > in the ax25_dev_device_up and ax25_ds_set_timer functions.
>                                 ^^
> nit:                            not anymore ;)
> (but not worth a repost IMO)
>=20
>=20
> > diff --git a/net/ax25/ax25_ds_timer.c b/net/ax25/ax25_ds_timer.c
> > index c4f8adbf8144..c50a58d9e368 100644
> > --- a/net/ax25/ax25_ds_timer.c
> > +++ b/net/ax25/ax25_ds_timer.c
> > @@ -55,6 +55,7 @@ void ax25_ds_set_timer(ax25_dev *ax25_dev)
> >  	ax25_dev->dama.slave_timeout =3D
> >  		msecs_to_jiffies(ax25_dev->values[AX25_VALUES_DS_TIMEOUT]) / 10;
> >  	mod_timer(&ax25_dev->dama.slave_timer, jiffies + HZ);
> > +	return;
>=20
> nit: return not needed here since we're already at the bottom of the
> function, but probably not worth a repost of the series.
>=20
Thx. I will not repost, but I have changed them locally so they are
there in case a V7 is required.

Best
--=20

Joel Granados

--a6ejzfnlx7y2ity4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmY01gIACgkQupfNUreW
QU9//gwAjwm2crD0MhJ7OyswQb0Bxm/HhmEwnomCQHNxXo2qKrIBpMOS3dpgmCeX
hOvysHMzkUBRGf7mQm0veqdHNb4ZdZfRelo1i3GHxmlWlIx8J2hcZTDG8TUz6hJv
poTVkndbEa6q2rBVNPhoLnxjqLcE3yOOGvZeJv75CklJ3V/rrrBSBpSQvgisz2Rc
2lH29Ih2Lh2n1V8beefQHxMV9dbvkeiyhEpZJOCLbapjSFF8YiWjHrTDsVj74zxw
f981wsUNdFhVv0tdfKDReFydDtXT0cUw5VpHeHTbpoK08KCDc4QFw0Gxr8ycxXXt
XUYdpIioVBoSGc3I1PWDUUDfZEBawE+LVoZryY+7kEz7PJuCaryhFfkXSaXC8l0y
ODfJAEMDUeKM+xGgXgaT0kK6kb2jltciYS9/JBw38uqw7d9jHR7AYD3QTKaa1atx
hguSiJrXappxRJZDX1VvmgV9lC1Y4cAgQQJJhXnI2/Ok88cvgDfPCECVwQiTxxrp
D7SGN60B
=MN3V
-----END PGP SIGNATURE-----

--a6ejzfnlx7y2ity4--