Received-SPF: pass (google.com: domain of linux-nfs+bounces-3155-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sat, 4 May 2024 11:18:39 -0400
From: Chuck Lever <chuck.lever@oracle.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [bug report] SUNRPC: Fix svcauth_gss_proxy_init()
Message-ID: <ZjZRz3JuXPAvt3mb@tissot.1015granger.net>
References: <4d92f9a7-a278-4d61-9804-f6bc7cd7963a@moroto.mountain>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4d92f9a7-a278-4d61-9804-f6bc7cd7963a@moroto.mountain>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?ZcQMJy1yFrD5O57piRO8kFwTyTdVhdAPRTV+/J9HJyv4hSGf1Trw9I8ruxGu?=
 =?us-ascii?Q?5iYAIJK9vbpK9ZImX95bSjY3fCEsXfZZxOAx2MPdP3ymfyozf5h2XLu6VJ/X?=
 =?us-ascii?Q?hUGgZR+qBNqlay/MyqCCXfgnyDNvMroW62sDACP5rBvGqfXw/Y8PXWvA72Gp?=
 =?us-ascii?Q?kVo8CYqxwVP0GFH2erMqQinWY0Qv9XpqF7Ume22peJYtG1IGkN/cCaIbBoOV?=
 =?us-ascii?Q?3R11dLJ/bb4XIrRn+3Py9CoDTz7iN7qVM5DNv7/zyGlU9AG0jAnAXeYw8nmT?=
 =?us-ascii?Q?nU5/Lpkht6yY5RarZID39ALm6wUIXEyBttQMyulTSsCHED8NyKlfMfZAYX25?=
 =?us-ascii?Q?kIIvbydbpd/ILMTadSdAQJLpby3FKoXm+U5XguN2f2Kgipt89QsTxZQDnDhK?=
 =?us-ascii?Q?pxScmW7FV+HNVzJ7uFHq6g0O9xD9vtmTpw3h8xsnaSWahXjSjxFTFhagA3UI?=
 =?us-ascii?Q?3qVxITcoQsZNARFMZLEVLSjhLQjVdGyzef2FHj6pQRXJ0xq3mH2yKfyMIe4n?=
 =?us-ascii?Q?ITOVWdsJwETmcTtOABRBXE+nMNgPZgyjaJ9livKAwTD7nIQq5VX+R6LYBy88?=
 =?us-ascii?Q?d9FyWfZdlOkIsULCAuFo5O3lewRoBJxwiTFHmdXSapTFNpRUNOJZp+yXAoc8?=
 =?us-ascii?Q?aW2gGrj2Z0xKalDGCyVzDFFKuI18p6xNUnb/KB1l7HWlpvrSsFi28g3shxCf?=
 =?us-ascii?Q?Bif4RrxFitzQ4zkziguZJ6XF1ZqvhW0tSo5AG1HNghCnuaaK8vpBdoHd2ZuJ?=
 =?us-ascii?Q?V9oZCc3hKcVC9p8umYCKLXvAxkK1rraFVuL1cNyGEtO191+CM+vRdrrr+g+2?=
 =?us-ascii?Q?Hki8QSQ11tO8oNltyUpnRzjIFPAMXvM46lJy73qYT5gc0iZ7LM9rX+lyjs+E?=
 =?us-ascii?Q?2veC6xCtKfNpuwqwLQ9d7YiSjb6D2utYKqqzSV1+Tg3wDL2S9aaH2TxdZSBi?=
 =?us-ascii?Q?wvl2t63Q6ntMTR0/IlFI3jXL7a2LyCmI2sgCqu14KtNyNzJbDUnaehmYcB1/?=
 =?us-ascii?Q?n045TA03UWzAkge84inbId+R9XL5FzlGHgoMmrAv8rC2noy5OKeoCTkhsoO8?=
 =?us-ascii?Q?p5if7c5/Md3OS63TndIdySSFLvJ95ktmGnBVJfEr+isrM16YeiIL742q8rEi?=
 =?us-ascii?Q?eXVHYIG11/V4SAqKWHYhiACtF09wyf4m1Dq9sd32ZyEb0TUxjK+8L4zZFBdy?=
 =?us-ascii?Q?Cn/mhTdi4+keXCVJncv2uAnAWew6oG1MFTUjrC9OP7L0Ejd1+6qtm0fFkMGF?=
 =?us-ascii?Q?TAKUJkp2biosK9cg/rGEB3XuhJwB/8jKbCIv/LB7EAysCl3xAIf/z/LApFKB?=
 =?us-ascii?Q?KdfKqFR9Eah2VnWaBkqzYnT+JgxtL7HIl3Sy/qlRpFUFiLhlajdqW3oJqovL?=
 =?us-ascii?Q?UxrIY2Q42x4xnD+7MLCnVFb1+JH/kk2JtIbwr+M0rD8l43LbWZq65dmVp91V?=
 =?us-ascii?Q?zu+5KdgPh9O0bwm0+o+SjIiHw4K7Tgp+KxjYsTdIZ99Oh9y+cIje8N/AzPSx?=
 =?us-ascii?Q?knskt0uSz1tYs4g9rkKUVDPt3XgzXXUkHUZiQ3iNSRC4mQ+6KM+qegwaCwfc?=
 =?us-ascii?Q?bxNkJgWE3G3sqFUPAbFOT02PTOkhAXl+TCqbKjxC3f8G7fuwOUhN8U8vQc9L?=
 =?us-ascii?Q?Zg=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	c/d4u4SmbRAgfLUYGP54RNOhXyeT5gNcO1bA7MCKDufqxmw/OcWZbe182DLOLAkaG209+fJSAkTx6oZrw9b2mQhCTWn3++7VMoCg+dH2qDEKWeye61C/zWsNNqbiTapB2F+BMEcuRR7oEgoxLk2in1Lb8yfL+CZ0yTKVuSgBCT1q+GMZ7f6wvs+OuwDPDhtbMzEu0Qny0A6xKxZJHsW07Sez5L6Jg33Mcf4okbNKzgwPfKMbGARMp2+t/qOWl9g3wMCWgVL5zzcm2oLqtWyUUk276+kcx2nrx5bQBH+j25hvHID5gee406AcygzZ2RaBIeVLidfb9CC+H0rUPCGvdLqCPWYnRnvbEAUXEGxFpuC8vWyVP6ZCOBU+D4Meb7hMe1tdgqa4BKede7Zh9k4twaC7YwCYi/4ukFmmMFuSSM1GfcS7tzyGfTYc5rjyefDMTvb4NMWJgJ/pHNPyRo/xUfbGJMC6/RQHqEVe6bzk1gQDegXolIMZiXrnfSduBW5lE26MSzs9hPH9bKe5YbquALBgHWukuTmWSg3v0M9nG7BcbvQx8ufGZB/uMzVm+dEqi6yFf9ZIsoSqBRBG8uib6AviIH7m9nCu6K9yzKvm7mg=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 32fd00cb-7b92-4cdc-fbd3-08dc6c4d7bab
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2024 15:18:42.6872
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5LVzOA5WBHiuGYhyxroop+rHrAcH3VdEPcZpj6niJHGQcdgn7KhLfCA56M366SKwzXH9KUWaIS4b1i2cHHbWYw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5628
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-04_11,2024-05-03_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999
 bulkscore=0 suspectscore=0 spamscore=0 malwarescore=0 mlxscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2405040108
X-Proofpoint-GUID: LDNxUCqeV6saOxT_p1jj0XpuwGcS5hGE
X-Proofpoint-ORIG-GUID: LDNxUCqeV6saOxT_p1jj0XpuwGcS5hGE

On Sat, May 04, 2024 at 02:23:23PM +0300, Dan Carpenter wrote:
> Hello Chuck Lever,
> 
> Commit 5866efa8cbfb ("SUNRPC: Fix svcauth_gss_proxy_init()") from Oct
> 24, 2019 (linux-next), leads to the following Smatch static checker
> warning:
> 
> 	net/sunrpc/auth_gss/svcauth_gss.c:1039 gss_free_in_token_pages()
> 	warn: iterator 'i' not incremented

We haven't seen a problem in practice, thus it's likely that
->page_len is rarely if ever larger than a page. I will post a fix
in a day or two. Thanks, Dan!


> net/sunrpc/auth_gss/svcauth_gss.c
>     1034 static void gss_free_in_token_pages(struct gssp_in_token *in_token)
>     1035 {
>     1036         u32 inlen;
>     1037         int i;
>     1038 
> --> 1039         i = 0;
>     1040         inlen = in_token->page_len;
>     1041         while (inlen) {
>     1042                 if (in_token->pages[i])
>     1043                         put_page(in_token->pages[i]);
>                                                           ^
> This puts page zero over and over.
> 
>     1044                 inlen -= inlen > PAGE_SIZE ? PAGE_SIZE : inlen;
>     1045         }
>     1046 
>     1047         kfree(in_token->pages);
>     1048         in_token->pages = NULL;
>     1049 }
> 
> regards,
> dan carpenter
> 

-- 
Chuck Lever