Received-SPF: pass (google.com: domain of linux-nfs+bounces-3175-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 6 May 2024 12:52:20 -0400
From: Chuck Lever <chuck.lever@oracle.com>
To: trondmy@kernel.org
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/2] knfsd: LOOKUP can return an illegal error value
Message-ID: <ZjkKxPSV+iyH8Rer@tissot.1015granger.net>
References: <20240506163005.9990-1-trondmy@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240506163005.9990-1-trondmy@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?PE4kD4jivw98RolAFPPc6/UQxysWDe1wU7RePYhFCGuttwr33zIGfkob7oFG?=
 =?us-ascii?Q?wkp8nvBhBkkPxFBFN5GH4gjnTlGvaJL1SoNL/AM+07kuYQpb5odiT3EnF/05?=
 =?us-ascii?Q?JOmgHeUpOvf1KHtxPNWBCscnNvufSy3biWqsDgOeAb8ewyCO1GyOVlye51qq?=
 =?us-ascii?Q?vxb6ovSGtSkTO8YaXrnllLX70tO/JGCg9KttJXmRE/9qi2VZvEsDvMS9IBmN?=
 =?us-ascii?Q?8cAVq9pvQDurKjZVG1OCaKbuFpD8z6/FMuE4cnGiEE4dlcCL2w5CH4f7M9dj?=
 =?us-ascii?Q?CkTbgq0T76Bxbzum+BvuheRgvznqyW0XvDSP1zM9KVUn30xqEYXz4tNimTxl?=
 =?us-ascii?Q?mcwRhHpManIecFQZAezJBlBX47RREZfmYMQUcDuA/gwySAyIM2pZePiTPMnU?=
 =?us-ascii?Q?Ym2X9CZpudDgwYcxYY1njwmhAcaKEQGsDDCsk2Rv3hVe3zB0B8Evlf6bWZni?=
 =?us-ascii?Q?gQXETaHJMiSj3QT8NH91qTb/b1hY7qDVvWCabgolhfQT6BOa2P+qOFpj/G8X?=
 =?us-ascii?Q?I8VMLYBw0D+j//tz7xTjwuICZd3lTp2nkWIHBB/9j/1n/EO8Gppkh3MrMyLu?=
 =?us-ascii?Q?BcIvDxULWk9MSFVDzX+D96+a4aSCCCvvAb4bkimJTEZvl4jy6ci6A6AAZdUe?=
 =?us-ascii?Q?T1YJhZz7yCGNQGH/qSo8Z1DH2tJdS1RK1aXujECxpSb6H8AP/jNaUclXZOjP?=
 =?us-ascii?Q?8MjcSCLdBcml+GBGaZremNu/Tb9fTrhXPgw2dcMFRSIKpWqhKUiud4rXCBcx?=
 =?us-ascii?Q?BXzVwZqy0RPzRv2bFbQWACEn2kxERzPBR+5d5Cm4ocXZqHniYBdPMww8RKP6?=
 =?us-ascii?Q?oKNaTf0ydCmjzt3TS2MVo2F+PWYjZ/ZRpgQxTr2j5wsIcWBbw6TCfkisYQD/?=
 =?us-ascii?Q?rJPd1nOwIYdObX1Wg4M5uXvToZ6JT1mNu6ryz9OI0u5ddL6iQxpK6LMogc0g?=
 =?us-ascii?Q?09w46iWfv2YQqLRdEA5+0/eXvIN4bGzCgtTGzaudyfJgbx02q/tcrMtV9I4a?=
 =?us-ascii?Q?C1z0SKIGyul6i9FaG+Sa6fY6ffsRCG7OChg5vhK61pf5gMZD1xYiuGUPfKu5?=
 =?us-ascii?Q?e9PVjqixbQhIDpdkbVUfMQxhCHeI/xJsY8cFZL+LfUxl9LZ+xnKYHDsc6XlG?=
 =?us-ascii?Q?nM8g2xCJvnCpqMd9KMbvuAvB3ugfAkHfRdKewO0SydYxnZhkZt1hrKGjFkYQ?=
 =?us-ascii?Q?iJUUHSkZyJEhaUTtaIcmuRZ2TcSdO3ASokTsxOyZyzLmtztV43ZaykkCGgHy?=
 =?us-ascii?Q?JgdcgBxuZoGwSjv3sztgJzszUvG5j4fCmlJmr43oF+SrzYrM1m/n9GL2tm/m?=
 =?us-ascii?Q?boRfl616QUFYrOt3aKqhAZUPiF+St3F4RCJ+07yHpnumuk8BW73s4jIODP2h?=
 =?us-ascii?Q?8kpWETT50lv3ggOxSxjysrBuTwtvuN5rh3dzS7/lNvu/Laf6kVtQTS3MeaF2?=
 =?us-ascii?Q?g5HMttx3jg2zLwqRPl1qe7xABlv0XEACdOQEwLOqNFc0giZrGTmD0qrbV4i+?=
 =?us-ascii?Q?Gft582IbagAdztuXwQ7l/4TNWfBqjtFSRjfboBVC3KRCrE8Ekyu4j413ZDWF?=
 =?us-ascii?Q?8xC1NofU70XQu2IrqyxtrxfJEHpNshD4UMos5XTqDko613y4NjhYoRs3p9CE?=
 =?us-ascii?Q?yA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	p8xnslCHBfQGLykHCKDtKxlVos7sJbUwQFYvS3Pt74vc1ruiAH0poPWsTJnh7PrRfGE9X3VppvbQ4LiLgcOd29Q5mnjgRXLNPkEOA9f9dQ4GCTLiyZ0bCsPur/Ypeh8v59CpmhmgBWLspdJui/wr11NOM2IBsW9tVfooDUIh+9rQGJMQfHXQcHRy9BP08DNzddY7hMFxGX66HpOV9wU5RTSryeJuIYsjexzcef1ekQSEtIoWpTgZgrecCxxzUNnBPWIBrAu72s3fmqQUSQQdGOlyjuM5zdbqf+dgBNepfYtzqpEao5VHlZpEGwCxyuBJc5fw+EHzgH6HQ8ZSlQKuLM3NZ8PqxOBo1y0zcrFcVM5Otg6I2eNZrnEbyM+RTb0uFTtv9M/Q7N/WYnN6UqWzacUGi2jLevyA4PycLV9Wcc+Dp/358pJ3qXbjx2B/BsTdLZjGBo+vrqmPz7BpnqXoyFBPakoAOL5FdPlnKXtKZxao+TcUVxc4n4SZng58FRsrmCgeL68hcl9RAOgt/JEWzNTiagk3qY8DmKRUJAJkAisOsbxOkYTx2a8roGEHBn+8n31XTM39lXwLHLgWhx/rb8BvlKYAhzUm5K7svXwb5vM=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 89601f56-fbec-4164-a09d-08dc6dece657
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 16:52:22.4903
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AJvP3++D0w7YN0pP1/VVJBBroVUWubO33kJgiJSZbfCX4v2wmkaVgqllR3ftlg1GIIfM0+krWVEprBzwLtYFFQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB7538
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-06_11,2024-05-06_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxscore=0 spamscore=0
 suspectscore=0 adultscore=0 phishscore=0 mlxlogscore=906 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000
 definitions=main-2405060118
X-Proofpoint-GUID: aprUWHiKx9_aPwtIYu4OWUjYKUU9QtdR
X-Proofpoint-ORIG-GUID: aprUWHiKx9_aPwtIYu4OWUjYKUU9QtdR

On Mon, May 06, 2024 at 12:30:04PM -0400, trondmy@kernel.org wrote:
> From: Trond Myklebust <trond.myklebust@hammerspace.com>
> 
> The 'NFS error' NFSERR_OPNOTSUPP is not described by any of the official
> NFS related RFCs, but appears to have snuck into some older .x files for
> NFSv2.
> Either way, it is not in RFC1094, RFC1813 or any of the NFSv4 RFCs, so
> should not be returned by the knfsd server, and particularly not by the
> "LOOKUP" operation.
> 
> Instead, let's return NFSERR_STALE, which is more appropriate if the
> filesystem encodes the filehandle as FILEID_INVALID.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
> ---
>  fs/nfsd/nfsfh.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Hi, both applied to nfsd-next (for v6.10). Thanks!


> diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c
> index dbfa0ac13564..d41e7630eb7a 100644
> --- a/fs/nfsd/nfsfh.c
> +++ b/fs/nfsd/nfsfh.c
> @@ -572,7 +572,7 @@ fh_compose(struct svc_fh *fhp, struct svc_export *exp, struct dentry *dentry,
>  		_fh_update(fhp, exp, dentry);
>  	if (fhp->fh_handle.fh_fileid_type == FILEID_INVALID) {
>  		fh_put(fhp);
> -		return nfserr_opnotsupp;
> +		return nfserr_stale;
>  	}
>  
>  	return 0;
> @@ -598,7 +598,7 @@ fh_update(struct svc_fh *fhp)
>  
>  	_fh_update(fhp, fhp->fh_export, dentry);
>  	if (fhp->fh_handle.fh_fileid_type == FILEID_INVALID)
> -		return nfserr_opnotsupp;
> +		return nfserr_stale;
>  	return 0;
>  out_bad:
>  	printk(KERN_ERR "fh_update: fh not verified!\n");
> -- 
> 2.45.0
> 

-- 
Chuck Lever