Received-SPF: pass (google.com: domain of linux-nfs+bounces-3187-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <35d2a207-7671-4f8a-be2b-3da03fedee50@oracle.com>
Date: Mon, 6 May 2024 16:37:15 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH] NFSD: Force all NFSv4.2 COPY requests to be
 synchronous
To: cel@kernel.org, linux-nfs@vger.kernel.org
Cc: Chuck Lever <chuck.lever@oracle.com>
References: <20240506210408.4760-1-cel@kernel.org>
Content-Language: en-US
From: Dai Ngo <dai.ngo@oracle.com>
In-Reply-To: <20240506210408.4760-1-cel@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?SUpsZk8rVVZqdzJsZWNTakhLdlhTY2dwVjBhWXNaSWoyUStVb0hWMU9ZOG5C?=
 =?utf-8?B?RDBubzRqYzRoZ1dVN2R5RFhZWEJTTE9lbHRIVytpZ2lrUWZ4enBVNkJmbjZ2?=
 =?utf-8?B?ZVFvM1RXTEIySi9BM1FuaFQ4TnJQMldXdGpaalQ1NzVnV3EzWnhIcWhmYTlu?=
 =?utf-8?B?aWlkQzlvcXV5NTFHQWZrRFR2TFRZS2QrWFZuRVZzYUpQbzdJWEdmMHZqbUVT?=
 =?utf-8?B?em5NTURQa3A3VWV0ajMxem5RYkFFZWhLSjd0WnVwVS9uV1AwS214eHpadUFS?=
 =?utf-8?B?RzA0cUFYL2lzaTEzS01IQWdOQUhBUVE3QTh6SFNrWkJNelhVUC9EcGRDcVAy?=
 =?utf-8?B?S25yYWQzeGFJY1ppV2UrSDNoWS8xWW1OZWFiQXVxQmVpcXRZc2plWU1MOGpD?=
 =?utf-8?B?QlhvL0k0a1Fsc3M1ZVF2RTVOTWdZTjMvYWFDTzA2UE9nQStFSmFGTWdMRk5F?=
 =?utf-8?B?bTRVOWRQcnVYelozRThZUU1GRklNbVJ5ODFFVUNYT0ZmTVFIYjVyejUyWTVw?=
 =?utf-8?B?NDdaZXlrQk9WVmkvMldpK0RVQnZhQm82a3BZTXNEYmFkYUd1SzdWYmpHSkNq?=
 =?utf-8?B?MDdJR3RoOUdIb0RXdEdiaUU5MWQ4OXdCbnU1TXNKaS9jak1OZEN5QzhuM0Jx?=
 =?utf-8?B?Q1pEN1VnTUxqVzBxUHBJSDFmSUhzdzF2YWJwMWFaaGkycGthc1hjRHovV2Jw?=
 =?utf-8?B?cFhHTHBUVHVBaUNWcDluM2ltTE5DeWdTNm5oRW1TNEMySGFBRkNyQ3lkaFBN?=
 =?utf-8?B?aVAyd3AvWTdFNTAxS2luRHRiTS9xYktCdlFwdExsd1k0cHRHWUk3SmZ1Tk1B?=
 =?utf-8?B?aDU5NnZ6bXFUSVhKeHUzemlGQUZuYlcxKzFsRDVOdzhwTkNqd2UxdWsweDJO?=
 =?utf-8?B?dnV2R2Z2U0xIamNITkZMTi8wUTkzcGpER29ra296bEdrNFROd1BSYzRGVVBy?=
 =?utf-8?B?ZkNxdmVkbWt1ano5bUpsUGpkV2JDQ2hpWmRNb3BiR3FnWTV0dDhROTVTMklp?=
 =?utf-8?B?YngxTkFkR20xS2JueVdiWTBhYXo4eTJkaHRMWlFjZjQyZVlnS1U4YXd3R1JW?=
 =?utf-8?B?cDJ5K1FhMEpvR1AzMm12MVAyb3pYTFhzSEdycUlWYW4vQUk5WUsrRlJ5S1Nl?=
 =?utf-8?B?bTJaSkFQWS9HaGt4a2MwS0Y3LzMxeC94eDJPcTl3aGRoRTNNK3RzcHZCRHNT?=
 =?utf-8?B?ZEk4Q1dLS25LNDhBS0tkMFVIY1Y2YmZ4Zk1nK1g4Q3JEdjhHZTFKVFh5cDZo?=
 =?utf-8?B?eE5tYWtkUW1yUGVvcWIrc2J5b0VvR0p1K1RxNTdOOVVpM2N2aDZpRFRRQnNL?=
 =?utf-8?B?TU05K1JIYkF5RkcxZUsyUHJ3bGsxOVY2dmxUU1lMWGM2eVgrWXpXa0s5ZU5S?=
 =?utf-8?B?aVVpQmJBU0FSQmtxN3kxMXJOcnQ5TlR1cEkvUEQ4MFV1aUJ2a2EwWHpDVk5j?=
 =?utf-8?B?U29tazZGVFZSUXI3eUZIMFZtQ3ZMUE5KejZWOFl1emhQRUt0N0U1ZjRtZDB5?=
 =?utf-8?B?ejRhc2h5MEJIek10M0p6TENhdXRBNEh2WllyczNneEVvQ1dzR29KQ0p6bWtn?=
 =?utf-8?B?Y2pJUkEydkUrV1d0ZTlQbURiRDRBQWl2bk1JMzBRQkRmeWFDaU9aaFEzUStq?=
 =?utf-8?B?a0JxcVg1ZENWd0tjV1NGbXpVQ0ZLOTVLU1E3T05laUhwcW4reEF6THF6Rldz?=
 =?utf-8?B?VUE3K1RQaUNFME9LTzRiVmJOMTcvTjVpK1VYTXhwbk9NVWVvbHNWditwSk5o?=
 =?utf-8?B?OG5YdkhiUE03RFJhVG43Q1huOU9Zc0toS2NqNkZQSENVcUp3ZDhTQ29RNkdK?=
 =?utf-8?B?UEVMUkFrZXRPcHRhLzIyMGs2TXRCWUVhMFZKRHJ2YlBERG5ZdlJqcXhQVW5L?=
 =?utf-8?B?czV4VmVLc1lBc3NlU2lEb2JnZnMwNGFsbHlFNnNWei95N3VZb3pXY1hMTTJN?=
 =?utf-8?B?SDhaSHdUMHhqUklDMHdwaDB1UDNSOStYZkhmdml4S0xpZ0dOb1UxK3ZIMmhO?=
 =?utf-8?B?eFhHa1l4aXdzWUtybXZQdURRY1B3UFlJOGc0MEVaMVFWdXBFcnhreFMrTkVk?=
 =?utf-8?B?MTNIM2hBaGZHemhObXV2OStPSHVpWmZhbHkzaWQ3ZW9oMkwvVE1rT0h6NHky?=
 =?utf-8?Q?TLz25uvL2lpQXHlbLnVUSuzAc?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	OQ0l+80HYhf3uucAlv8pAnQcWzv2LJK79Cb1VBNv93GehroDX8WI18/9uZ62YGI7f9AAbwRfwcgntZKy9oyGNLy93DfbFEVmvpFbiGBRhJRKd8Be6aqe6bqhP4tFxuyL+X69lpE8EwXrv5aXZxCgXDIjeL+Egc8hpCrL9SfJcSFcsfwwS02Gmm45u0WKGSlSpGqCogdzZfbLPc8zaN2qikmJNbZPaBg/DdccrFEoekhY8rzmeZq2G0ZmkqDTEvpDKazItAyggMrfzu61zmSZ8NjzcRjvpcsfFZAPE30ng+GTf0Me3lLJWKjWr9tHg+EXwk5TaoXiiOpO1ImEQlD/hzVA36yQn46PX3MGPhpPWa7BBXdNVy5t18Wn8DuWpw986/xc/e+98KDUHHPMJth/YdnufQlZLVNfrErQ7k7UClQ5QgcQzztwp4GvU6nX8FDyWe4F/gQ+3yCe95bbzMrzbCLa+5D7dPcDySu1Hl2EFQCKASM8bvytVm84kJkMpmjk0ufxkju9QMep/fSsFJ8sGtZdxTk8YiHOYVsk83HyhPZ9NrJuoboCl4XwhSyKA+J4yzIFUVVlRQuv5Fn3ui+8u+kfsZ/4HRqXrz/yOIg+XmU=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 93c6fd55-dce7-466f-1a46-08dc6e2576dc
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4257.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2024 23:37:16.7859
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vNf2evIn5CIec0kV4QhDqiBb+DzWB2z1Tw+nHBLLRBB931Nur8tYIwqFU2Xkk71vGBAbmoUmprX9yZ99MseSjQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB7103
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-06_17,2024-05-06_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0
 mlxlogscore=999 bulkscore=0 mlxscore=0 adultscore=0 malwarescore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2404010000 definitions=main-2405060171
X-Proofpoint-GUID: wexCS2MRD47nhVQ7cBg00o5-cZ47973-
X-Proofpoint-ORIG-GUID: wexCS2MRD47nhVQ7cBg00o5-cZ47973-


On 5/6/24 2:04 PM, cel@kernel.org wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
>
> We've discovered that delivering a CB_OFFLOAD operation can be
> unreliable in some pretty unremarkable situations,

Since the fore and back channel use the same connection so I assume
this is not a connection related problem.

Sounds like this is a bug that we should find and fix if possible
instead of work around it. Do you know any scenarios where the
CB_OFFLOAD operation is unreliable?

-Dai

>   and the Linux
> NFS client does not yet support sending an OFFLOAD_STATUS
> operation to probe whether an asynchronous COPY operation has
> finished. On Linux NFS clients, COPY can hang until manually
> interrupted.
>
> I've tried a couple of remedies, but so far the side-effects are
> worse than the disease. For now, force COPY operations to be
> synchronous so that the use of CB_OFFLOAD is avoided entirely.
>
> I have some patches that add an OFFLOAD_STATUS implementation to the
> Linux NFS client, but that is not likely to fix older clients.
>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
>   fs/nfsd/nfs4proc.c | 7 +++++++
>   1 file changed, 7 insertions(+)
>
> diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
> index ea3cc3e870a7..12722c709cc6 100644
> --- a/fs/nfsd/nfs4proc.c
> +++ b/fs/nfsd/nfs4proc.c
> @@ -1807,6 +1807,13 @@ nfsd4_copy(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
>   	__be32 status;
>   	struct nfsd4_copy *async_copy = NULL;
>   
> +	/*
> +	 * Currently, async COPY is not reliable. Force all COPY
> +	 * requests to be synchronous to avoid client application
> +	 * hangs waiting for completion.
> +	 */
> +	nfsd4_copy_set_sync(copy, true);
> +
>   	copy->cp_clp = cstate->clp;
>   	if (nfsd4_ssc_is_inter(copy)) {
>   		trace_nfsd_copy_inter(copy);
>
> base-commit: 939cb14d51a150e3c12ef7a8ce0ba04ce6131bd2