Received-SPF: pass (google.com: domain of linux-nfs+bounces-3205-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: Benjamin Coddington <bcodding@redhat.com>
To: Olga Kornievskaia <olga.kornievskaia@gmail.com>
Cc: trond.myklebust@hammerspace.com, anna.schumaker@netapp.com,
 linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/1] pNFS/filelayout: check layout segment range
Date: Wed, 08 May 2024 10:50:06 -0400
Message-ID: <9D9DB9E5-E772-462B-BD38-7F703459A0FC@redhat.com>
In-Reply-To: <20240507195933.45683-1-olga.kornievskaia@gmail.com>
References: <20240507195933.45683-1-olga.kornievskaia@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

On 7 May 2024, at 15:59, Olga Kornievskaia wrote:

> From: Olga Kornievskaia <kolga@netapp.com>
>
> Before doing the IO, check that we have the layout covering the range of
> IO.
>
> Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
> ---
>  fs/nfs/filelayout/filelayout.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/fs/nfs/filelayout/filelayout.c b/fs/nfs/filelayout/filelayout.c
> index 85d2dc9bc212..bf3ba2e98f33 100644
> --- a/fs/nfs/filelayout/filelayout.c
> +++ b/fs/nfs/filelayout/filelayout.c
> @@ -868,6 +868,7 @@ filelayout_pg_init_read(struct nfs_pageio_descriptor *pgio,
>  			struct nfs_page *req)
>  {
>  	pnfs_generic_pg_check_layout(pgio);
> +	pnfs_generic_pg_check_range(pgio, req);
>  	if (!pgio->pg_lseg) {
>  		pgio->pg_lseg = fl_pnfs_update_layout(pgio->pg_inode,
>  						      nfs_req_openctx(req),
> @@ -892,6 +893,7 @@ filelayout_pg_init_write(struct nfs_pageio_descriptor *pgio,
>  			 struct nfs_page *req)
>  {
>  	pnfs_generic_pg_check_layout(pgio);
> +	pnfs_generic_pg_check_range(pgio, req);
>  	if (!pgio->pg_lseg) {
>  		pgio->pg_lseg = fl_pnfs_update_layout(pgio->pg_inode,
>  						      nfs_req_openctx(req),
> -- 
> 2.39.1

Looks right, less duplication to just call pnfs_generic_pg_check_range()
from pnfs_generic_pg_check_layout() now.

Reviewed-by: Benjamin Coddington <bcodding@redhat.com>

Ben