Received-SPF: pass (google.com: domain of linux-nfs+bounces-3209-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Wed, 8 May 2024 12:04:28 -0400
From: Chuck Lever <chuck.lever@oracle.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna@kernel.org>, Jeff Layton <jlayton@kernel.org>,
        Neil Brown <neilb@suse.de>, Olga Kornievskaia <kolga@netapp.com>,
        Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Subject: Re: [PATCH v1 1/1] lockd: Use *-y instead of *-objs in Makefile
Message-ID: <ZjuijMla78l+sl5S@tissot.1015granger.net>
References: <20240508151951.1445074-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240508151951.1445074-1-andriy.shevchenko@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?n3bBodQZq94hMXz0AZ+8NHw8ZFXnbyyaOFujeBciNSsixfQwd0CN9OU1NRn5?=
 =?us-ascii?Q?hRGDlCmeruTxogmX5Eop3tJvjZBRP8QSdbS3oH13yGBzV7InmWZv6zasUjqK?=
 =?us-ascii?Q?1IEjiziioeudrP6pE1NF6/TcelOtvt+/1te7qJhOz+gsxQXSA6ESVLtYd+ky?=
 =?us-ascii?Q?QKgV1oglAvwtKwwTpT2xFGiqNS6qLGo0sfEPgzww9QikvHNDUlvvSOt2QnEq?=
 =?us-ascii?Q?LjaPlwi9mZMDYBoP+KFKQGS8vs04uxB64juBZdTwUicLez16WMCD1tub18UG?=
 =?us-ascii?Q?5Hlkb4kHsadW3Pzrs0Jzn+puPHUW2993bgumf0KovWr9LPlzGWKKtdfl6988?=
 =?us-ascii?Q?U+otXQTWtoyESjjt6gKnUY7g2TaHAEFotLXjqJSD3WmltAK1raXPcTaocQZQ?=
 =?us-ascii?Q?YLbEbgUtcEUhuBg0pNPQBpKChlaVkWU+HQNYz1P/MlvRC/9BHgcwmKIPmJ36?=
 =?us-ascii?Q?0M4w3oKFDFtbOsf1H3aET44yMZu5EQz3v8Vq5cM7/HkYYHnzGTiV2N0UlNwp?=
 =?us-ascii?Q?qPY8hnKn3nS1Frkyh/hI+ifjMOodX8oazztT/Pzqh6Ia434geoDjdAects8N?=
 =?us-ascii?Q?FJDyeyjyKmSYUrMzwOafV6HAU+KLt8P+Jzpf1oaIPgstyL0wprVlfoHCJ8+A?=
 =?us-ascii?Q?2IpPQ2tcz+Ql8XIzunGYSitXSqJZA8ShpMeKJ4P3uqHu0kkcx8bV5I7SpF1r?=
 =?us-ascii?Q?5qropHoxYsc0CWMJCCoZ9lJFj7K7zjrASG+UyqhlgTbR1jb4tttnVZThpKYg?=
 =?us-ascii?Q?rF5EHTvwVv1d+hCFhbElBXdVeqG0EvPlwWM3fvolAFhLhBTAMVOoQCF+fbGd?=
 =?us-ascii?Q?/mAlr3mZRTGg5Jq+civP/Dd+v6JU6PfSWxn+z/THdlfhKmYlJxe6TRtukkFr?=
 =?us-ascii?Q?UjNXFTv3F+fzTKQoxcO6KOAvQkuw4l0jY52vXEKmmV7n2Unxt4+DJcgydwSx?=
 =?us-ascii?Q?x8YTZy4U43P4CAniQhc/TX6SAv9bhCzTMxsiGC/azybLwiNpY40FU8D/eQrV?=
 =?us-ascii?Q?uTCsekU9zSChaoMNNnIm8y/V/oyOp9BA/b2DT2NmbjyS3stVZhRNduU+gLnC?=
 =?us-ascii?Q?9d21Z7wWdgCsZYa0d1d/azTPnZPQ46Po+ZYhz4FM2CIIXdPKSm+0pafzOlJI?=
 =?us-ascii?Q?CSzrHJgs1lsWh/99r/QVRgvgCjoFzGGDb/qvXxl4y2bN5/M4rJuNN8oGm72L?=
 =?us-ascii?Q?oRgGb0Qo3M8OpuJi93Vs19jU6icbDhqDVaS8GYSZiKI+lWYerqhOhtMjFGmp?=
 =?us-ascii?Q?a2iitFZ2gCNq7OA5zybhvrTanyCfNwr1Hv+B56gNon41tgaNEiAfbHfzxwBu?=
 =?us-ascii?Q?dp0Pi2E0lzld6Ek0eh6jMEGau1GBfOOUZfZ2EVxhttHrLtX1FcYYeJsDPpT1?=
 =?us-ascii?Q?PDI/8Fo0Bc19W3Ch+w3ZdoEkWIzwNryVTAQV3YKjZwSiRm1TitIOILwdAWhu?=
 =?us-ascii?Q?VtfjFccOo/JOHIFLJxX0jsNtTrgoQ2aZVwE81+srS6+roCCGQBeZu5O1eiT0?=
 =?us-ascii?Q?c6LiQbzmteQxqFGBeN3uGH51Fdc572HJgGwuMbmELIuJRZ1H/WqhrsUANjRG?=
 =?us-ascii?Q?CzTnPVwndE1lXT3Y/25kVE/6S+0jEvRdwqB4ZA39rqG99CUSBmDuBimiyJUl?=
 =?us-ascii?Q?+A=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	F9W2dGAK+cBBTXXOOnF0OehFH3t850aXdYo7geixBPgpQUtqa8cMkztpijRXiY7lsfSBM0q3Sn/OeaJPo4sNURVDqLnON8toMYXxyTi9e1+1c1zM35kA1vW9gjRHNRZLRnBJnJIY6DQgAJGV56eIgUTsXvnm4iVUFSO8M/D6jeiI3X7Yu4iJ8UZ+U2TLrf5Ow5WZfFkbFv0i1z75fQWQ3omEikZuvOS+23ZU69AWFnLBeFR9GSeCvnl8qbIfNxTwE1hHgPAHMbtPpCZFCu6koekC0wscXBTpNDI1sR+KsYm/Uxg3OwpjR+I8DwEZMf3+nNGM84F/vqxkWj6eSJ4YMCe/GqqUoOm9pmYaANX1UVOBXejKEIrbd+30Y4dX/ccDu+NI0/F9QzR3hpKxqNxI3LjC26ocPdZr6sgA1FxSs/Uidbt8qu0uH1IuCYPWE+oJvioZYmIvvmea26otnb39/2oz4lh09PHCxBfCQbdAq5hNEBI9bUGlCGeIV8onCaBJW9gyY3N/ojqT025Q5PD0VIE/jQpJ1GYz31jyml4o9I0vgLJeM+2X4rWKgC9ZC5w+tzr7A7dBn9C/XjpqIRi/GWfR9CEPml9XBwdoqextSEs=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 57ccd085-a37a-4eb8-fd1a-08dc6f788bb7
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2024 16:04:31.1591
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r4Hfy6KwiOfEqVnjKqdHZ7ddrjzH/qkxux1eSITOGaMCRYX6Mhqyj25yh7mdgGmHSWb3QeTuzMs5U5Sp/C94kg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR10MB7706
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.11.176.26
 definitions=2024-05-08_09,2024-05-08_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 mlxscore=0
 suspectscore=0 spamscore=0 malwarescore=0 mlxlogscore=999 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2405080116
X-Proofpoint-GUID: GOa-uMlidoMDoy0Ryi_6_ZFUPGzuarH4
X-Proofpoint-ORIG-GUID: GOa-uMlidoMDoy0Ryi_6_ZFUPGzuarH4

On Wed, May 08, 2024 at 06:19:38PM +0300, Andy Shevchenko wrote:
> *-objs suffix is reserved rather for (user-space) host programs while
> usually *-y suffix is used for kernel drivers (although *-objs works
> for that purpose for now).
> 
> Let's correct the old usages of *-objs in Makefiles.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> 
> Note, the original approach is weirdest from the existing.
> Only a few drivers use this (-objs-y) one most likely by mistake.
> 
>  fs/lockd/Makefile | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/lockd/Makefile b/fs/lockd/Makefile
> index ac9f9d84510e..fe3e23dd29c3 100644
> --- a/fs/lockd/Makefile
> +++ b/fs/lockd/Makefile
> @@ -7,8 +7,7 @@ ccflags-y += -I$(src)			# needed for trace events
>  
>  obj-$(CONFIG_LOCKD) += lockd.o
>  
> -lockd-objs-y += clntlock.o clntproc.o clntxdr.o host.o svc.o svclock.o \
> -	        svcshare.o svcproc.o svcsubs.o mon.o trace.o xdr.o
> -lockd-objs-$(CONFIG_LOCKD_V4) += clnt4xdr.o xdr4.o svc4proc.o
> -lockd-objs-$(CONFIG_PROC_FS) += procfs.o
> -lockd-objs		      := $(lockd-objs-y)
> +lockd-y := clntlock.o clntproc.o clntxdr.o host.o svc.o svclock.o \
> +	   svcshare.o svcproc.o svcsubs.o mon.o trace.o xdr.o
> +lockd-$(CONFIG_LOCKD_V4) += clnt4xdr.o xdr4.o svc4proc.o
> +lockd-$(CONFIG_PROC_FS) += procfs.o
> -- 
> 2.43.0.rc1.1336.g36b5255a03ac
> 

Acked-by: Chuck Lever <chuck.lever@oracle.com>

Unless, of course, you'd like me to take this through the nfsd tree.

-- 
Chuck Lever