Received-SPF: pass (google.com: domain of linux-nfs+bounces-3222-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <17b06a56223ab70ccf79a0e6b79eef54eddc6c2e.camel@poochiereds.net>
Subject: Re: [PATCH v2] nfsd: allow more than 64 backlogged connections
From: Jeff Layton <jlayton@poochiereds.net>
To: trondmy@gmail.com, Steve Dickson <SteveD@redhat.com>
Cc: linux-nfs@vger.kernel.org
Date: Thu, 09 May 2024 06:31:09 -0700
In-Reply-To: <20240308180223.2965601-1-trond.myklebust@hammerspace.com>
References: <20240308180223.2965601-1-trond.myklebust@hammerspace.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2024-03-08 at 13:02 -0500, trondmy@gmail.com wrote:
> From: Trond Myklebust <trond.myklebust@hammerspace.com>
>=20
> When creating a listener socket to be handed to
> /proc/fs/nfsd/portlist,
> we currently limit the number of backlogged connections to 64. Since
> that value was chosen in 2006, the scale at which data centres
> operate
> has changed significantly. Given a modern server with many thousands
> of
> clients, a limit of 64 connections can create bottlenecks,
> particularly
> at at boot time.
> Let's use the POSIX-sanctioned maximum value of SOMAXCONN.
>=20
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
> ---
> v2: Use SOMAXCONN instead of a value of -1.
>=20
> =C2=A0utils/nfsd/nfssvc.c | 3 ++-
> =C2=A01 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/utils/nfsd/nfssvc.c b/utils/nfsd/nfssvc.c
> index 46452d972407..9650cecee986 100644
> --- a/utils/nfsd/nfssvc.c
> +++ b/utils/nfsd/nfssvc.c
> @@ -205,7 +205,8 @@ nfssvc_setfds(const struct addrinfo *hints, const
> char *node, const char *port)
> =C2=A0			rc =3D errno;
> =C2=A0			goto error;
> =C2=A0		}
> -		if (addr->ai_protocol =3D=3D IPPROTO_TCP &&
> listen(sockfd, 64)) {
> +		if (addr->ai_protocol =3D=3D IPPROTO_TCP &&
> +		=C2=A0=C2=A0=C2=A0 listen(sockfd, SOMAXCONN)) {
> =C2=A0			xlog(L_ERROR, "unable to create listening
> socket: "
> =C2=A0				"errno %d (%m)", errno);
> =C2=A0			rc =3D errno;

Steve,

Is there some reason you've not committed this patch? It seems fairly
straightforward. I think I sent this earlier, but:

Reviewed-by: Jeffrey Layton <jlayton@kernel.org>

--=20
Jeff Layton <jlayton@poochiereds.net>