Received-SPF: pass (google.com: domain of linux-nfs+bounces-3230-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <985974b1-2ed2-4f26-be0f-b0abfbaaea99@redhat.com>
Date: Fri, 10 May 2024 07:27:35 -0400
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] nfsd: allow more than 64 backlogged connections
To: Jeff Layton <jlayton@poochiereds.net>, trondmy@gmail.com
Cc: linux-nfs@vger.kernel.org
References: <20240308180223.2965601-1-trond.myklebust@hammerspace.com>
 <17b06a56223ab70ccf79a0e6b79eef54eddc6c2e.camel@poochiereds.net>
Content-Language: en-US
From: Steve Dickson <steved@redhat.com>
In-Reply-To: <17b06a56223ab70ccf79a0e6b79eef54eddc6c2e.camel@poochiereds.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit


On 5/9/24 9:31 AM, Jeff Layton wrote:
> On Fri, 2024-03-08 at 13:02 -0500, trondmy@gmail.com wrote:
>> From: Trond Myklebust <trond.myklebust@hammerspace.com>
>>
>> When creating a listener socket to be handed to
>> /proc/fs/nfsd/portlist,
>> we currently limit the number of backlogged connections to 64. Since
>> that value was chosen in 2006, the scale at which data centres
>> operate
>> has changed significantly. Given a modern server with many thousands
>> of
>> clients, a limit of 64 connections can create bottlenecks,
>> particularly
>> at at boot time.
>> Let's use the POSIX-sanctioned maximum value of SOMAXCONN.
>>
>> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
>> ---
>> v2: Use SOMAXCONN instead of a value of -1.
>>
>>   utils/nfsd/nfssvc.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/utils/nfsd/nfssvc.c b/utils/nfsd/nfssvc.c
>> index 46452d972407..9650cecee986 100644
>> --- a/utils/nfsd/nfssvc.c
>> +++ b/utils/nfsd/nfssvc.c
>> @@ -205,7 +205,8 @@ nfssvc_setfds(const struct addrinfo *hints, const
>> char *node, const char *port)
>>   			rc = errno;
>>   			goto error;
>>   		}
>> -		if (addr->ai_protocol == IPPROTO_TCP &&
>> listen(sockfd, 64)) {
>> +		if (addr->ai_protocol == IPPROTO_TCP &&
>> +		    listen(sockfd, SOMAXCONN)) {
>>   			xlog(L_ERROR, "unable to create listening
>> socket: "
>>   				"errno %d (%m)", errno);
>>   			rc = errno;
> 
> Steve,
> 
> Is there some reason you've not committed this patch? It seems fairly
> straightforward. I think I sent this earlier, but:
> 
> Reviewed-by: Jeffrey Layton <jlayton@kernel.org>
> 
Thanks for the poke... The patch was not on my todo list.

I'm on it...

steved.