Received-SPF: pass (google.com: domain of linux-nfs+bounces-3233-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <39ac3688-e99c-4b80-a94c-c80f9e2dc31b@redhat.com>
Date: Fri, 10 May 2024 09:18:01 -0400
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] nfsd: allow more than 64 backlogged connections
To: trondmy@gmail.com
Cc: linux-nfs@vger.kernel.org
References: <20240308180223.2965601-1-trond.myklebust@hammerspace.com>
Content-Language: en-US
From: Steve Dickson <steved@redhat.com>
In-Reply-To: <20240308180223.2965601-1-trond.myklebust@hammerspace.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 3/8/24 1:02 PM, trondmy@gmail.com wrote:
> From: Trond Myklebust <trond.myklebust@hammerspace.com>
> 
> When creating a listener socket to be handed to /proc/fs/nfsd/portlist,
> we currently limit the number of backlogged connections to 64. Since
> that value was chosen in 2006, the scale at which data centres operate
> has changed significantly. Given a modern server with many thousands of
> clients, a limit of 64 connections can create bottlenecks, particularly
> at at boot time.
> Let's use the POSIX-sanctioned maximum value of SOMAXCONN.
> 
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Committed... Sorry it took so long... The patch was not
on my radar... Feel free to ping when things linger this long.

steved.

> ---
> v2: Use SOMAXCONN instead of a value of -1.
> 
>   utils/nfsd/nfssvc.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/utils/nfsd/nfssvc.c b/utils/nfsd/nfssvc.c
> index 46452d972407..9650cecee986 100644
> --- a/utils/nfsd/nfssvc.c
> +++ b/utils/nfsd/nfssvc.c
> @@ -205,7 +205,8 @@ nfssvc_setfds(const struct addrinfo *hints, const char *node, const char *port)
>   			rc = errno;
>   			goto error;
>   		}
> -		if (addr->ai_protocol == IPPROTO_TCP && listen(sockfd, 64)) {
> +		if (addr->ai_protocol == IPPROTO_TCP &&
> +		    listen(sockfd, SOMAXCONN)) {
>   			xlog(L_ERROR, "unable to create listening socket: "
>   				"errno %d (%m)", errno);
>   			rc = errno;