Received-SPF: pass (google.com: domain of linux-nfs+bounces-3242-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Sun, 12 May 2024 21:32:40 +0200
From: Joel Granados <j.granados@samsung.com>
To: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>
CC: Kees Cook <keescook@chromium.org>, Jakub Kicinski <kuba@kernel.org>,
	Luis Chamberlain <mcgrof@kernel.org>, Eric Dumazet <edumazet@google.com>,
	Dave Chinner <david@fromorbit.com>, <linux-fsdevel@vger.kernel.org>,
	<netdev@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
	<linux-s390@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-riscv@lists.infradead.org>, <linux-mm@kvack.org>,
	<linux-security-module@vger.kernel.org>, <bpf@vger.kernel.org>,
	<linuxppc-dev@lists.ozlabs.org>, <linux-xfs@vger.kernel.org>,
	<linux-trace-kernel@vger.kernel.org>, <linux-perf-users@vger.kernel.org>,
	<netfilter-devel@vger.kernel.org>, <coreteam@netfilter.org>,
	<kexec@lists.infradead.org>, <linux-hardening@vger.kernel.org>,
	<bridge@lists.linux.dev>, <lvs-devel@vger.kernel.org>,
	<linux-rdma@vger.kernel.org>, <rds-devel@oss.oracle.com>,
	<linux-sctp@vger.kernel.org>, <linux-nfs@vger.kernel.org>,
	<apparmor@lists.ubuntu.com>
Subject: Re: [PATCH v3 00/11] sysctl: treewide: constify ctl_table argument
 of sysctl handlers
Message-ID: <20240512193240.kholmilosdqjb52p@joelS2.panther.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg="pgp-sha512";
	protocol="application/pgp-signature"; boundary="qt3jjettk7ey6stj"
Content-Disposition: inline
In-Reply-To: <8d1daa64-3746-46a3-b696-127a70cdf7e7@t-8ch.de>
CMS-TYPE: 201P
References: <20240423-sysctl-const-handler-v3-0-e0beccb836e2@weissschuh.net>
	<20240424201234.3cc2b509@kernel.org> <202405080959.104A73A914@keescook>
	<CGME20240511095125eucas1p1e6cd077a31c94dcdda88967d4ffc9262@eucas1p1.samsung.com>
	<8d1daa64-3746-46a3-b696-127a70cdf7e7@t-8ch.de>

--qt3jjettk7ey6stj
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, May 11, 2024 at 11:51:18AM +0200, Thomas Wei=DFschuh wrote:
> Hi Kees,
>=20
> On 2024-05-08 10:11:35+0000, Kees Cook wrote:
> > On Wed, Apr 24, 2024 at 08:12:34PM -0700, Jakub Kicinski wrote:
> > > On Tue, 23 Apr 2024 09:54:35 +0200 Thomas Wei=DFschuh wrote:
> > > > The series was split from my larger series sysctl-const series [0].
> > > > It only focusses on the proc_handlers but is an important step to be
> > > > able to move all static definitions of ctl_table into .rodata.
> > >=20
> > > Split this per subsystem, please.
> >=20
> > I've done a few painful API transitions before, and I don't think the
> > complexity of these changes needs a per-subsystem constification pass. I
> > think this series is the right approach, but that patch 11 will need
> > coordination with Linus. We regularly do system-wide prototype changes
> > like this right at the end of the merge window before -rc1 comes out.
>=20
> That sounds good.
>=20
> > The requirements are pretty simple: it needs to be a obvious changes
> > (this certainly is) and as close to 100% mechanical as possible. I think
> > patch 11 easily qualifies. Linus should be able to run the same Coccine=
lle
> > script and get nearly the same results, etc. And all the other changes
> > need to have landed. This change also has no "silent failure" condition=
s:
> > anything mismatched will immediately stand out.
>=20
> Unfortunately coccinelle alone is not sufficient, as some helpers with
> different prototypes are called by handlers and themselves are calling
> handler and therefore need to change in the same commit.
> But if I add a diff for those on top of the coccinelle script to the
> changelog it should be obvious.
Judging by Kees' comment on "100% mechanical", it might be better just
having the diff and have Linus apply than rather than two step process?
Have not these types of PRs, so am interested in what folks think.

>=20
> > So, have patches 1-10 go via their respective subsystems, and once all
> > of those are in Linus's tree, send patch 11 as a stand-alone PR.
>=20
> Ack, I'll do that with the cover letter information requested by Joel.
>=20
> > (From patch 11, it looks like the seccomp read/write function changes
> > could be split out? I'll do that now...)
>=20
> Thanks!
>=20
> Thomas

--=20

Joel Granados

--qt3jjettk7ey6stj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAABCgAdFiEErkcJVyXmMSXOyyeQupfNUreWQU8FAmZBGVgACgkQupfNUreW
QU9Dtgv8D/HdnyHHjf9EvZYIA7HnMu2U/9l/w1ouqfAMmi7HS4Y98dZVBP5X3MEe
5neOWNwlQN6rncGIhaLJE+q0M7KL52ej3pWS72olJGcJamFdahPGRN444v49FvCk
bCwjbHxOysmwpLAF+XsnYlOGOJ5K0n9eDONYPI2Zg+ehDHMMGyAPx6P+d7rqJzOF
WUgIsUGC75GVbawyHRi25emp4svTsNh+cnsG6Fsh8LY0u8ixH1q58bUxOq5Qu8IG
aI6TCHU/1z0iFEBV1PAF/NsFx/GHFaJ2v01TDNwEX1J4vOWE8wopJaYDVudy8MGg
z8fMq6vlMSQnY3EkN6LKkFUJyS7vnRhowXaWBrY1DoB0zKLziXHhCpWU7JzN4U4N
guxBPD1pT8LhIPGBC5wRfKO9LLe8jNKwn7ugcLdCCxzygdPjWizk0M8QVxRnhGKO
unK/FP5KS6yFMxT9sppN6halqDwjuwon9WU7vbuINgn2VhTSM7u9/kUzcuq3N/Cu
Qk1K0rUf
=w318
-----END PGP SIGNATURE-----

--qt3jjettk7ey6stj--