Received-SPF: pass (google.com: domain of linux-nfs+bounces-3265-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 16 May 2024 11:49:53 +0800
From: Zorro Lang <zlang@redhat.com>
To: Chen Hanxiao <chenhx.fnst@fujitsu.com>
Cc: fstests@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH fstests] generic/742: don't run it on NFS
Message-ID: <20240516034953.7im5grlfdr2xzs7e@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>
References: <20240515092133.1219-1-chenhx.fnst@fujitsu.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240515092133.1219-1-chenhx.fnst@fujitsu.com>

On Wed, May 15, 2024 at 05:21:33PM +0800, Chen Hanxiao wrote:
> This test requires FIEMAP support.
> 
> Signed-off-by: Chen Hanxiao <chenhx.fnst@fujitsu.com>
> ---
>  tests/generic/742 | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/generic/742 b/tests/generic/742
> index 43ebdbc6..aad57f2d 100755
> --- a/tests/generic/742
> +++ b/tests/generic/742
> @@ -30,6 +30,7 @@ _require_test
>  _require_test_program "fiemap-fault"
>  _require_test_program "punch-alternating"
>  _require_xfs_io_command "fpunch"
> +_require_xfs_io_command "fiemap"

Make sense to me. But according the change, I'd like to change the subject
from "don't run it on NFS" to "require fiemap support", due to it's not
only for NFS.

Reviewed-by: Zorro Lang <zlang@redhat.com>

>  
>  dst=$TEST_DIR/$seq/fiemap-fault
>  
> -- 
> 2.43.0
> 
>