Received-SPF: pass (google.com: domain of linux-nfs+bounces-3289-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <aa0fec0b-b12a-b0b6-2d28-bad69f6034cb@linux.dev>
Date: Mon, 20 May 2024 20:11:52 +0800
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [BUG] Linux 6.8.10 NPE
Content-Language: en-US
To: Chris Rankin <rankincj@gmail.com>, Jeff Layton <jlayton@kernel.org>
Cc: Chuck Lever <chuck.lever@oracle.com>, linux-nfs@vger.kernel.org
References: <CAK2bqVJoT3yy2m0OmTnqH9EAKkj6O1iTk42EyyMtvvxKh6YDKg@mail.gmail.com>
 <CAK2bqV+FA-bcBXeOAT93Y=-6fyXOP38yoYgH_4O+waygWLbnEg@mail.gmail.com>
 <CAK2bqVJ+GgWtjvy4wGzGqAvwoCrH2Hmo6W5oT6wu_0LXzUV3VA@mail.gmail.com>
 <0309145a87db46a4e56b83d64d2f5273990a08d7.camel@kernel.org>
 <CAK2bqVLaki4Jqq67jWcW+fedDYJRk5xrsgNZq5TH4iBTu8AvMg@mail.gmail.com>
From: Guoqing Jiang <guoqing.jiang@linux.dev>
In-Reply-To: <CAK2bqVLaki4Jqq67jWcW+fedDYJRk5xrsgNZq5TH4iBTu8AvMg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 5/19/24 23:51, Chris Rankin wrote:
> nfsd_show+0x39/0x18e:
>
> net_generic at /home/chris/LINUX/linux-6.8/include/net/netns/generic.h:47
>   42         struct net_generic *ng;
>   43         void *ptr;
>   44
>   45         rcu_read_lock();
>   46         ng = rcu_dereference(net->gen);
>> 47<        ptr = ng->ptr[id];
>   48         rcu_read_unlock();
>   49
>   50         return ptr;
>   51     }
>   52     #endif
>
> (inlined by) nfsd_show at /home/chris/LINUX/linux-6.8/fs/nfsd/stats.c:38
>   33     };
>   34
>   35     static int nfsd_show(struct seq_file *seq, void *v)
>   36     {
>   37         struct net *net = pde_data(file_inode(seq->file));

The implementation of pde_data is depend on CONFIG_PROC_FS, maybe nfsd_show
need to check the dependency too just like write_gssp.

>> 38<        struct nfsd_net *nn = net_generic(net, nfsd_net_id);
>   39         int i;
>   40
>   41         seq_printf(seq, "rc %lld %lld %lld\nfh %lld 0 0 0 0\nio
> %lld %lld\n",
>   42
> percpu_counter_sum_positive(&nn->counter[NFSD_STATS_RC_HITS]),
>   43
> percpu_counter_sum_positive(&nn->counter[NFSD_STATS_RC_MISSES]),

Thanks,
Guoqing