Received-SPF: pass (google.com: domain of linux-nfs+bounces-3299-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <8cc80bdb-9f17-4f44-b2e6-54b36ac85b63@grimberg.me>
Date: Tue, 21 May 2024 12:04:02 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Safe to delete rpcrdma.ko loading start-up code
To: Chuck Lever III <chuck.lever@oracle.com>, Jason Gunthorpe <jgg@nvidia.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
 "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
References: <DE53C92C-D16E-4FA7-9C0B-F83F03B1896F@oracle.com>
Content-Language: he-IL, en-US
From: Sagi Grimberg <sagi@grimberg.me>
In-Reply-To: <DE53C92C-D16E-4FA7-9C0B-F83F03B1896F@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 20/05/2024 21:05, Chuck Lever III wrote:
> Hi-
>
> I've tested this with two kinds of systems:
>
> 1. A system with no physical RDMA devices and no start-up
>     scripts to load these modules
>
> 2. A system with physical RDMA devices and with the start-up
>     scripts that load xprtrdma/svcrdma
>
> In both cases, after doing an "rmmod rpcrdma", I can mount
> a "proto=rdma" mount or start the NFS server, and the module
> gets reloaded automatically.
>
> I therefore believe it is safe to delete the code in the
> rdma-core start-up scripts that manually load RPC-related
> RDMA support. Either the sunrpc.ko module does this, or NFS
> user space handles it. There's no need for the rdma-core
> scripting.

I didn't know that rdma-core does this... it really shouldn't, the
mount should (and does) handle it.

I also see that srp(t) and iser(t) are loaded too.. IIRC these are
loaded by their userspace counterparts as well (or at least they
should).