Received-SPF: pass (google.com: domain of linux-nfs+bounces-3300-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <e8ab863e-18a5-4c16-b0c8-a3ab6440a9f6@molgen.mpg.de>
Date: Tue, 21 May 2024 11:55:34 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: NFSD: Unable to initialize client recovery tracking! (-110)
From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Chuck Lever <chuck.lever@oracle.com>, Jeff Layton <jlayton@kernel.org>
Cc: linux-nfs@vger.kernel.org, regressions@lists.linux.dev,
 it+linux-nfs@molgen.mpg.de
References: <aaeae060-2be0-4b9f-818c-1b7d87e41a5f@molgen.mpg.de>
Content-Language: en-US
In-Reply-To: <aaeae060-2be0-4b9f-818c-1b7d87e41a5f@molgen.mpg.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

#regzbot ^introduced: 74fd48739d04

Dear Jeff,


Am 19.04.24 um 18:50 schrieb Paul Menzel:

> Since at least Linux 6.8-rc6, Linux logs the warning below:
> 
>      NFSD: Unable to initialize client recovery tracking! (-110)
> 
> I haven’t had time to bisect yet, so if you have an idea, that’d be great.

74fd48739d0488e39ae18b0168720f449a06690c is the first bad commit
commit 74fd48739d0488e39ae18b0168720f449a06690c
Author: Jeff Layton <jlayton@kernel.org>
Date:   Fri Oct 13 09:03:53 2023 -0400

     nfsd: new Kconfig option for legacy client tracking

     We've had a number of attempts at different NFSv4 client tracking
     methods over the years, but now nfsdcld has emerged as the clear winner
     since the others (recoverydir and the usermodehelper upcall) are
     problematic.

     As a case in point, the recoverydir backend uses MD5 hashes to encode
     long form clientid strings, which means that nfsd repeatedly gets 
dinged
     on FIPS audits, since MD5 isn't considered secure. Its use of MD5 
is not
     cryptographically significant, so there is no danger there, but 
allowing
     us to compile that out allows us to sidestep the issue entirely.

     As a prelude to eventually removing support for these client tracking
     methods, add a new Kconfig option that enables them. Mark it deprecated
     and make it default to N.

     Acked-by: NeilBrown <neilb@suse.de>
     Signed-off-by: Jeff Layton <jlayton@kernel.org>
     Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

  fs/nfsd/Kconfig       | 16 +++++++++
  fs/nfsd/nfs4recover.c | 97 
+++++++++++++++++++++++++++++++++------------------
  fs/nfsd/nfsctl.c      |  6 ++++
  3 files changed, 85 insertions(+), 34 deletions(-)

`NFSD_LEGACY_CLIENT_TRACKING` is not set:

     # CONFIG_NFSD_LEGACY_CLIENT_TRACKING is not set


Kind regards,

Paul