Received-SPF: pass (google.com: domain of linux-nfs+bounces-3490-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Benjamin Coddington <bcodding@redhat.com>
To: Chen Hanxiao <chenhx.fnst@fujitsu.com>,
 Chuck Lever <chuck.lever@oracle.com>
Cc: Trond Myklebust <trondmy@kernel.org>, Anna Schumaker <anna@kernel.org>,
 Jeff Layton <jlayton@kernel.org>, Neil Brown <neilb@suse.de>,
 Olga Kornievskaia <kolga@netapp.com>, Dai Ngo <Dai.Ngo@oracle.com>,
 Tom Talpey <tom@talpey.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] SUNRPC: return proper error from gss_wrap_req_priv
Date: Thu, 30 May 2024 09:51:02 -0400
Message-ID: <E6007B79-DBB0-413A-9C46-6860AA25782D@redhat.com>
In-Reply-To: <20240523084716.524-1-chenhx.fnst@fujitsu.com>
References: <20240523084716.524-1-chenhx.fnst@fujitsu.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

On 23 May 2024, at 4:47, Chen Hanxiao wrote:

> don't return 0 if snd_buf->len really greater than snd_buf->buflen
>
> Signed-off-by: Chen Hanxiao <chenhx.fnst@fujitsu.com>

Fixes: 0c77668ddb4e ("SUNRPC: Introduce trace points in rpc_auth_gss.ko")
Reviewed-by: Benjamin Coddington <bcodding@redhat.com>

more below ..


> ---
>  net/sunrpc/auth_gss/auth_gss.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c
> index c7af0220f82f..369310909fc9 100644
> --- a/net/sunrpc/auth_gss/auth_gss.c
> +++ b/net/sunrpc/auth_gss/auth_gss.c
> @@ -1875,8 +1875,10 @@ gss_wrap_req_priv(struct rpc_cred *cred, struct gss_cl_ctx *ctx,
>  	offset = (u8 *)p - (u8 *)snd_buf->head[0].iov_base;
>  	maj_stat = gss_wrap(ctx->gc_gss_ctx, offset, snd_buf, inpages);
>  	/* slack space should prevent this ever happening: */
> -	if (unlikely(snd_buf->len > snd_buf->buflen))
> +	if (unlikely(snd_buf->len > snd_buf->buflen)) {
> +		status = -EIO;
>  		goto wrap_failed;

Maybe Chuck intended to jump to bad_wrap in 0c77668ddb4e?  Interesting that
you found this considering "slack space should prevent this ever happening".

Ben