Received-SPF: pass (google.com: domain of linux-nfs+bounces-3510-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 31 May 2024 09:20:52 -0400
From: Chuck Lever <chuck.lever@oracle.com>
To: "linux@treblig.org" <linux@treblig.org>
Cc: "jlayton@kernel.org" <jlayton@kernel.org>, "neilb@suse.de" <neilb@suse.de>,
        "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] NFSD: remove unused structs 'nfsd3_voidargs'
Message-ID: <ZlnOtPuCMc+82tdz@tissot.1015granger.net>
References: <20240531000838.332082-1-linux@treblig.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240531000838.332082-1-linux@treblig.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?46n3AeiUtVybuZNA0OXgKVEHQw2oMqBMsrx9rxBTaeiYP6NT3XTbnqDqy5ji?=
 =?us-ascii?Q?zLeb5nnkbAD6vVnuFbaVCRYMCotPkd8kmO/+OjHxHLGPQrvetyJyROPf8KW7?=
 =?us-ascii?Q?POA3BW8xt3Vg5TDpyZQ1fIDeQ3/3IrSsx683CpBiQlW9ju7tPbkp7ghpOGa0?=
 =?us-ascii?Q?si/jAo2bAwnEpoB66AIwht02urvASf3w3ufDiPZQGFQ5jH329/N9NRg92TaY?=
 =?us-ascii?Q?D9yESvG9OH0FzHHeE8iH+5XutBH+vXqt09h+biuZR+fa3P+HIoGHVSHZ1Dwg?=
 =?us-ascii?Q?rdlkg7x2+u1rol2m84cj+y7erX1C7ZTHlryX7XsX+g/qb08GnWUIif2357L5?=
 =?us-ascii?Q?3lLOLqbArw7PpEa2af5DktK3gULigPqDviz16JLvg34I3eofcXw8NGgt57gS?=
 =?us-ascii?Q?ui/iMwbiKgXFHZvnUkqnUJfgkuVUTlwlBhKt6Ka+finFzGW3M5z/bhHcG3xK?=
 =?us-ascii?Q?Gv8j91SP+NYYQxTbKtJyexziOACjlAhjU/5R0Ju46r6CwKp7pM7EgxYyN31F?=
 =?us-ascii?Q?WGECIVGOND6q2ToraAJKfslmItRrCN4zcmTfTcL6fcliqTXtTIsBmyj0zwKK?=
 =?us-ascii?Q?HG84NE0x4Z6841yOsWMbb2yVnn03FXQRkxrpa1njfIYBN8iapjXaNgUsKxvS?=
 =?us-ascii?Q?R1cvz3Ey2Qv8K002Uwohoen3uJSAR8GMLo5+rbI3sJJBi96YDOnUZKgC/f9z?=
 =?us-ascii?Q?bKIdek19oUAcwrUjTOzgZvndtm/+0+hXcwfENtIdn/bj0MSxrgqnQBoJrJmE?=
 =?us-ascii?Q?RX99v83yps7uMpcWdk+KMCrRZ2V+YaolEOuFWplkE7Wnb00A3GMKU7GQtayr?=
 =?us-ascii?Q?t/UrahsZLFG275OWrU4BFbNbR00IouQTU/dIf+dCc6m04Mrk/pIaOc1zIwjQ?=
 =?us-ascii?Q?MOQNYt8EMn9W1xHAxUtfmaUaNl9Kxrs57P4Zvbwr5ErBDitdMbaDjiCnSyNh?=
 =?us-ascii?Q?QKiLqwVAYbrMaoZKmXw3MBnhIxTVoi4v0GjZAefMVO+B/H1qMYfYaRBQ7hGR?=
 =?us-ascii?Q?G4jXLu8o825wxdGKQ+dznsAMDYqLfKB/5Zp/879KbXt0hrEHrBxrdzXaagmI?=
 =?us-ascii?Q?MD6/uZAxoIEZHw7ofnkZ8lfOUkyq+qEuc5tbBJE20LvHOATBJjiEvs8Dzuu8?=
 =?us-ascii?Q?llDRjh1qxrlLBrZmioZhlbkRuteanbUnqe0djTD6OMx+UB5s32DmI5jPIxZh?=
 =?us-ascii?Q?62TIAlohx2oNCVvcRLCYjahwA4p8JWf9pbBy4Xh5AyKld1xl8WquqgRZ0jyu?=
 =?us-ascii?Q?6HvgxiAzMz3CGeFRVCZFXYUjbtuCS6E8K9x7SPmr9xxL3EW5gq6Df8zTnhJD?=
 =?us-ascii?Q?SQVQbZsWA6maHJr5m0vkPApQTJIE72QhLsQMXEBdYSUfUCUwPu/l5JANp0wo?=
 =?us-ascii?Q?Idw3iu0xlhVLE7dkVFAN3PXIMO01qQ502ZLJ4711Ji7M7r6yk5yWn11FmrEi?=
 =?us-ascii?Q?rGfUw/GiXZwaLsbaBrwdPpv2ejkNNnZ4mqE59ShumZLKfI0CSqJPRFf1rSyw?=
 =?us-ascii?Q?V5SEFYWYj2IlOMcy0bJ2OuJfRpUTtnoCYo5zeQMG9ciRcNXojNklDhDho16K?=
 =?us-ascii?Q?0OIen8p7rYHsK6MVHcatTyx2m8JYp7ohxdwXRJRmY7jUFf+ixjOtengVDo8S?=
 =?us-ascii?Q?8g=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	cCOGKh1Q3nRpkUMERxvXJFjxIzQzv/2YhG2JloBfCvTSRCpOjpF4vAiNsuxXwcok7IHzS8qNZfs45/RulmWdpl4kJAe3r2Q13pP9aojMuMJiWyw7EK39r4zeYuMcwXCUoVi4SiruZJ3akVzJFfJvSs3RInYPNq/MXhsIW4Uu0PLuCiRn2jmOCO+lPGtdDASbAXh+pqqiNU8Jyh7lNkwHW2H5lePY6C3+6SCkeYURQ35Lz3KXlZm8aX8rgM2xSLEWNkQEiCqFFb/ZRoWGMJMtKuD6DkNm3lrI4PcnZfCZQPUJCl1OTum2IKehv5RsM3cOWhuJB1giCEWUVDgAvHd1YjOE9Pn0T5HZD+U1jB6xwhnznBkyc9HAcnmwRIrbFHFxmrzSQXRHgr0+Cpg+dq1U5r/rv+EUoczxDZt+Ug4S7Sas5XJc2gDknRWR6frs4VU5Z7Z/6dKgQRcf/x2BsasxYrDYu5vZjmt5JJU2PlzAYv4nQPb+WHcl1bh/d6R5HMV9SceIWN0wBX7SOw45Q27twPRfXFeRZqzcfvH4hIGxmiEmEudusx9oNYMWvUPAsXFyC9s1YhmojnRDNGbwdLdDubThQ7BcohmvJoHlnf6mqvY=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 76fbfa98-faad-4ee0-4bb8-08dc8174805c
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2024 13:20:55.0816
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kFyFYlI/XS3//MQqnIE4cnCrt+KnCQm5yRVc+cuRi5VHMFHDgY5LqKspuUC09wJCdf6kYJrsiTIep9Q3KzgbIA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH4PR10MB8123
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-05-31_08,2024-05-30_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 malwarescore=0 mlxscore=0
 mlxlogscore=999 phishscore=0 spamscore=0 adultscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2405310099
X-Proofpoint-ORIG-GUID: 6zHR5SK1wjPu2NG01wIzn5IM66mt-Yld
X-Proofpoint-GUID: 6zHR5SK1wjPu2NG01wIzn5IM66mt-Yld

On Thu, May 30, 2024 at 08:08:38PM -0400, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'nfsd3_voidargs' in nfs[23]acl.c is unused since
> commit 788f7183fba8 ("NFSD: Add common helpers to decode void args and
> encode void results").
> 
> Remove them.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  fs/nfsd/nfs2acl.c | 2 --
>  fs/nfsd/nfs3acl.c | 2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/fs/nfsd/nfs2acl.c b/fs/nfsd/nfs2acl.c
> index 12b2b9bc07bf..4e3be7201b1c 100644
> --- a/fs/nfsd/nfs2acl.c
> +++ b/fs/nfsd/nfs2acl.c
> @@ -308,8 +308,6 @@ static void nfsaclsvc_release_access(struct svc_rqst *rqstp)
>  	fh_put(&resp->fh);
>  }
>  
> -struct nfsd3_voidargs { int dummy; };
> -
>  #define ST 1		/* status*/
>  #define AT 21		/* attributes */
>  #define pAT (1+AT)	/* post attributes - conditional */
> diff --git a/fs/nfsd/nfs3acl.c b/fs/nfsd/nfs3acl.c
> index 73adca47d373..5e34e98db969 100644
> --- a/fs/nfsd/nfs3acl.c
> +++ b/fs/nfsd/nfs3acl.c
> @@ -221,8 +221,6 @@ static void nfs3svc_release_getacl(struct svc_rqst *rqstp)
>  	posix_acl_release(resp->acl_default);
>  }
>  
> -struct nfsd3_voidargs { int dummy; };
> -
>  #define ST 1		/* status*/
>  #define AT 21		/* attributes */
>  #define pAT (1+AT)	/* post attributes - conditional */
> -- 
> 2.45.1
> 

Applied to nfsd-next (for v6.11). Thank you!

-- 
Chuck Lever