Received-SPF: pass (google.com: domain of linux-nfs+bounces-3528-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 3 Jun 2024 09:10:04 -0400
From: Chuck Lever <chuck.lever@oracle.com>
To: Benjamin Coddington <bcodding@redhat.com>
Cc: cel@kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] SUNRPC: Fix loop termination condition in
 gss_free_in_token_pages()
Message-ID: <Zl3ArO+upgtkE2Z5@tissot.1015granger.net>
References: <20240602221525.4257-1-cel@kernel.org>
 <21189EC9-21A6-4B67-B72A-02F156DD721D@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <21189EC9-21A6-4B67-B72A-02F156DD721D@redhat.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?nHnCHCSxqghzD9i53cTGdjszSBCQ8EOJW2n4bGBPJqf230b6gNpzaFvcbHiE?=
 =?us-ascii?Q?xomwy2Y6jbMM0rk0z/T56gO38JvE6S61M8BZbstJQWm6+JO+3zSv0jZJ/sOd?=
 =?us-ascii?Q?ZccHoPvIlsSSfEt00GN+Tdz1Hv/otTWbVa0lneqApKb5JKBgIAqfXyC9OOO0?=
 =?us-ascii?Q?HJ2nkIlPegwDiqhdOIX1kfn8FO5qunC/nehm26Jan1b4x/UroKmGWo7v+eFj?=
 =?us-ascii?Q?dFWt2U8AbwD3hsVHMmtc0Hq63Ics3AvfKnOoozvLwect34VGBgS4TWrnxz/V?=
 =?us-ascii?Q?F7mgr7fS89YUOGpZvtllk7TypLpz7YnP/3FR0r0hgFs2cP+x+9+2eXMMZ5Xa?=
 =?us-ascii?Q?URSHJC94h2PRGzkeeZ3qxz90T7IV8y9Okf8CnDSAX+lpufmYpb6GggvejhxS?=
 =?us-ascii?Q?zvCjGLpr36jQcyi1tTT7Na/is/etqiL2a170ehvBFbiyuGVMKG3sDGuUE6lq?=
 =?us-ascii?Q?lGnLnUO79RjtH+oSRXWhmeas5Rl1cFNhXEFS8Puav/4NAt55m2CIr7Qb9ivA?=
 =?us-ascii?Q?ds8uNlUoou22ntANvsSQl0L1mxbXGQc8WpeIjc7/Mhxyo85sOzPK8+O2Wu3r?=
 =?us-ascii?Q?12aL1+JTOrsoA75AYeHw//J1RzuCvxv6N4JGYOJ+4bZued5TBDqmi3xs+x9i?=
 =?us-ascii?Q?MpnuFZz1XaY7Mi81AtTW8i6fuqP8Xq6ReL3B1+bswhkJYvOqpB+5Qyu/Zq6F?=
 =?us-ascii?Q?w24PHA6jKAJEQSa6/CKS3CaNwXVyXqjVyql+U3qiTbBiEQSubbOnDlPrGDgT?=
 =?us-ascii?Q?gA59P5EKYjVlIQGyny7N6no+y3gT7XztG/HXk5m8bV78J/W1/2zZKSRaQdeb?=
 =?us-ascii?Q?aDMMU+meSlRXp7gWtXdUPN9txPGvROsk8rVBXhme9zKjDyL3dcUVJf0IHIlS?=
 =?us-ascii?Q?kpNDan7t0lpzhxAdvsa+K+tKhUCDMnKU/g7t65K9J3ZQgMNHfBJL7fh7EsJr?=
 =?us-ascii?Q?LF2mpMkePFmJLGdFIXbR1bGsiEI/xfKFzApaA73WLK5h+AYL+MLipeL4DJ07?=
 =?us-ascii?Q?hTYOdv6Qf7RmWWJIq9dspW+OshmBBFdog2kFL6y2tMYLswwzo2UD57qqjyNJ?=
 =?us-ascii?Q?j6/HH17IC9nZxlYST2TiNp5wHHfu/mLEZl903zDohh0k144tFZj91GUvTVow?=
 =?us-ascii?Q?H1mG3SklTSX3pDckp41ICobZwcRJZwSPuzuBNMOCEegTOPQmarmdTyYBZSkb?=
 =?us-ascii?Q?O73ct/ALtkRHn9btbUcqsJhRN7PMVYKrbHG5NTVUQminhOiMAdNmdqwhPjf5?=
 =?us-ascii?Q?HVBMD923lOS3+dpV0irkQsqYc98DqqdUu3Irt3Ak0+wzJcJ7368YuH3qFDKM?=
 =?us-ascii?Q?8CdRMyQRKPZ60X9+1urwJfg7Y8IPUkwOfS7QK4+KRReekn+OcgMH+UO5Qdbf?=
 =?us-ascii?Q?2pVTDomYj4HzzHYKpzSCqFSyTiamtdKPB6AQhMfpNHJwRGkJhTWg06XHL/jO?=
 =?us-ascii?Q?5ME1y3CQ2RkOeE3jKSeCtw3IiqOcL7dwa/RHnK9YhU2W9ResfobLWeKmYOVA?=
 =?us-ascii?Q?srfWcotBZjBIRggJzRdPfkwo2w5H2Lle+JfuwDttqhLEwvJsKZPL4v8aYJm6?=
 =?us-ascii?Q?oNt2jsPoZuVc1eTFOeSSLMlQ8U0BQXprlaocmEXSIPtllIjzPWkMrpWK9+51?=
 =?us-ascii?Q?yA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	65CGcyXPRdabT0hV5VaHIdsrWW6L3vkiFcf9RYieFXKoOs3MeSYUlpLUQ4tPLKtwYyXwmun/O1QLlSj0N2v4m0cuJDU2vmTJCyzYwtDZRY2Fq5pdBPcSAMyXfprCTsdditBQse4qEFlfcYA9juWaCucRtzcnVQk4gwHqR2hnQGbLSSxRsTLczC7EHFrgY3u4dMwSpVAIYotdpI9c+tGg4o/UIn9GysWfTErRLLQrsiHiyuBSpm1vTd5NhlwHcLJ7CMswwNzAL5YVyx08QCeClWzUylzUh7WBxUyHMIAhkQZFFMBJZnG7MFNzaZH6wd9E8DUYMWX8y212iY9qj9vbyrikqt1crE0igvL4OfHMO1w8wCjKQ3IOphHCcbNogKCnbf9rY+EWS8onXUD+Gr8pwVsnUeKA8antI8t2NoSob9MQxu3YybMqGTeqZm4DhAkoU3JoZSd6q5MfUhqY2AT9FtGyy4tedLjg5YgkQEHuHEzmj5Lqt2en4V9n+pGpwFDD34c9ppW9Ozc+uAOd4YB2IgjpMKSBbB4SVrX/pfN6d/rjqUruYwfUrnljLpa/ybiWHivFbd/Emfuo2pnRAvNXO0ZtJH7igzjyEz44xAyWguo=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 459d6889-cde1-42ed-c928-08dc83ce7d64
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2024 13:10:07.2484
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Gb/lUnaIHQRoQEXaVXnob7uoOGU9DpodRm6v4+gkU5K3wy10uYTdYGJPXQFxNFyvh/8t+xBAyfmkjnxmDIhXTQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR10MB7910
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.650,FMLib:17.12.28.16
 definitions=2024-06-03_08,2024-05-30_01,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 malwarescore=0
 suspectscore=0 spamscore=0 mlxlogscore=746 adultscore=0 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2406030110
X-Proofpoint-ORIG-GUID: 2mm5h7mQfvKAB49q8FqFHTstk-1I_QVV
X-Proofpoint-GUID: 2mm5h7mQfvKAB49q8FqFHTstk-1I_QVV

On Mon, Jun 03, 2024 at 08:33:51AM -0400, Benjamin Coddington wrote:
> On 2 Jun 2024, at 18:15, cel@kernel.org wrote:
> 
> > From: Chuck Lever <chuck.lever@oracle.com>
> >
> > The in_token->pages[] array is not NULL terminated. This results in
> > the following KASAN splat:
> >
> >   KASAN: maybe wild-memory-access in range [0x04a2013400000008-0x04a201340000000f]
> >
> > Fixes: bafa6b4d95d9 ("SUNRPC: Fix gss_free_in_token_pages()")
> > Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> 
> Nice.
> 
> Reviewed-by: Benjamin Coddington <bcodding@redhat.com>
> 
> Ben
> 

Thank you, Ben. Applied to nfsd-fixes (for 6.10-rc).

-- 
Chuck Lever