Received-SPF: pass (google.com: domain of linux-nfs+bounces-3544-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <7df1d99d4497379c22d584bc66772bcc25173cda.camel@kernel.org>
Subject: Re: [RFC PATCH] NFSD: Fix nfsdcld warning
From: Jeff Layton <jlayton@kernel.org>
To: cel@kernel.org, linux-nfs@vger.kernel.org
Cc: Chuck Lever <chuck.lever@oracle.com>, Paul Menzel <pmenzel@molgen.mpg.de>
Date: Tue, 04 Jun 2024 14:52:49 -0400
In-Reply-To: <20240604152359.8662-2-cel@kernel.org>
References: <20240604152359.8662-2-cel@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Tue, 2024-06-04 at 11:24 -0400, cel@kernel.org wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
>=20
> Since CONFIG_NFSD_LEGACY_CLIENT_TRACKING is a new config option, its
> initial default setting should have been Y (if we are to follow the
> common practice of "default Y, wait, default N, wait, remove code").
>=20
> Paul also suggested adding a clearer remedy action to the warning
> message.
>=20
> Reported-by: Paul Menzel <pmenzel@molgen.mpg.de>
> Message-Id: <d2ab4ee7-ba0f-44ac-b921-90c8fa5a04d2@molgen.mpg.de>
> Fixes: 74fd48739d04 ("nfsd: new Kconfig option for legacy client
> tracking")
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> =C2=A0fs/nfsd/Kconfig=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 2 +-
> =C2=A0fs/nfsd/nfs4recover.c | 4 ++--
> =C2=A02 files changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/fs/nfsd/Kconfig b/fs/nfsd/Kconfig
> index 272ab8d5c4d7..ec2ab6429e00 100644
> --- a/fs/nfsd/Kconfig
> +++ b/fs/nfsd/Kconfig
> @@ -162,7 +162,7 @@ config NFSD_V4_SECURITY_LABEL
> =C2=A0config NFSD_LEGACY_CLIENT_TRACKING
> =C2=A0	bool "Support legacy NFSv4 client tracking methods
> (DEPRECATED)"
> =C2=A0	depends on NFSD_V4
> -	default n
> +	default y
> =C2=A0	help
> =C2=A0	=C2=A0 The NFSv4 server needs to store a small amount of
> information on
> =C2=A0	=C2=A0 stable storage in order to handle state recovery after
> reboot. Most
> diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c
> index 2c060e0b1604..67d8673a9391 100644
> --- a/fs/nfsd/nfs4recover.c
> +++ b/fs/nfsd/nfs4recover.c
> @@ -2086,8 +2086,8 @@ nfsd4_client_tracking_init(struct net *net)
> =C2=A0	status =3D nn->client_tracking_ops->init(net);
> =C2=A0out:
> =C2=A0	if (status) {
> -		printk(KERN_WARNING "NFSD: Unable to initialize
> client "
> -				=C2=A0=C2=A0=C2=A0 "recovery tracking! (%d)\n",
> status);
> +		pr_warn("NFSD: Unable to initialize client recovery
> tracking! (%d)\n", status);
> +		pr_warn("NFSD: Is nfsdcld running? If not, enable
> CONFIG_NFSD_LEGACY_CLIENT_TRACKING.\n");
> =C2=A0		nn->client_tracking_ops =3D NULL;
> =C2=A0	}
> =C2=A0	return status;

Reviewed-by: Jeff Layton <jlayton@kernel.org>