Received-SPF: pass (google.com: domain of linux-nfs+bounces-3550-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Tue, 4 Jun 2024 15:49:29 -0400
From: Chuck Lever <chuck.lever@oracle.com>
To: Jeff Layton <jlayton@kernel.org>
Cc: cel@kernel.org, linux-nfs@vger.kernel.org,
        Paul Menzel <pmenzel@molgen.mpg.de>
Subject: Re: [RFC PATCH] NFSD: Fix nfsdcld warning
Message-ID: <Zl9vyagyALuLZzp/@tissot.1015granger.net>
References: <20240604152359.8662-2-cel@kernel.org>
 <7df1d99d4497379c22d584bc66772bcc25173cda.camel@kernel.org>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <7df1d99d4497379c22d584bc66772bcc25173cda.camel@kernel.org>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?iso-8859-1?Q?gjpGTRAbypo6xK0E12Bh/lJicbwptFNJOx6NmhKfhshO47NzmJTnE2hN5U?=
 =?iso-8859-1?Q?FLQkwdhJ3Z0aRnx3YYY3wcKJWfIPYerlcuVgAvLP5PooRGo6VtEsaupyeP?=
 =?iso-8859-1?Q?iezmtGTD9D+bAiTiIj6JnAetNqS4PazJy1lTFwFY71B0DuHUEepdKx7mUk?=
 =?iso-8859-1?Q?lybNdcUQjCDUNKbZfMt38WZq8LRyTSp2vByJEZ38ebMC+xmFUmD5cEBtBz?=
 =?iso-8859-1?Q?rHtmyXzH6QXkRQ8GG55UdYFuhED0zhDPazlbgkMWwGiJ12xvyCpzJT25l9?=
 =?iso-8859-1?Q?HycHrVcjaJIwztjQnfYHR67O3zjhLrApDDplijE5yBYDKvyiA+dmGyjrV2?=
 =?iso-8859-1?Q?z2zIkOpOW6YipjtNc5IJTvujxf344u2DK1a7nQVRj/N3NTWV5QN+sZgeOX?=
 =?iso-8859-1?Q?XnwCvFtTttlGrO8y3ec2swxVB1CpwYuqFfGPILtz2WiuM12WPdoRZo49Ot?=
 =?iso-8859-1?Q?ggM5DLhXGwUaFN+hWH/wLAwGmn3pIpNUlZDwcmop93zFh4AJVn+dodIUy4?=
 =?iso-8859-1?Q?gLxv3MwBKiumOGba6qBdO3/PWOCKBMtSKi8RUpniFw3UmgUX4h+EMcWgUy?=
 =?iso-8859-1?Q?cdruf0q4iG3dfHjbH3x9NY3QGgkT0zG/CQQgAj0jZgbZHmUa3C5Zywpwr1?=
 =?iso-8859-1?Q?UnzyXCjfwGZjfwXHSycClTM5jVfKahkaju/o0sRkpYKJe7g9eHkjKCWg8v?=
 =?iso-8859-1?Q?at1Yd/a/oVbEDqdJ+2GEaW8hjvEsa6LDQ5dP7p+F6bJblSnWfYvcNDbwn3?=
 =?iso-8859-1?Q?mcBe0yyuaLgRXuLzH7Th/Lx20nSEGMCc/IrABVH7mE4t47qUw2ID2Kd/zG?=
 =?iso-8859-1?Q?qsVW2UVqaF9/kEsswT7RGgKKnCOGaywqj0o8i9Iek7HS3CVENe5+wMXJIM?=
 =?iso-8859-1?Q?rvYefggPtVCFZdPhkNkSxUacYJE9jQgOKkxwTLs1zw0otdmYeoJcwt065t?=
 =?iso-8859-1?Q?t1AqhNcqWkJ6/Oa8fAicdq928PXes0lrVJBM8a1r24KgSAKFiFAsBobHOq?=
 =?iso-8859-1?Q?KUUbbrxO4pjjFHvhRkS8EV+mwzkgDNAEpVshA8R7/4uJNeVYqAvKkK9FkX?=
 =?iso-8859-1?Q?91bWSvkQNVFLpnw4cQTkyl7D8W8pNAmT+ULnavXVjr2SbgOTmMdJ7z96xD?=
 =?iso-8859-1?Q?tSLcepnVcCwSnFGppcYoCU/MRFQuBrYW1OgA/VBQM7qzdJhbz/YDZqII6U?=
 =?iso-8859-1?Q?fFfZgkj/tMMYrOrvSBVYrJsqm4AIbX65TJwNt/LvYxVp55eEf8JR0qQ0ro?=
 =?iso-8859-1?Q?I5A0NF/ujfdjnfOZ/Roy1JJquKGCwu96axQ11O4/dpPcR/Ba+tYKlrUuHD?=
 =?iso-8859-1?Q?DkZAS/po9xTu5aOUEnxG0ua22vCufbd7qAgIQi0pO21bB30SD9cy+VdOZH?=
 =?iso-8859-1?Q?Eyncu0NNfIStW/IGn8lndq2psROMeDoa3mBRMXbX46YAk9eVoPV+igIEZ/?=
 =?iso-8859-1?Q?xk90yQBUa74Znh4+B9uUc3GtbX4S9bTzq1pPPcUsCzzO6bWiGSQTTx2hYD?=
 =?iso-8859-1?Q?nywyYZv5YI/ZIwnmmRU1vQtfExGQbHR49U6hI/cxhqfprP3nJgXvXsw4r7?=
 =?iso-8859-1?Q?TjpSSw6HySsZMgRY1I6nEYDnbFFPpFcEZ1V3HMBjNIT4jQDxy50hBv+NNq?=
 =?iso-8859-1?Q?VEX+Nf78m5ryiZl3RsEd4QZNBWSm0sgjF2NuPX8tL0JKmynv0oRaUxYg?=
 =?iso-8859-1?Q?=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	vWYMHc6PyLAzgdJ3s4RUaKUXQKlGX5DsT5P6tbMkSkH1G1i+00bmGlBuE8aY1IzIg464PgPOD2Ry0a8UDDvoIGEaLMsSqhiTPpib7CXW8d3TvqMNW3Rh4kBYclNa/CpQ3gOUzqYU0buWdV36llfUmEkBxoZ+soHjED1dWohXMDRk+nHXLHC1RDzDu2CMXbLWIISgHfjzjgRhiyXylSmaEYYO8dKHutc+uN0sOi2n+POlZVD/0l2QwLQcO8SUCVOYVz+EYdaqFm9ss6Mt93gaf5gxD0bu9NNDDP5C+grQkgfSFYv7WZkkQ2XFiNYWUnFfp/MNQJFV96JA9xcKsehUg3w0blq/jrxa+taKvrZWf6u141y1KNsqd+IeGZ2ReqJlTYcVnKnfY6cCVxQMKHUQmy5b3zijdAx1crNpXvnnmMPWXQYx2ACPc0BhaMu/7x25iwnfaT7RCn8JeTqf9Rn2eAbqIC5RjMYzzfPgoBXJ8ymIo0cXGSur2xm6VJYzYoRu0SGVHEPkqcDhZUzq4lt1O6rfQDoj2vFjJfCVK40RAKihlIWXk1kDuCbAUD1IeMr2G6jc12EDgH/mujlFHakV7KTEhEbaR2JqH/ISj6vHWSs=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ce77f74-19b3-4121-5ed4-08dc84cf7437
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jun 2024 19:49:32.3633
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: J411SzE3yso8N7fuRXci9r32ma/mMMfNwS1jaucd4KugtS+n1cy5JdzoB8TaxtE7Uuvjdkau35qnuG2Cv5cZaQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB7179
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-04_09,2024-06-04_02,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 adultscore=0
 phishscore=0 suspectscore=0 bulkscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2406040159
X-Proofpoint-GUID: 0ZESVEbfgwmZXTaXIekZj8p3cL9PGA0Y
X-Proofpoint-ORIG-GUID: 0ZESVEbfgwmZXTaXIekZj8p3cL9PGA0Y

On Tue, Jun 04, 2024 at 02:52:49PM -0400, Jeff Layton wrote:
> On Tue, 2024-06-04 at 11:24 -0400, cel@kernel.org wrote:
> > From: Chuck Lever <chuck.lever@oracle.com>
> > 
> > Since CONFIG_NFSD_LEGACY_CLIENT_TRACKING is a new config option, its
> > initial default setting should have been Y (if we are to follow the
> > common practice of "default Y, wait, default N, wait, remove code").
> > 
> > Paul also suggested adding a clearer remedy action to the warning
> > message.
> > 
> > Reported-by: Paul Menzel <pmenzel@molgen.mpg.de>
> > Message-Id: <d2ab4ee7-ba0f-44ac-b921-90c8fa5a04d2@molgen.mpg.de>
> > Fixes: 74fd48739d04 ("nfsd: new Kconfig option for legacy client
> > tracking")
> > Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> > ---
> > ?fs/nfsd/Kconfig?????? | 2 +-
> > ?fs/nfsd/nfs4recover.c | 4 ++--
> > ?2 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/fs/nfsd/Kconfig b/fs/nfsd/Kconfig
> > index 272ab8d5c4d7..ec2ab6429e00 100644
> > --- a/fs/nfsd/Kconfig
> > +++ b/fs/nfsd/Kconfig
> > @@ -162,7 +162,7 @@ config NFSD_V4_SECURITY_LABEL
> > ?config NFSD_LEGACY_CLIENT_TRACKING
> > ?	bool "Support legacy NFSv4 client tracking methods
> > (DEPRECATED)"
> > ?	depends on NFSD_V4
> > -	default n
> > +	default y
> > ?	help
> > ?	? The NFSv4 server needs to store a small amount of
> > information on
> > ?	? stable storage in order to handle state recovery after
> > reboot. Most
> > diff --git a/fs/nfsd/nfs4recover.c b/fs/nfsd/nfs4recover.c
> > index 2c060e0b1604..67d8673a9391 100644
> > --- a/fs/nfsd/nfs4recover.c
> > +++ b/fs/nfsd/nfs4recover.c
> > @@ -2086,8 +2086,8 @@ nfsd4_client_tracking_init(struct net *net)
> > ?	status = nn->client_tracking_ops->init(net);
> > ?out:
> > ?	if (status) {
> > -		printk(KERN_WARNING "NFSD: Unable to initialize
> > client "
> > -				??? "recovery tracking! (%d)\n",
> > status);
> > +		pr_warn("NFSD: Unable to initialize client recovery
> > tracking! (%d)\n", status);
> > +		pr_warn("NFSD: Is nfsdcld running? If not, enable
> > CONFIG_NFSD_LEGACY_CLIENT_TRACKING.\n");
> > ?		nn->client_tracking_ops = NULL;
> > ?	}
> > ?	return status;
> 
> Reviewed-by: Jeff Layton <jlayton@kernel.org>

Thanks for the review! Applied to nfsd-next (for v6.11) --
the Fixes: tag should ensure that this will be pulled into
v6.10 eventually.

-- 
Chuck Lever