Received-SPF: pass (google.com: domain of linux-nfs+bounces-3563-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <90b3b9f3-ab93-4909-99ab-f2a519a74a7f@grimberg.me>
Date: Wed, 5 Jun 2024 11:52:55 +0300
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 5/5] xprtrdma: Remove temp allocation of rpcrdma_rep
 objects
To: cel@kernel.org, Trond Myklebust <trond.myklebust@hammerspace.com>,
 Anna Schumaker <anna@kernel.org>
Cc: linux-nfs@vger.kernel.org, Chuck Lever <chuck.lever@oracle.com>
References: <20240604194522.10390-6-cel@kernel.org>
 <20240604194522.10390-10-cel@kernel.org>
Content-Language: en-US
From: Sagi Grimberg <sagi@grimberg.me>
In-Reply-To: <20240604194522.10390-10-cel@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 04/06/2024 22:45, cel@kernel.org wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
>
> The original code was designed so that most calls to
> rpcrdma_rep_create() would occur on the NUMA node that the device
> preferred. There are a few cases where that's not possible, so
> those reps are marked as temporary.
>
> However, we have the device (and its preferred node) already in
> rpcrdma_rep_create(), so let's use that to guarantee the memory
> is allocated from the correct node.

Reviewed-by: Sagi Grimberg <sagi@grimberg.me>