Received-SPF: pass (google.com: domain of linux-nfs+bounces-3617-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 7 Jun 2024 14:09:43 -0400
From: Mike Snitzer <snitzer@kernel.org>
To: linux-nfs@vger.kernel.org
Cc: Jeff Layton <jlayton@kernel.org>, Chuck Lever <chuck.lever@oracle.com>,
	Trond Myklebust <trondmy@hammerspace.com>, snitzer@hammerspace.com
Subject: Re: [for-6.11 PATCH 00/29] nfs/nfsd: add support for localio bypass
Message-ID: <ZmNM58Zx8sltLxtp@kernel.org>
References: <20240607142646.20924-1-snitzer@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240607142646.20924-1-snitzer@kernel.org>

On Fri, Jun 07, 2024 at 10:26:17AM -0400, Mike Snitzer wrote:
> 
> My container testing was done in terms of podman managed containers.
> I'd appreciate additional review relative to network namespaces.
> fs/nfsd/localio.c:nfsd_local_fakerqst_create() in particular is simply
> using the client's network namespace with rpc_net_ns(rpc_clnt). I have
> an extra patch that updates nfsd_open_local_fh()'s first argument to
> be the server's 'struct net' -- but I stopped short of formally
> including that change in this series because it hasn't proven needed
> (but more exotic hypothetical scenarios could easily expose the need
> for it). I can append it to the series as an "RFC PATCH 30/29" as
> needed.

I did just post that 30/29 patch to this thread.

And here is my git tree for these changes:
https://git.kernel.org/pub/scm/linux/kernel/git/snitzer/linux.git/log/?h=nfs-localio-for-6.11