Received-SPF: pass (google.com: domain of linux-nfs+bounces-3624-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sun, 9 Jun 2024 11:43:36 -0400
From: Chuck Lever <chuck.lever@oracle.com>
To: Julia Lawall <Julia.Lawall@inria.fr>
Cc: kernel-janitors@vger.kernel.org, Jeff Layton <jlayton@kernel.org>,
        Neil Brown <neilb@suse.de>, Olga Kornievskaia <kolga@netapp.com>,
        Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
        linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
        "Paul E . McKenney" <paulmck@kernel.org>,
        Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCH 08/14] nfsd: replace call_rcu by kfree_rcu for simple
 kmem_cache_free callback
Message-ID: <ZmXNqA/eM+j6gnWj@tissot.1015granger.net>
References: <20240609082726.32742-1-Julia.Lawall@inria.fr>
 <20240609082726.32742-9-Julia.Lawall@inria.fr>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240609082726.32742-9-Julia.Lawall@inria.fr>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?Q8I3ELmMj1n/3fiTYZP10MsMWwp6L9O4ODMAhsTlaKDPAyr4MJgy5CwZ92aJ?=
 =?us-ascii?Q?5iT8Djv09nui5Jcv/epVFyj09hpXnecejF3TpmmadG+UvZiRTQOuIDnMadZA?=
 =?us-ascii?Q?l2XOuF9tmp4ycaR6YX1hyt/DbTmMIIn4XBibffHq/BDusg7PfN6BwTkJau79?=
 =?us-ascii?Q?epakAA8dko0uBSBaVVmL/kXr15vZnqS1HVQXwy06r7BC9SnlxY9QKqmG8UAX?=
 =?us-ascii?Q?CVKSDnnhtKFfs+yP9vQ6a4hh/9mgjg4kuFPzhhnWjSjPhv6hgpC51MiuxAaD?=
 =?us-ascii?Q?nO1td4l6MYrr4Agod0QLQeOXmDy2VJKpH4g9L4mjH2QBFK7s5B9EfPNGaA51?=
 =?us-ascii?Q?TN74qvqHAwAp2Osbcht5jUvxoMsuEuCYEu0XMZbKYgYt1c+Mg3TNgnm80+/b?=
 =?us-ascii?Q?n5amnZq74fCF5mW7jARJ4/3b8jkh9E0tSTITNEOuwoN0bppHXOXCIxvUBsEC?=
 =?us-ascii?Q?Z75qhszs50XKFfLhY2RbbWGtndV8a7P58p1oIHC74mH0UhjhqQbpaLw9Qyrs?=
 =?us-ascii?Q?agjSgfw7GUNAnucnXgGG7ivgCLSb2XGzRU7CA+B3eV3Mt9bDHX55bw2F2zHG?=
 =?us-ascii?Q?PCb+e5sA6SOLneE3Klzub1x8ui0PYoximjPjZ8JU56/BgR1HD7lRQOJtjG1V?=
 =?us-ascii?Q?TMBlN9ig6dxqshXXRG4V8WfFLhDooL6JGjIDU3E0yFOvT5iMgM3aDpSA8nSn?=
 =?us-ascii?Q?USKxzyl/KkhETalQe5id+LIJV1m0yVk1/e7Eyv7eG9LuICnKGz5NNZSbXhHc?=
 =?us-ascii?Q?b9fFNQEQ17dCmi+5HDVRIqTLoglFwd/N+31HnLGixcxtTFZMcJFYJlVFzi7j?=
 =?us-ascii?Q?z2tL7CoqlmU/9LH3KpRavXJS+jrhTMPB0DGCtWHwmzyaowb6hHD2IDLjdSL8?=
 =?us-ascii?Q?YtNT0a5dqRehhmOYDl516KRbwuusxpsdRSSkXv1d4R3OOWa9RJqGFnjd4+pc?=
 =?us-ascii?Q?OgN+/NeNStlUwhNuIJFvgNjtvMEShimBGHclXSfiZb6KuHiKEe8oCNeRWmSF?=
 =?us-ascii?Q?JzbVnUh2PDRYTPEo+9PT8fkVdemUHGe9rvHXJYLEkYrwdBiH/tgTU2iBzTWU?=
 =?us-ascii?Q?FpMvT7QIdI9BaR4KIgeTRfGoKU79OIwJFWQ/Cin0W2zW3BcHK/ZxH3dc+a87?=
 =?us-ascii?Q?oYrVUgMVVfSKH2+IZ3nIjhIrI7G9TtFcSmrPW0HQBS42yh7JR7u8NX98Glrp?=
 =?us-ascii?Q?kMl45k5X/Y9pzRcGMd8j/UYfkxj7SaWrw62W1CE7lTaGdY6NBZqZLQn7MZAH?=
 =?us-ascii?Q?7LvbOb3kc3PA/2AyC6ypTuuruMvAG3NZo4wAl5U8+Yvt6oCppNpz0sfLJXZR?=
 =?us-ascii?Q?SM3u7DM2D0AF5/0uAwQnQZpF3/u1eDhHk21m/CVcqq+sKmUEAV2wES2XeTJt?=
 =?us-ascii?Q?QVvHSc23vb9zOj9W2U8Kh9zHlQzpee8HAHySD51jrRZcYVPfkRmunbDqe+ay?=
 =?us-ascii?Q?Eyh0ZC+/VVjrFjfBVKtHW/jox6y00ml6VVUDd2lPKX9HnRETnCu7TQdplyS3?=
 =?us-ascii?Q?J2T73xNTYXjpgEv7Pd9XGRysP8x+GGUta6ZM5Fy74FHKdj23xdKGmQjD5kvc?=
 =?us-ascii?Q?p+9rBQ9KR+iRTSjRCtEG8oQ3K0jPuE1pBMrNf5XaZlHp9J3vsnXKC2L15Ily?=
 =?us-ascii?Q?1w=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	uxXCfPoviiIUQ29oEaqpRL3kfZPYocoNZS8kNJFidYVAD9v+WRtcAAOMsJdJsvoyBFu5JKP9Bg3rRqFrzuoeh6/Enj0PgdNHo/ocomyKa3t19aykbXatisIbqt2ZNEF8ZZHaQwbinkweScQufClbMOT3ZqaFKXALpRfhMxkcbInminPX2Q+v+fWpq9vLLwXf5JuTtoGtKC7lq12d4OjoaBvoKopiJUWQtCOsSkwvSLhGe/7ViX9JwOqO9Y3xXwOXh7jJQcuv3WBoj5qV6q8I3sqxp3RfGFPbNlWvWyTIcb797qIEDg2ciDcS8nf2vPZWrDJud5wEQ8y2oiBUXO146I/tAlKif2lrPCjDqgUHrA7lAlL4EyO1iNYdjolVdjMlPhRJsZL45ZUcR7G8CBpb4osjctcbIlhatpE3XH4OWGBeHsXQ4fOQeAkBs4YGIEjZebZNoJFCMNlpmI3FkuPm6Fsf2q9NT8s4SZwUleLrlrI9B4Gz0kcd4it5jjrMkWoWCAjWuexPwUpEwaeX43KKOECdW5STrSCXfjBm2Q2dvV+VlCNOZTV+vfK3PK4+Z/csPgPLd3kMwCQOVxHiSYja6nDYHpXG9k20aFMAMFIsEUc=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f1714dec-5ece-4dff-63e5-08dc889aeecb
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2024 15:43:39.3774
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: agEE+2VCLUVaM76sg/bER+nrpjjlzva2nt/ssGppCHIh6uarcTM6UFkNOLvz3z/23FBOjEuxrdTimEfMSya3Rw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6135
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16
 definitions=2024-06-09_11,2024-06-06_02,2024-05-17_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 adultscore=0
 mlxscore=0 bulkscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2405010000
 definitions=main-2406090124
X-Proofpoint-GUID: kOLL6s-Q1gxt3S1Ljjh_KDhZ3B9B6PiD
X-Proofpoint-ORIG-GUID: kOLL6s-Q1gxt3S1Ljjh_KDhZ3B9B6PiD

On Sun, Jun 09, 2024 at 10:27:20AM +0200, Julia Lawall wrote:
> Since SLOB was removed, it is not necessary to use call_rcu
> when the callback only performs kmem_cache_free. Use
> kfree_rcu() directly.
> 
> The changes were done using the following Coccinelle semantic patch.
> This semantic patch is designed to ignore cases where the callback
> function is used in another way.
> 
> // <smpl>
> @r@
> expression e;
> local idexpression e2;
> identifier cb,f;
> position p;
> @@
> 
> (
> call_rcu(...,e2)
> |
> call_rcu(&e->f,cb@p)
> )
> 
> @r1@
> type T;
> identifier x,r.cb;
> @@
> 
>  cb(...) {
> (
>    kmem_cache_free(...);
> |
>    T x = ...;
>    kmem_cache_free(...,x);
> |
>    T x;
>    x = ...;
>    kmem_cache_free(...,x);
> )
>  }
> 
> @s depends on r1@
> position p != r.p;
> identifier r.cb;
> @@
> 
>  cb@p
> 
> @script:ocaml@
> cb << r.cb;
> p << s.p;
> @@
> 
> Printf.eprintf "Other use of %s at %s:%d\n"
>    cb (List.hd p).file (List.hd p).line
> 
> @depends on r1 && !s@
> expression e;
> identifier r.cb,f;
> position r.p;
> @@
> 
> - call_rcu(&e->f,cb@p)
> + kfree_rcu(e,f)
> 
> @r1a depends on !s@
> type T;
> identifier x,r.cb;
> @@
> 
> - cb(...) {
> (
> -  kmem_cache_free(...);
> |
> -  T x = ...;
> -  kmem_cache_free(...,x);
> |
> -  T x;
> -  x = ...;
> -  kmem_cache_free(...,x);
> )
> - }
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
> Reviewed-by: Paul E. McKenney <paulmck@kernel.org>
> Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
> 
> ---
>  fs/nfsd/nfs4state.c |    9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index a20c2c9d7d45..eba5083504c7 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -571,13 +571,6 @@ opaque_hashval(const void *ptr, int nbytes)
>  	return x;
>  }
>  
> -static void nfsd4_free_file_rcu(struct rcu_head *rcu)
> -{
> -	struct nfs4_file *fp = container_of(rcu, struct nfs4_file, fi_rcu);
> -
> -	kmem_cache_free(file_slab, fp);
> -}
> -
>  void
>  put_nfs4_file(struct nfs4_file *fi)
>  {
> @@ -585,7 +578,7 @@ put_nfs4_file(struct nfs4_file *fi)
>  		nfsd4_file_hash_remove(fi);
>  		WARN_ON_ONCE(!list_empty(&fi->fi_clnt_odstate));
>  		WARN_ON_ONCE(!list_empty(&fi->fi_delegations));
> -		call_rcu(&fi->fi_rcu, nfsd4_free_file_rcu);
> +		kfree_rcu(fi, fi_rcu);
>  	}
>  }
>  
> 

Acked-by: Chuck Lever <chuck.lever@oracle.com>

-- 
Chuck Lever